Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module

Hi Joao, On Thu, Mar 1, 2018 at 8:13 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > I applied this patch and here is the result: > > 2018-03-01 09:41:00 ⌚ |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web > ± |pep-8-fdw {2} U:13 ✗| → git st > On branch

Re: Feature #3061

Hello, On Fri, Mar 2, 2018 at 3:33 AM, Neethu Mariya Joy wrote: > Hi, > > Thanks for the reply. I had a look at the commit and tried out the first > part. > > I have a few doubts. > a. Now that we are adding options for each individual graph, should we > remove the previous show graphs option or

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Hello Joao, The pipeline is green and I believe the change is good to be merged. Thanks Joao On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Joao for reviewing. > > Attaching updated patch fixing PEP8 issues. > > -- > Regards, > Murtuza Zab

Re: Bug #3083 fix

Hello Neethu, We passed the patch through our CI pipeline and all tests pass. The code looks good, but we are trying to decouple files as much as we can so that we do not end up with files with over 1000 lines, that are hard to read and to maintain. Also we are trying to create Unit Tests to have

Re: Bug #2309 fix

Hello Neethu, We run the patch though our test pipeline and all tests are green. Everything looks good with this patch Thanks Joao On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy wrote: > Hi, > I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science > at BITS Pilani. > > I've

Re: Feature #3061

Hi, Thanks for the reply. I had a look at the commit and tried out the first part. I have a few doubts. a. Now that we are adding options for each individual graph, should we remove the previous show graphs option or keep it as an override when it is false? b. Do widgets include tables or just th

Re: Dark theme for pg admin 4

I'm afraid, pgAdmin4 theme is not customisable at a moment, So there is no theme support. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 28, 2018 at 2:48 AM, Daniel VanDenBosch < dvandenbo...@stoneplasticsmfg.com> wrote: > H

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Thanks Joao for reviewing. Attaching updated patch fixing PEP8 issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 1, 2018 at 8:56 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > > T

Dark theme for pg admin 4

Hello, I and my team are in and out of PG Admin a lot. The white background can be straining on our eyes. Wondering if there is a dark theme in the works??? Thanks, Dan

Bug #2309 fix

Hi, I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani. I've attempted to fix https://redmine.postgresql.org/issues/2309. Codemirrors catches all the keyboard and mouse events when 'readOnly' option is set to 'noCursor' and does not allow copying. So, I've set

Bug #3083 fix

Hi, I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani. I've attempted to fix https://redmine.postgresql.org/issues/3083. Since the textarea resize feature is the default HTML feature, I have not changed it. Instead, I've added draggable borders to the wrapper

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Hello Murtuza, The code looks pretty good, love the fact that you extracted it so that our file size stop growing and get more manageable. All tests pass on our CI. The only issue I found was linting: pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/ pgadmin/tools/sqleditor/utils/query_

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Hello Khushboo, The patch runs successfully in our CI with all tests passing. I see the test that you created, and I do not understand why we need to create tests that do HTTP requests in order to check something that is executed against the database. What I was talking about in my previous email

Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module

Hello Khushboo, I applied this patch and here is the result: 2018-03-01 09:41:00 ⌚ |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web ± |pep-8-fdw {2} U:13 ✗| → git st On branch pep-8-fdw Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git checkout

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

Hello Kushboo, Can we add some Unit test to ensure this does not happen again? Thanks Joao On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM # 3135 - [Web based] Syntax error > displayed when user try to in

[pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module

Hi, Please find the attached patch to fix the PEP-8 issues in the foreign data wrapper module. Thanks, Khushboo diff --git a/web/pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__init__.p

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

On Wed, Feb 28, 2018 at 3:10 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > I do not have the pgAgent installed so it was a little it hard to test > this. > FWIW, you don't need to install pgAgent to test this - you can just load the SQL file I sent into you

[pgAdmin4][RM#3129] handle encoding issue in File manager

Hi, PFA patch to fix the issue where user was not able to open the file with non utf-8 encoding. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.