Re: [pgadmin4] Creating a new Node in ACI Tree

Hi Joao, On Fri, Feb 23, 2018 at 11:23 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > Do we have to have that present in python in order for it to work in the > javascript? > ​No, Just create a node modal in JS with sample fields like Name/Comment etc. Ther

[pgadmin4][patch] Table Statistics in GreenPlum #3059

Hi Hackers, The attached patch fixes the statistics retrieval of tables in GreenPlum Thanks Joao diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/9.1_plus/stats.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/tab

PoC electron and pgAdmin4

Hi Hackers, After the removal of the Webkit environment we gave a shot to add electron as our runtime environment. We were able to do it with some degree of success. The links to get a version running with electron are: Windows: https://storage.googleapis.com/pgadmin-binaries/releases/pgAdmin%204%2

Re: [pgadmin4] Creating a new Node in ACI Tree

Hello Murtuza, Do we have to have that present in python in order for it to work in the javascript? I am asking this because we didn't saw any request to the backend trying to fetch this information. Thanks Joao On Fri, Feb 23, 2018 at 11:12 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.c

Re: [pgadmin4] Creating a new Node in ACI Tree

Hi Joao, Just like 'nodes' & 'children' operation, You have to implement several other methods, *'obj'* - To create, update, delete & properties for External Tables Ref: ../foreign_tables/__init__.py: 193 Which will call associated methods, def create(..), def update(...), def delete(...) & def p

[pgadmin4] Creating a new Node in ACI Tree

Hello Hackers, Need some pointers while creating new node on ACI Tree. In GreenPlum there is a concept of External Tables that are more or less similar to Foreign Wrappers, but different. So we started implementing a new node for it. We copied the Foreign Wrappers node and started it playing with

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Thanks, applied. On Fri, Feb 23, 2018 at 11:34 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to add test case to cover the scenario against RM#3014 > > > On Wed, Feb 21, 2018 at 11:09 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote

pgAdmin 4 commit: Add a test for sequence validation.

Add a test for sequence validation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54dd6aae83e4d8bff6dc4a5184722cf782977fa4 Author: Murtuza Zabuawala Modified Files -- .../schemas/sequences/tests/test_sequence_add.py | 51 +

Re: [pgadmin4] PEP-8 on pgadmin/tools

Thanks, applied. On Thu, Feb 22, 2018 at 9:04 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > I fixed the issues from the previous patch. This new patch should be > working as expected. > > Thanks > Joao > > On Thu, Feb 22, 2018 at 9:19 AM Joao De Almeida Pereira < >

pgAdmin 4 commit: PEP8 fixes for the tools module.

PEP8 fixes for the tools module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2332630af8c4995c3a3bd99679721050795ab957 Author: Joao Pedro De Almeida Pereira Modified Files -- web/pgadmin/tools/debugger/__init__.py |

Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence

Hi Dave, PFA patch to add test case to cover the scenario against RM#3014 On Wed, Feb 21, 2018 at 11:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Joao, > > ​Thank you for your time in reviewing the patch.​ > > > On Wed, Feb 21, 2018 at 9:24 PM, Joao De Almeida Pere