[pgadmin4][patch] #3099 GPDB: Creating table and creating column in table fails

2018-02-09 Thread Joao De Almeida Pereira
Hi Hackers, Attached is the patch that correct the creation of tables and columns. Also started using in a more widespread way the `compile_template_path` function to have the logic in a single place. Hides the Advanced Tab on table creation for GreenPlum Databases Correctly retrieves the collat

Jenkins build is back to normal : pgadmin4-master-python36 #472

2018-02-09 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python33 #475

2018-02-09 Thread pgAdmin 4 Jenkins
See

Re: Build failed in Jenkins: pgadmin4-master-python26 #602

2018-02-09 Thread Dave Page
Hi, Doesn't this need to include 2.7 in the test that'll install the newer version of psycopg2? e.g. psycopg2>=2.7.3.2; python_version >= '2.7' psycopg2==2.7.3.2; python_version < '2.7' Also, I think the change as written breaks the wheel generation (see the comment at the top of requirements.tx

Jenkins build is back to normal : pgadmin4-master-python34 #468

2018-02-09 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python35 #479

2018-02-09 Thread pgAdmin 4 Jenkins
See

Build failed in Jenkins: pgadmin4-master-python26 #606

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix tests for Python 3.x -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInjec

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

2018-02-09 Thread Dave Page
Thanks, applied. On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > Attached you can find the fix for the current pronlem > > > On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: > >> Hi Joao, >> >> It looks like Jenkins has taken umbrage to th

pgAdmin 4 commit: Fix tests for Python 3.x

2018-02-09 Thread Dave Page
Fix tests for Python 3.x Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c382e4d23aa66cf4ff18e25835c14a1c5fe3a9c Author: Joao Pedro De Almeida Pereira Modified Files -- web/pgadmin/tools/sqleditor/tests/test_start_query_tool.py |

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

2018-02-09 Thread Joao De Almeida Pereira
Hello, Attached you can find the fix for the current pronlem On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: > Hi Joao, > > It looks like Jenkins has taken umbrage to this change, at least with > Python 3.x. Can you take a look please? > > https://jenkins.pgadmin.org/ > > Thanks. > > On Fri, Fe

Build failed in Jenkins: pgadmin4-master-python35 #478

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix PEP-8 issues in feature_tests, dashboard, about and misc module's -- [...truncated 424.11 KB...] SynonymPutTestCase

Build failed in Jenkins: pgadmin4-master-python33 #474

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Configurable shortcuts in the Debugger. Fixes #2901 [Dave Page] Fix PEP-8 issues in feature_tests, dashboard, about and misc module's -

Build failed in Jenkins: pgadmin4-master-python36 #471

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Configurable shortcuts in the Debugger. Fixes #2901 [Dave Page] Fix PEP-8 issues in feature_tests, dashboard, about and misc module's -

Build failed in Jenkins: pgadmin4-master-python34 #467

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Configurable shortcuts in the Debugger. Fixes #2901 [Dave Page] Fix PEP-8 issues in feature_tests, dashboard, about and misc module's -

Build failed in Jenkins: pgadmin4-master-python26 #605

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Configurable shortcuts in the Debugger. Fixes #2901 [Dave Page] Fix PEP-8 issues in feature_tests, dashboard, about and misc module's -

Re: [pgAdmin4][RM#3082] Fix PEP-8 issues

2018-02-09 Thread Dave Page
Thanks, applied. On Thu, Feb 8, 2018 at 6:10 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Mon, Feb 5, 2018 at 7:55 PM, Dave Page wrote: > >> Hi >> >> On Fri, Feb 2, 2018 at 5:46 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprise

pgAdmin 4 commit: Fix PEP-8 issues in feature_tests, dashboard, about a

2018-02-09 Thread Dave Page
Fix PEP-8 issues in feature_tests, dashboard, about and misc module's python code. Fixes #3082 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6f25f4d175482af42d64df524841728b493edf72 Author: Murtuza Zabuawala Modified Files -- w

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

2018-02-09 Thread Murtuza Zabuawala
Sure. On Fri, Feb 9, 2018 at 6:14 PM, Dave Page wrote: > Thanks, applied. > > Can you please send a followup patch to include the configured keys on the > button tooltips, like we do in the Query Tool? > > > On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >>

Build failed in Jenkins: pgadmin4-master-python35 #477

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Configurable shortcuts in the Debugger. Fixes #2901 -- [...truncated 423.97 KB...] ResourceGroupsDeleteTestCase (Delete r

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

2018-02-09 Thread Dave Page
Thanks, applied. Can you please send a followup patch to include the configured keys on the button tooltips, like we do in the Query Tool? On Thu, Feb 8, 2018 at 11:32 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to make shortcut configurable in debugge

pgAdmin 4 commit: Configurable shortcuts in the Debugger. Fixes #2901

2018-02-09 Thread Dave Page
Configurable shortcuts in the Debugger. Fixes #2901 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=942ac733a40b6d5bd2d8021f8bce5363940ada44 Author: Murtuza Zabuawala Modified Files -- .../preferences_debugger_keyboard_shortcuts.p

Build failed in Jenkins: pgadmin4-master-python35 #476

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Add configurable shortcut keys for various common options in the main -- [...truncated 424.17 KB...] PackageDeleteTestCa

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

2018-02-09 Thread Dave Page
Hi Joao, It looks like Jenkins has taken umbrage to this change, at least with Python 3.x. Can you take a look please? https://jenkins.pgadmin.org/ Thanks. On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote: > Thanks, patches applied. > > On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira

Build failed in Jenkins: pgadmin4-master-python34 #466

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Support EXPLAIN on Greenplum. Fixes #3097 [Dave Page] Add configurable shortcut keys for various common options in the main -- [...trun

Build failed in Jenkins: pgadmin4-master-python36 #470

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Support EXPLAIN on Greenplum. Fixes #3097 [Dave Page] Add configurable shortcut keys for various common options in the main -- [...trun

Build failed in Jenkins: pgadmin4-master-python33 #473

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Support EXPLAIN on Greenplum. Fixes #3097 [Dave Page] Add configurable shortcut keys for various common options in the main -- [...trun

Build failed in Jenkins: pgadmin4-master-python26 #604

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Support EXPLAIN on Greenplum. Fixes #3097 [Dave Page] Add configurable shortcut keys for various common options in the main -- Started

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

2018-02-09 Thread Dave Page
Thanks, applied! A couple of things that need some more investigation/thought though: - Pressing Escape in the Query Tool and then using Alt+Shift+[ (or ] ) seems to behave oddly: - Sometimes it will work once, but then won't navigate to additional tabs. - It often seems to fill the Codemirr

pgAdmin 4 commit: Add configurable shortcut keys for various common opt

2018-02-09 Thread Dave Page
Add configurable shortcut keys for various common options in the main window. Fixes #2899 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=258b06496389e8eb1bb1b04494280e952926b92c Author: Khushboo Vashi Modified Files -- docs/en_U

Build failed in Jenkins: pgadmin4-master-python35 #475

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Support EXPLAIN on Greenplum. Fixes #3097 -- [...truncated 423.99 KB...] PackageDeleteTestCase (Fetch Package Node URL)

Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed

2018-02-09 Thread Dave Page
Thanks, patches applied. On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > This is quite a big patch in order to solve the problem with the Explain > Plan. > > We sent 2 patches that have the following: > *- update-javascript-packages.

pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-02-09 Thread Dave Page
Support EXPLAIN on Greenplum. Fixes #3097 - Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them - Extract SQLEditor backend functions that start executing query to their own files and add tests around it - Move the Explain SQL from the front-end and now

Build failed in Jenkins: pgadmin4-master-python26 #603

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update JS packages: -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] -

pgAdmin 4 commit: Update JS packages:

2018-02-09 Thread Dave Page
Update JS packages: Add package: is-docker to select a specific setting when running the Chrome tests in Docker Upgrade the version of: - babel-loader - extract-text-webpack-plugin - jasmine-core - jasmine-enzyme - moment Branch -- master Details --- https://gi

Re: Build failed in Jenkins: pgadmin4-master-python26 #602

2018-02-09 Thread Murtuza Zabuawala
Hi Dave, Newer version of psycopg2 have drop the support for Python2.6. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Feb 9, 2018 at 3:47 PM, pgAdmin 4 Jenkins wrote: > See

Build failed in Jenkins: pgadmin4-master-python26 #602

2018-02-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix quoting of function names in RE-SQL. Fixes #3060 -- Started by an SCM change [EnvInject] - Loading node environment variables. Buildi

pgAdmin 4 commit: Fix quoting of function names in RE-SQL. Fixes #3060

2018-02-09 Thread Dave Page
Fix quoting of function names in RE-SQL. Fixes #3060 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db92907fe9b98e1bcc5ec993a2c16ca0438ac283 Author: Navnath Gadakh Modified Files -- .../servers/databases/schemas/functions/__init_

Re: pgAdmin4: Patch for RM#3060

2018-02-09 Thread Dave Page
Thanks - patch applied! On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > >Please find the patch for function name quoting in SQL tab for > functions.(RM#3060 ) > > Files affected: > pgadm

Re: pgAdmin4: Patch for RM#3060

2018-02-09 Thread Dave Page
On Fri, Feb 9, 2018 at 10:06 AM, Dave Page wrote: > Hi > > On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Dave, >> >>Please find the patch for function name quoting in SQL tab for >> functions.(RM#3060

Re: pgAdmin4: Patch for RM#3060

2018-02-09 Thread Dave Page
Hi On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > >Please find the patch for function name quoting in SQL tab for > functions.(RM#3060 ) > > Files affected: > pgadmin/browser/server_gro