Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Hi Joao, On Thu, Feb 8, 2018 at 7:57 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > We were looking into the your patch and have some questions. > > - What is the reason being the front end shortcuts being registered in > the python code? There is already

Re: [pgAdmin4][RM#3082] Fix PEP-8 issues

Hi Dave, PFA updated patch. On Mon, Feb 5, 2018 at 7:55 PM, Dave Page wrote: > Hi > > On Fri, Feb 2, 2018 at 5:46 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix PEP-8 issues in feature_tests, dashboard, about and misc >> module's python code

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hi Joao, On Thu, Feb 8, 2018 at 8:07 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > After some review of the code we do have some questions: > - Do we really need to have the shortcuts in the backend?(I already asked > this in Khushboo's patch) > ​Yes, to m

Re: [pgadmin4] Hide tabs in create table

Thanks Ashesh I will give it a try and see if I can me it work. On Wed, Feb 7, 2018 at 10:04 PM Ashesh Vashi wrote: > On Thu, Feb 8, 2018 at 4:01 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi hackers, >> We are trying to hide the advanced tab in the Create Table sc

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hello Murtuza, After some review of the code we do have some questions: - Do we really need to have the shortcuts in the backend?(I already asked this in Khushboo's patch) - Do we need to have keyAction function(in direct.js) inside this Javascript file or can we extract that an create some tests

Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Hello Khushboo, We were looking into the your patch and have some questions. - What is the reason being the front end shortcuts being registered in the python code? There is already some precedent in the code, but this looks like a concern of the front end. - Didn't saw any tests around this,