[pgAdmin4][RM#3082] Fix PEP-8 issues

2018-02-02 Thread Murtuza Zabuawala
Hi, PFA patch to fix PEP-8 issues in feature_tests, dashboard, about and misc module's python code. To verify the changes, 1) activate virtual environemt 2) Navigate to ../web directory and run following pycodestyle --config=.pycodestyle ./pgadmin/misc/ pycodestyle --config=.pycodestyle ./pgadmin

Re: [pgAdmin4][RM#3016] Properly display notices in case of error

2018-02-02 Thread Dave Page
Thanks, applied. On Fri, Feb 2, 2018 at 1:51 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where users were not able to see notices in > Messages tab incase of error, I have updated redmine with sample code to > reproduce the issue. > > --

pgAdmin 4 commit: Ensure we capture notices raised by queries. Fixes #3

2018-02-02 Thread Dave Page
Ensure we capture notices raised by queries. Fixes #3027 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25647c16ba4170715243f70f194027460e1c3151 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/__init__.py

pgAdmin 4 commit: Don't quote variable values used by SET. It's usually

2018-02-02 Thread Dave Page
Don't quote variable values used by SET. It's usually going to be wrong. Fixes #3027 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d69764869bf9d1731d61d15a290388d5bd0f789 Modified Files -- .../databases/schemas/templates/macros

Re: [pgAdmin4][Patch]: RM # 2895 - All the controls and display elements in the main window to be accessible using the tab key in an appropriate order

2018-02-02 Thread Dave Page
Thanks, patch applied. On Fri, Feb 2, 2018 at 8:23 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached updated patch. > > On Mon, Jan 29, 2018 at 3:52 PM, Dave Page wrote: > >> Hi >> >> On Mon, Jan 29, 2018 at 9:00 AM, Khushboo Vashi < >> khushboo

pgAdmin 4 commit: Add keyboard navigation options for the main browser

2018-02-02 Thread Dave Page
Add keyboard navigation options for the main browser windows. Fixes #2895 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=262d01bf01e3a38a01bc1b368ca601d3cc6a7960 Author: Khushboo Vashi Modified Files -- .../preferences_browser_ke

[pgAdmin4][RM#3016] Properly display notices in case of error

2018-02-02 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where users were not able to see notices in Messages tab incase of error, I have updated redmine with sample code to reproduce the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadm