pgAdmin 4 commit: Fix a referenced before assignment bug in connection

2018-01-03 Thread Ashesh Vashi
Fix a referenced before assignment bug in connection management. Fixes #2868 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa148078e6300839223ee41e1d37bd4423413d72 Author: Harshal Dhumal Modified Files -- web/pgadmin/bro

pgAdmin 4 commit: Allow configuration of CSV and clipboard formatting o

2018-01-03 Thread Ashesh Vashi
Allow configuration of CSV and clipboard formatting of query results. Fixes #2781 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7c3d52aa82ef8eb70019befb6dee8dc00ea73d8 Author: Khushboo Vashi Modified Files -- docs/en_U

pgAdmin 4 commit: Doc screenshot update

2018-01-03 Thread Ashesh Vashi
Doc screenshot update Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46e3f664e9d3eb0d96a6cdab3ddd07026b509718 Author: Chethana Kumar Modified Files -- docs/en_US/images/server_advanced.png | Bin docs/en_US/images/server

pgAdmin 4 commit: Re-hash the way that we handle rendering of special t

2018-01-03 Thread Ashesh Vashi
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56ff374f643e2ff9e7eacf394b4d7af685af3b33 Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Confirm with the user before exiting the runtime. Fix

2018-01-03 Thread Ashesh Vashi
Confirm with the user before exiting the runtime. Fixes #2443 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66805b1e6680b4d263700d47ddb258fcf95eed45 Author: Neel Patel Modified Files -- runtime/BrowserWindow.cpp | 2 +- 1

pgAdmin 4 commit: Tag some translations that were not, well, tagged. Cu

2018-01-03 Thread Ashesh Vashi
Tag some translations that were not, well, tagged. Current stats: 1481 of 1777 messages (83%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1777 messages (95%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1472 of 1777 messages (82%) translated in pgadmin

pgAdmin 4 commit: Disable the line ending check entirely in eslint, as

2018-01-03 Thread Ashesh Vashi
Disable the line ending check entirely in eslint, as the previous platform-specific fix doesn't work with all versions. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3570c22de5ff3017c1298f66dd083d5393b5034 Author: Dave Page Modifi

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-03 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=527b502633465f4c853434c0625833f96fcf44da Author: Harshal Dhumal Mod

pgAdmin 4 commit: Some browsers don't properly support tri-state checkb

2018-01-03 Thread Ashesh Vashi
Some browsers don't properly support tri-state checkboxes, so create our own control to handle true/false/null. Fixes #2848 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8694cd0c1a81f214d92df42cdc80598e6ecfc1a Author: Murtuza Zabuaw

pgAdmin 4 commit: Stop Python 2.6 barfing on newer versions of Selenium

2018-01-03 Thread Ashesh Vashi
Stop Python 2.6 barfing on newer versions of Selenium Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3a4b627a3e535337ed8a021db02454f4c56a779 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 1

pgAdmin 4 commit: Add optional TLS support to the docker container.

2018-01-03 Thread Ashesh Vashi
Add optional TLS support to the docker container. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=272b8ee948c4955392245afc9cf7f98274a267f8 Author: Dave Page Modified Files -- pkg/docker/pgadmin4.conf | 22 -

pgAdmin 4 commit: Revert "Fix a number of cases where strings were not

2018-01-03 Thread Ashesh Vashi
Revert "Fix a number of cases where strings were not properly marked for translation." This reverts commit 1f23838a4c2c4919499bb07f41efab7202843016 due to unintended side effects it caused - specifically, expanding Databases on the treeview displayed Servers again Branch -- WEBPACK_DEVEL2

pgAdmin 4 commit: Updated colours of tree view icons, which is to be mo

2018-01-03 Thread Ashesh Vashi
Updated colours of tree view icons, which is to be more comfortable in identifying. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=849ad18d733ce5c59dcbb3ede77803c188f32856 Author: Chethana Kumar Modified Files -- .../bro

pgAdmin 4 commit: Check and attempt to fir the registry on Windows, if

2018-01-03 Thread Ashesh Vashi
Check and attempt to fir the registry on Windows, if the text/css type is misconfigured. Fixes #2716 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=920b648485327c595f9d6775c9a8015f1061b16a Author: Neel Patel Modified Files -

pgAdmin 4 commit: Ensure we can download large files and keep the user

2018-01-03 Thread Ashesh Vashi
Ensure we can download large files and keep the user informed about progress. Fixes #2829. Fixes #2491. Fixes #2715 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=162dda0f1f997f75540733dda49f1720349060bc Author: Neel Patel Modified

pgAdmin 4 commit: Revert inadvertant change to doc page

2018-01-03 Thread Ashesh Vashi
Revert inadvertant change to doc page Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=068f84804fc2c33b2d5c8742de147e7fa83e468f Author: Dave Page Modified Files -- docs/en_US/pgadmin_login.rst | 2 -- 1 file changed, 2 delet

pgAdmin 4 commit: Fix bundle creation on Windows which was failing due

2018-01-03 Thread Ashesh Vashi
Fix bundle creation on Windows which was failing due to \r\n line endings in code mirror. Fixes #2908 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f60c77d151e7041e53a7e050a10c99394fac0df Author: Maxim Zakharov Modified Files

pgAdmin 4 commit: Doc updates for server connection dialogue and relate

2018-01-03 Thread Ashesh Vashi
Doc updates for server connection dialogue and related info. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0494a91178563c93ef86ca39af36f6c5f1dddc05 Author: Susan Douglas Modified Files -- docs/en_US/server_dialog.rst | 2

pgAdmin 4 commit: Preferences dialogue help update.

2018-01-03 Thread Ashesh Vashi
Preferences dialogue help update. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c73be9186c78f75f24801e30dcac09b89bb3e3f Author: Susan Douglas Modified Files -- docs/en_US/preferences.rst | 8 1 file changed, 8 d

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-03 Thread Dave Page
Hi On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch based on new design suggested by Chethana. > The patch also includes some misc fixes related to object validation. > RM#2475 > This seems much nicer, but I still think t

Re: [pgAdmin4][Patch]: RM #2933 - Add support for transition tables in Postgres 10 triggers

2018-01-03 Thread Dave Page
Thanks, patch applied. On Mon, Dec 25, 2017 at 7:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. One small change made in the SQL > file due to fix for RM #2945. > > Thanks, > Khushboo > > On Fri, Dec 22, 2017 at 3:14 PM, Khushboo

pgAdmin 4 commit: Allow use of transition tables in PG 10 triggers. Fix

2018-01-03 Thread Dave Page
Allow use of transition tables in PG 10 triggers. Fixes #2933 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=711fbd51441f24225da8a07cee66f61b41345c95 Author: Khushboo Vashi Modified Files -- .../templates/trigger/sql/10_plus/crea

Re: [pgAdmin4][Patch]: Fix "Create - Table" dialog UI quirks

2018-01-03 Thread Dave Page
Thanks, patch applied. On Tue, Dec 26, 2017 at 8:14 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the create table dialog UI related issue where NULL and > Primary key switch toggles at different speed in the grid and there was a > error message fli

pgAdmin 4 commit: Ensure the switch animation is consistent on the tabl

2018-01-03 Thread Dave Page
Ensure the switch animation is consistent on the table dialogue and avoid displaying an error incorrectly. Fixes #2624 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0810c681c34a3d6ec1db4b83a4b6024efa94ccd5 Author: Murtuza Zabuawala Modifie

Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

2018-01-03 Thread Dave Page
Hi On Mon, Dec 25, 2017 at 11:03 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #2963: Backup database, Restore > database and Maintenance Database failed for é object. > With the patch applied, I get: 2018-01-03 15:23:00,110: INF

Re: [pgAdmin4][Patch]: Clear the content of message tab properly

2018-01-03 Thread Dave Page
Thanks, applied. On Wed, Dec 27, 2017 at 12:31 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where the content of message tab was not > getting cleared after user executes Explain and Explain Analyze option from > query tool. > RM#2974 > >

pgAdmin 4 commit: Clear the messages tab when running EXPLAIN/EXPLAIN A

2018-01-03 Thread Dave Page
Clear the messages tab when running EXPLAIN/EXPLAIN ANALYZE. Fixes #2974 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c15d81426812fd6af0ed823480321bac77d81ec4 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/js/sq

Re: docker container fails to start after stopping

2018-01-03 Thread Mark Deneen
Thanks, Dave! On Wed, Jan 3, 2018 at 7:56 AM, Dave Page wrote: > > > On Tue, Jan 2, 2018 at 6:42 PM, Mark Deneen wrote: >> >> I submitted a pull request on github, but it appears that you prefer >> to use a mailing list for such things. >> >> Attached is a patch to correct the behavior in the Do

Re: [pgAdmin4][Patch]: Prevent adding same server multiple times if connection is slow

2018-01-03 Thread Dave Page
Thanks, applied. On Mon, Dec 25, 2017 at 9:00 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where user was able to click on save button > multiple times if the connection is slow, this may result user adding the > same server multiple time

pgAdmin 4 commit: Prevent multiple connections to new slow-to-respond s

2018-01-03 Thread Dave Page
Prevent multiple connections to new slow-to-respond servers being initiated in error. Fixes #2928 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e21f1e3291657f457c171cfd868cabcad71ceed3 Author: Murtuza Zabuawala Modified Files -

Re: [pgAdmin4][Patch]: RM #2945 - [Web based] Message "can't execute an empty query" displayed if user Click Yes on constrains trigger for view trigger

2018-01-03 Thread Dave Page
Thanks, patch applied. On Mon, Dec 25, 2017 at 7:11 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #2945 : [Web based] Message > "can't execute an empty query" displayed if user Click Yes on constrains > trigger for view trigger >

pgAdmin 4 commit: Ensure invalid options can't be selected on triggers

2018-01-03 Thread Dave Page
Ensure invalid options can't be selected on triggers on views. Fixes #2945 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49dfd6fe314109c065dab6e477abc867c6e04ab2 Author: Khushboo Vashi Modified Files -- .../tables/templates/trig

Re: [pgAdmin4][Patch]: RM #2956 - pgAdmin 2.0 Preferences: User language drop down remains on screen if not collapsed

2018-01-03 Thread Dave Page
Thanks, patch applied. On Fri, Dec 22, 2017 at 1:25 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM # 2956 - pgAdmin 2.0 Preferences: > User language drop down remains on screen if not collapsed. > > Thanks, > Khushboo > -- Dave

pgAdmin 4 commit: Close user language preference drop down when it lose

2018-01-03 Thread Dave Page
Close user language preference drop down when it loses focus. Fixes #2956 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90629da524294925632ef1f4036befb162f95981 Author: Khushboo Vashi Modified Files -- web/pgadmin/preferences/st

Re: [pgAdmin4][Patch]: Do not decrypt the password when the password is 'None'

2018-01-03 Thread Dave Page
Thanks, applied. On Fri, Dec 22, 2017 at 6:32 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where we were getting exception ValueError: IV > must be 16 bytes long while decrypting the password. > RM#2765 > > Steps to re-produce: > 1) Creat

pgAdmin 4 commit: Do not decrypt the password when the password is 'Non

2018-01-03 Thread Dave Page
Do not decrypt the password when the password is 'None'. Fixes #2765 This should avoid the common but harmless exception "ValueError: IV must be 16 bytes long while decrypting the password." Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1dd

pgAdmin 4 commit: Show complete SQL for FTS dictionaries. Fixes #2949

2018-01-03 Thread Dave Page
Show complete SQL for FTS dictionaries. Fixes #2949 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e64bc2a821b1afe066e9bcb612b596c5fa2e3c0a Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/fts_dictionaries/_

Re: [pgAdmin4][Patch]: RM #2949 : [Web Based] Complete sql should displayed for fts directory in sql pane

2018-01-03 Thread Dave Page
Thanks, patch applied. On Thu, Dec 21, 2017 at 7:38 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #2949 : [Web Based] Complete sql > should displayed for fts directory in sql pane. > > Thanks, > Khushboo > -- Dave Page Blog: ht

Re: pgAdmin - RM 2953 - Update to server_dialog.rst file

2018-01-03 Thread Dave Page
Hi Thanks - applied! FYI, the patch applied without any problems using "git apply", however there were some embedded control characters (zero width spaces). I removed them: -* Specify the IP address of the server host, or the fully qualified domain name in the *Host name/address* field. On Unix

Re: [INSTALLERS] pgAdmin 4: Add-on support

2018-01-03 Thread Ashesh Vashi
Gentle Reminder. :-) FYI - I've rebased this branch from origin/master. -- Thanks, Ashesh On Wed, Dec 13, 2017 at 8:36 PM, Dave Page wrote: > The code is broken right now - see https://redmine. > postgresql.org/issues/2952. Once it's fixed, I can do this, assuming I > can find the spare time.

pgAdmin 4 commit: Correct the description for the host name field on th

2018-01-03 Thread Dave Page
Correct the description for the host name field on the server dialogue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8194e7c0f53fb6017e40d99b457ab65900b27d4 Author: Susan Douglas Modified Files -- docs/en_US/server_dialog.rst

pgAdmin 4 commit: Remove any Apache HTTPD PID file before starting the

2018-01-03 Thread Ashesh Vashi
Remove any Apache HTTPD PID file before starting the container, to prevent failures during restart. (cherry picked from commit 3289a18a1a6bb99360894bffa5c192c37cda485d) Conflicts: pkg/docker/entry.sh Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadm

pgAdmin 4 commit: Allow selection of SSL certificates and pgpass files

2018-01-03 Thread Ashesh Vashi
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649. Fixes #2650 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1d6c1323286521d05ae355be8d14374cd3e17d5a Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Bump version for some dev builds.

2018-01-03 Thread Ashesh Vashi
Bump version for some dev builds. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a23d0a73ade37c74a12610d0333f386133b15c9b Author: Dave Page Modified Files -- web/config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 del

pgAdmin 4 commit: Don't un-comment code with alt+. in the query tool. I

2018-01-03 Thread Ashesh Vashi
Don't un-comment code with alt+. in the query tool. It's only supposed to respond to ctrl/cmd+. Fixes #2769 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6898b0e4c5c2dfd29a5d1ece77cb46312fbb5870 Author: Murtuza Zabuawala Modified F

pgAdmin 4 commit: Update query tool docs.

2018-01-03 Thread Ashesh Vashi
Update query tool docs. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47fc970fae4c867d3897bcedc2661cd8b1803db3 Author: Susan Douglas Modified Files -- docs/en_US/developer_tools.rst | 1 + docs/en_US/editgrid.rs

pgAdmin 4 commit: Ensure the datatype cache is updated when a domain is

2018-01-03 Thread Ashesh Vashi
Ensure the datatype cache is updated when a domain is added. Fixes #2778 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e09cf061ea44d45e895cc9a643cc311b44356154 Author: Murtuza Zabuawala Modified Files -- .../servers/data

pgAdmin 4 commit: Add support for editing data in tables with OIDs but

2018-01-03 Thread Ashesh Vashi
Add support for editing data in tables with OIDs but no primary keys. Fixes #2849. This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh. Branch -- WEBPACK_DEVEL2 Details --- htt

pgAdmin 4 commit: Resolved the logo issue.

2018-01-03 Thread Ashesh Vashi
Resolved the logo issue. For some unknown reason, font-mfizz was showing the slonik icon in italic. Even after upgrading it to the latest version of font-mfizz, the problem was not resolved. So - instead of using the vector font, using the PostgreSQL SVG logo as the application icon, and document

pgAdmin 4 commit: Changed array representation and formatting for the d

2018-01-03 Thread Ashesh Vashi
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b742bdc5173f6167fd64151078de09ea70a07e9 Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Extending the tools, and miscellaneous javascript mod

2018-01-03 Thread Ashesh Vashi
Extending the tools, and miscellaneous javascript modules from the browser tools. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e38bf8493e8b1dbba4144b9307d51a36e4209c1 Modified Files -- web/pgadmin/tools/datagrid/static/

pgAdmin 4 commit: No longer using the 'get_own_javascripts' method for

2018-01-03 Thread Ashesh Vashi
No longer using the 'get_own_javascripts' method for refering the javascript modules exposed through a module, instead added them in the webpack (shim) configuration directly. Instead - exposed a new method - 'get_javascript_entries' to be used later by the new implementation of the webpack config

pgAdmin 4 commit: Remove any Apache HTTPD PID file before starting the

2018-01-03 Thread Dave Page
Remove any Apache HTTPD PID file before starting the container, to prevent failures during restart. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3289a18a1a6bb99360894bffa5c192c37cda485d Author: Mark Deneen Modified Files -- pk

pgAdmin 4 commit: Improve icon alignment.

2018-01-03 Thread Ashesh Vashi
Improve icon alignment. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed94285f9668379a5602df563877a697a38140c0 Author: Chethana Kumar Modified Files -- .../browser/server_groups/servers/databases/casts/static/img/cast.sv

pgAdmin 4 commit: Upgraded the font-mfizz to latest version (v:2.4.1) t

2018-01-03 Thread Ashesh Vashi
Upgraded the font-mfizz to latest version (v:2.4.1) to resolve an issue, about showing the PostgreSQL logo in italic in runtime on windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1c89aecff27e0c6739ec54ca6230cc727da40676 Modifi

Re: docker container fails to start after stopping

2018-01-03 Thread Dave Page
On Tue, Jan 2, 2018 at 6:42 PM, Mark Deneen wrote: > I submitted a pull request on github, but it appears that you prefer > to use a mailing list for such things. > > Attached is a patch to correct the behavior in the Docker container. > > The problem is that apache generates httpd.pid at startup

pgAdmin 4 commit: Enable webpackaging the pgadmin javascript files in d

2018-01-03 Thread Ashesh Vashi
Enable webpackaging the pgadmin javascript files in different small modules, which can be referred from other modules. We can have two types of webpack modules. 1. Reference (using the dll plugin of webpack) This type of webpack module can be referred from the other webpack modules. And, it

pgAdmin 4 commit: Allow to terminate a session from the server, and dat

2018-01-03 Thread Ashesh Vashi
Allow to terminate a session from the server, and database dashboard. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe0945bf3be521eea33e08cfad78dfbfdfb848ad Modified Files -- web/pgadmin/dashboard/static/js/dashboard.js |

pgAdmin 4 commit: Moved the webcabin-docker in the 'web/pgadmin/static/

2018-01-03 Thread Ashesh Vashi
Moved the webcabin-docker in the 'web/pgadmin/static/vendor' directory to resolve a possible issue, when we created webpack reference for vendor. webcabin-docker uses the jquery.1.11.1 as hard dependency, and latest jquery for 1.11.2 is available as npm, and which is used by us. Webpack referenc

pgAdmin 4 commit: Fix a number of cases where strings were not properly

2018-01-03 Thread Ashesh Vashi
Fix a number of cases where strings were not properly marked for translation. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c913f02e5ef312da008cf387cfc342a52aa0af0d Author: Alexander Lakhin Modified Files -- web/pgadmin/

pgAdmin 4 commit: Use the correct lexer in the Apache/Windows docs.

2018-01-03 Thread Ashesh Vashi
Use the correct lexer in the Apache/Windows docs. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08d7e44adbe0221758840dce1ec3c9e9e0ecffac Author: Dave Page Modified Files -- docs/en_US/server_deployment.rst | 9 -

pgAdmin 4 commit: Add the ability to build a basic Docker container.

2018-01-03 Thread Ashesh Vashi
Add the ability to build a basic Docker container. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d1cc245e19740d7fa59ef041810419068932d39 Author: Dave Page Modified Files -- pkg/docker/Dockerfile| 1 - pkg/docker/ent

pgAdmin 4 commit: Avoid a potential crash when downloading. Fixes #2964

2018-01-03 Thread Ashesh Vashi
Avoid a potential crash when downloading. Fixes #2964 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5813fd438eb330fc86b88e426c7de61fe1379ae Author: Neel Patel Modified Files -- runtime/BrowserWindow.cpp | 4 ++-- 1 file

pgAdmin 4 commit: Runtime version update

2018-01-03 Thread Ashesh Vashi
Runtime version update Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de0244a63d0053162ba582480fbb3d92ead53b69 Author: Dave Page Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- 2 files changed,

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2018-01-03 Thread Ashesh Vashi
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80835e410de6bc5361ac0ed00f38f87137c269a4 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Re-hash the way that we handle rendering of special t

2018-01-03 Thread Ashesh Vashi
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=444589a58dbb98a58a69a6399cbbf7d38aedb497 Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Misc fixes for the pgAgent module:

2018-01-03 Thread Ashesh Vashi
Misc fixes for the pgAgent module: 1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921 2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749 3) Fixed UI issue where validation error was not displaying properly for

pgAdmin 4 commit: Clarify how virtual envs can be used in WSGI mode, an

2018-01-03 Thread Ashesh Vashi
Clarify how virtual envs can be used in WSGI mode, and ensure we ship the required bits on Windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6f719a74ead76df23e974420a6a574334ba5310e Author: Surinder Kumar Modified Files --

pgAdmin 4 commit: Fixing the on the javascript files - 'web/pgadmin/sta

2018-01-03 Thread Ashesh Vashi
Fixing the on the javascript files - 'web/pgadmin/static/js/*.js' for the errors reported by the eslint. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b45fecf09d0c3988894150ede2bcb48503ef06d5 Modified Files -- web/pgadmin

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2018-01-03 Thread Ashesh Vashi
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da31616a19e40f697c040548bb31c52c38ef842a Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Fix duplicate link text

2018-01-03 Thread Ashesh Vashi
Fix duplicate link text Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f31695d51bf429f7b3d739b9c961c737ed6fe292 Author: Dave Page Modified Files -- docs/en_US/server_dialog.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-03 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a53548dd845077a25934363d9dd11a30d363770a Author: Harshal Dhumal Mod

pgAdmin 4 commit: Doc updates for server connection dialogue and relate

2018-01-03 Thread Ashesh Vashi
Doc updates for server connection dialogue and related info. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81d389fb0aaf99977cf5db3262d494319a2b5334 Author: Susan Douglas Modified Files -- docs/en_US/images/server_advance

pgAdmin 4 commit: Allow selection of validation error text. Fixes #2954

2018-01-03 Thread Ashesh Vashi
Allow selection of validation error text. Fixes #2954 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c125a4d2d17f9b0a3c7f5e762ac30036c1710f3 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alert.scss

pgAdmin 4 commit: Ensure column collation isn't lost when changing fiel

2018-01-03 Thread Ashesh Vashi
Ensure column collation isn't lost when changing field size. Fixes #2779 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3de5e224767085d293d6ccc4429f909bac45e48 Author: Khushboo Vashi Modified Files -- .../schemas/tables/

pgAdmin 4 commit: Fix label inconsistency spotted by Susan.

2018-01-03 Thread Ashesh Vashi
Fix label inconsistency spotted by Susan. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=725c6bdcf4d3530fba66c07733391a954acec3c9 Author: Dave Page Modified Files -- web/pgadmin/browser/server_groups/servers/static/js/ser

pgAdmin 4 commit: Make the query tool datatype test easily configurable

2018-01-03 Thread Ashesh Vashi
Make the query tool datatype test easily configurable and extendable and add support for multi-dimensional arrays and enums. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52c7945d4847ac835f3f3a04854e6b221767c4cd Author: Harshal Dhuma

pgAdmin 4 commit: Don't try to render security URLs in desktop mode. Fi

2018-01-03 Thread Ashesh Vashi
Don't try to render security URLs in desktop mode. Fixes #2952. Fixes #2922 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=032795c0e35b52140e9cca5db36e7c6912519ca6 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/_

pgAdmin 4 commit: Prevent attempts to select directories as files in th

2018-01-03 Thread Ashesh Vashi
Prevent attempts to select directories as files in the file dialogue. Fixes #2937 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f35a2b5f44d6a2fe53081b5eede80a1c275afbfa Author: Murtuza Zabuawala Modified Files -- web/pg

pgAdmin 4 commit: Add tab indexes for debugger controls.

2018-01-03 Thread Ashesh Vashi
Add tab indexes for debugger controls. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5e783c023bacad4a01e8401cdbe61efa544c59ef Author: Murtuza Zabuawala Modified Files -- .../tools/debugger/static/js/debugger_ui.js

pgAdmin 4 commit: Allow files to be opened by double clicking on them.

2018-01-03 Thread Ashesh Vashi
Allow files to be opened by double clicking on them. Fixes #2810 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ff0f521976019b87a6b370628b1243c604ce0c8 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/file_ma

pgAdmin 4 commit: Ensure password changes are successful if authenticat

2018-01-03 Thread Ashesh Vashi
Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14f0f9b5cccd185191cd014058f1a47de8c34f29 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Preferences dialogue help update.

2018-01-03 Thread Ashesh Vashi
Preferences dialogue help update. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f909e0651f6e7d4be4db0d916e92e8b51f7dd0c Author: Susan Douglas Modified Files -- docs/en_US/images/preferences_browser_display.png | Bin 54