Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2017-12-19 Thread Murtuza Zabuawala
On Wed, Dec 20, 2017 at 12:17 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala enterpris

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2017-12-19 Thread Harshal Dhumal
-- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Dec 19, 2017 at 7:47 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > On Tue, Dec 19, 2017 at 7:24 PM, Dave Page wrote: > >> Hi >> >> In

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2017-12-19 Thread Shirley Wang
What are thoughts on switching the colors between currently running and idle? I think if the session is currently running, and its still open during the session time limit, it should be green. Perhaps idle sessions should be yellow or grey to indicate that the window should be (and can be) closed w

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2017-12-19 Thread Dave Page
Hi On Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala wrote: > > > On Tue, Dec 19, 2017 at 7:24 PM, Dave Page wrote: > >> Hi >> >> Interesting. A few thoughts: >> >> - The pulsating icon is very off-putting. I think we need to make it only >> flash a couple of times when we actually need to att

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2017-12-19 Thread Murtuza Zabuawala
On Tue, Dec 19, 2017 at 7:24 PM, Dave Page wrote: > Hi > > Interesting. A few thoughts: > > - The pulsating icon is very off-putting. I think we need to make it only > flash a couple of times when we actually need to attract the attention of > the user. > ​As per my discussion with Chethana, In h

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2017-12-19 Thread Dave Page
Hi Interesting. A few thoughts: - The pulsating icon is very off-putting. I think we need to make it only flash a couple of times when we actually need to attract the attention of the user. - We shouldn't really use tooltips like this, as it may confuse folks with screen readers. Should we make

Re: [pgAdmin4][Patch]: RM #2964 - [Desktop Runtime] pgAdmin4 crash if user download query as CVS

2017-12-19 Thread Dave Page
Thanks, applied. On Tue, Dec 19, 2017 at 6:51 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #2964: [Desktop Runtime] > pgAdmin4 crash if user download query as CVS. > > Patch by Neel Patel. > > Thanks, > Khushboo > > > > --

pgAdmin 4 commit: Avoid a potential crash when downloading. Fixes #2964

2017-12-19 Thread Dave Page
Avoid a potential crash when downloading. Fixes #2964 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90f5af890253a3170dfd1f08f639d171e0e7a871 Author: Neel Patel Modified Files -- runtime/BrowserWindow.cpp | 4 ++-- 1 file changed,