Re: pgAdmin 4 - Update for Server dialog

Hi susan, I am getting an error while applying the patch, attached the screen-shot for the same. Thanks, Khushboo On Wed, Dec 13, 2017 at 11:20 PM, Susan Douglas < susan.doug...@enterprisedb.com> wrote: > > Hi All, > > I've attached a patch that (hopefully) updates the documented behaviors of

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

Hi, On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add basic Tab key navigation in debugger window, where user > will be able to navigate buttons using Tab key. > RM#2897 > > TODO:// Need to work on Debugger window Panel navi

Re: [pgAdmin4][Patch]: To fix query tool editor keyboard shortcut

Thanks, patch applied. On Tue, Dec 12, 2017 at 7:38 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where pressing Ctrl + Alt + . on query tool > editor window triggers Inline uncomment code functionality which is wrong > it should only trig

pgAdmin 4 commit: Don't un-comment code with alt+. in the query tool. I

Don't un-comment code with alt+. in the query tool. It's only supposed to respond to ctrl/cmd+. Fixes #2769 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=937984f2dc6e62480312663e7776830700a8527d Author: Murtuza Zabuawala Modified Files ---

Re: pgAdmin 4 - Update for Preferences dialog

Thanks, patch applied. On Mon, Dec 11, 2017 at 5:39 PM, Susan Douglas < susan.doug...@enterprisedb.com> wrote: > Hi All, > > I've attached a patch that (hopefully) updates the documented behaviors of > the Preferences dialog. If you could look it over, and apply it, I'd > appreciate it! > > As a

pgAdmin 4 commit: Preferences dialogue help update.

Preferences dialogue help update. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d02a0de8c9eba597c7289a7a3c03b7dba8df433f Author: Susan Douglas Modified Files -- docs/en_US/images/preferences_browser_display.png | Bin 54470 -> 5

Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

Thanks, patch applied. On Mon, Dec 11, 2017 at 12:46 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > On Mon, Dec 11, 2017 at 6:03 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Dec 11, 2017 at 5:45 PM, Khushboo Vashi < >> khushboo.va...@enterpri

pgAdmin 4 commit: Ensure column collation isn't lost when changing fiel

Ensure column collation isn't lost when changing field size. Fixes #2779 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=107795db1097367b5090e30869046377106c9eef Author: Khushboo Vashi Modified Files -- .../schemas/tables/column/s

Re: [pgAdmin4][Patch]: File manager - Fix logic to enable 'Select' button in List/Table view

Thanks, patch applied. On Mon, Dec 11, 2017 at 11:39 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where double clicking on folder enables the > 'Select' button in List/Table view. > RM#2937 > > -- > Regards, > Murtuza Zabuawala > Enterpri

pgAdmin 4 commit: Prevent attempts to select directories as files in th

Prevent attempts to select directories as files in the file dialogue. Fixes #2937 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96a2987ef6de8f1bfed920696f96511001984368 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/mi

pgAdmin 4 commit: Ensure the datatype cache is updated when a domain is

Ensure the datatype cache is updated when a domain is added. Fixes #2778 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5d1fc81898fad57c9a67b607f85255d5622ba7b Author: Murtuza Zabuawala Modified Files -- .../servers/databases/sc

Re: [pgAdmin4][Patch]: Newly created domain not listed in Data type

Thanks, applied. On Mon, Dec 11, 2017 at 9:37 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where newly created domains are not listed > under Data type combo box in 'Create Table' dialog. > RM#2778 > > Also fixed typo in FTS Configuration

Re: [INSTALLERS] pgAdmin 4: Add-on support

The code is broken right now - see https://redmine.postgresql.org/issues/2952. Once it's fixed, I can do this, assuming I can find the spare time. On Thu, Dec 7, 2017 at 4:05 PM, Ashesh Vashi wrote: > Hi Dave, > > I've merged the master branch in the 'WEBPACK_DEVEL2' branch. > > In this branch,

pgAdmin 4 commit: Fix label inconsistency spotted by Susan.

Fix label inconsistency spotted by Susan. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2e844c0adc9bcc8421d548bd7cbde9c5e7d0491 Modified Files -- web/pgadmin/browser/server_groups/servers/static/js/server.js | 4 ++-- 1 file chan

Re: [pgAdmin4][Patch]: Change password doesn't work if pgpass file is used

Thanks, patch applied. On Fri, Dec 8, 2017 at 5:51 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where changing a database server password > functionlity was not working if user has made connection using pgpass file. > Also ViewData/Query

pgAdmin 4 commit: Ensure password changes are successful if authenticat

Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4246a3b22f292179ef85833b0cbee85accd32c65 Author: Murtuza Zabuawala Modified Files -- .../br

pgAdmin 4 commit: Re-hash the way that we handle rendering of special t

Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55254a649f8864e246afe9442aef2d882a4479cb Author: Harshal Dhumal Modified Files --

Re: [pgAdmin4][RM2782][RM2822] fix array representation in query tool and data grid

Thanks, patch applied. On Thu, Dec 7, 2017 at 3:02 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Attached patch fixes array representation issue as well as > multidimensional array representation issue. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

Awesome job - thanks, patch applied. On Wed, Dec 6, 2017 at 9:27 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please find the attached updated patch with some code cleanup. > > > On Wed, Dec 6, 2017 at 2:34 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi D

pgAdmin 4 commit: Add support for editing data in tables with OIDs but

Add support for editing data in tables with OIDs but no primary keys. Fixes #2849. This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh. Branch -- master Details --- https://git