Re: Fixes for pgAdmin4 messages

Hello, 04.11.2017 07:05, Ashesh Vashi wrote: Looks like - the patch has introduced syntax error in database.js. On Nov 3, 2017 22:19, "Dave Page" > wrote: Hi Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see th

Re: Fixes for pgAdmin4 messages

Looks like - the patch has introduced syntax error in database.js. On Nov 3, 2017 22:19, "Dave Page" wrote: > Hi > > Unfortunately I've had to revert this. It was causing the treeview to > render incorrectly (see the attached screenshot). > > Can you take a look please? I've CC'd Ashesh as he kn

Re: [pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data

Ashesh, can you review/commit please? Please remember to test sized vs. unsized columns, as well as "char" and char etc. Thanks! On Fri, Nov 3, 2017 at 10:12 AM, Akshay Joshi wrote: > Hi All > > Attached is the patch file to fix RM #2830 "Corrupts type CHAR(4) data". > During that I found one m

Re: [pgAdmin4][Patch]: Fixed RM 2844 Tree View Icons

Akshay, can you review/commit this please? On Fri, Nov 3, 2017 at 1:07 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hello Team, > > I am sharing you some updates in response to the feedback received from > the customers side for the "tree view icons". > > *Issue Raised* - > - Us

Build failed in Jenkins: pgadmin4-master-python26 #496

See Changes: [Dave Page] Revert "Fix a number of cases where strings were not properly marked for -- [...truncated 346.11 KB...] PackagePutTestCa

Re: Fixes for pgAdmin4 messages

Hi Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot). Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling f

pgAdmin 4 commit: Revert "Fix a number of cases where strings were not

Revert "Fix a number of cases where strings were not properly marked for translation." This reverts commit 1f23838a4c2c4919499bb07f41efab7202843016 due to unintended side effects it caused - specifically, expanding Databases on the treeview displayed Servers again Branch -- master Details

Re: Fixes for pgAdmin4 messages

Thanks, patch applied. On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin wrote: > Hello, > I have another patch for the better localization of pgAdmin4. > Please consider applying it. > > Best regards, > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian

pgAdmin 4 commit: Fix a number of cases where strings were not properly

Fix a number of cases where strings were not properly marked for translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f23838a4c2c4919499bb07f41efab7202843016 Author: Alexander Lakhin Modified Files -- .../foreign_servers/

Re: Fixes for pgAdmin4 messages

Hello, I have another patch for the better localization of pgAdmin4. Please consider applying it. Best regards, -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/foreign_data_wrap

[pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data

Hi All Attached is the patch file to fix RM #2830 "Corrupts type CHAR(4) data". During that I found one more issue where message "Data saved successfully." popped up even if there is an error while saving the data. I have fixed that too. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +9