Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:59 PM, Rob Emery wrote: > Awesome thanks. > > What's the release schedule like for pgagent? > I have no idea. That can be answered by Dave only. Dave? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: pgadmin4 l10n issues

2017-10-24 Thread Alexander Lakhin
24.10.2017 18:11, Ashesh Vashi wrote: Looks like - I missed to logout, and test. Please find the updated patch. Now the error is gone but I get no right locale. The issue is with Desktop mode (see "if config.SERVER_MODE is False:" in web/pgadmin/__init__.py). -- Thanks, Ashesh Best

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Rob Emery
Awesome thanks. What's the release schedule like for pgagent? Thanks, Rob On 24 October 2017 at 16:05, Ashesh Vashi wrote: > On Tue, Oct 24, 2017 at 8:30 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, Oct 24, 2017 at 8:21 PM, Robert Emery < >> robertem...@codeweavers

Re: pgadmin4 l10n issues

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:35 PM, Alexander Lakhin wrote: > 24.10.2017 17:17, Ashesh Vashi wrote: > > On Tue, Oct 24, 2017 at 6:08 PM, Alexander Lakhin > wrote: > >> Hi Ashesh, >> >> 23.10.2017 08:21, Ashesh Vashi wrote: >> >> Hi Dave/Alexander, >> >> On Thu, Oct 19, 2017 at 6:43 PM, Dave Page w

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:30 PM, Ashesh Vashi wrote: > On Tue, Oct 24, 2017 at 8:21 PM, Robert Emery > wrote: > >> Hello again, >> >> I can't see any other way of solving this problem without either exposing >> a method on JobThread to delete the Job owned by the thread which is called >> by htt

Re: pgadmin4 l10n issues

2017-10-24 Thread Alexander Lakhin
24.10.2017 17:17, Ashesh Vashi wrote: On Tue, Oct 24, 2017 at 6:08 PM, Alexander Lakhin > wrote: Hi Ashesh, 23.10.2017 08:21, Ashesh Vashi wrote: Hi Dave/Alexander, On Thu, Oct 19, 2017 at 6:43 PM, Dave Page mailto:dp...@pgadmin.org>> wrote:

pgAgent commit: When multiple instances of pgAgent are running on the s

2017-10-24 Thread Ashesh Vashi
When multiple instances of pgAgent are running on the same schema, only one of the instance can pick up the job to run. Hence - rest of the instances will never run the job. Hence - the job-thread does not release the job object. And, end up leaking the memory. Releasing the job object from the d

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 8:21 PM, Robert Emery wrote: > Hello again, > > I can't see any other way of solving this problem without either exposing > a method on JobThread to delete the Job owned by the thread which is called > by https://github.com/postgres/pgagent/blob/master/pgAgent.cpp#L139 or

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-24 Thread Rob Emery
Hello again, I can't see any other way of solving this problem without either exposing a method on JobThread to delete the Job owned by the thread which is called by https://github.com/postgres/pgagent/blob/master/pgAgent.cpp#L139 or another method that only gives up the connection which is called

Build failed in Jenkins: pgadmin4-master-python27 #360

2017-10-24 Thread pgAdmin 4 Jenkins
See -- [...truncated 341.71 KB...] PackagePutTestCase (Fetch Package Node URL) TableAddTestCase (Create Range partitioned table with 2 partition

Re: pgadmin4 l10n issues

2017-10-24 Thread Ashesh Vashi
On Tue, Oct 24, 2017 at 6:08 PM, Alexander Lakhin wrote: > Hi Ashesh, > > 23.10.2017 08:21, Ashesh Vashi wrote: > > Hi Dave/Alexander, > > On Thu, Oct 19, 2017 at 6:43 PM, Dave Page wrote: > >> Akshay, can you review/commit this, and look into why the remaining >> strings Alexander notes are not

pgAdmin 4 commit: Return the translations, and not empty array from the

2017-10-24 Thread Ashesh Vashi
Return the translations, and not empty array from the 'translations.js'. It was regression of the commit-id: 4a91bcde303bd3d5d2bd2e2f20cd7046585eba06 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0a1cf30abb5549e72afb8914e901781b499ab00f Auth

pgAdmin 4 commit: Using 'categroy_id' instead of 'cid' in the preferenc

2017-10-24 Thread Ashesh Vashi
Using 'categroy_id' instead of 'cid' in the preferences Backbone.Model, as it is used by the Backbone.Collection to get the object by id. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c53c6d2f485932845d7f345ac0334cf61640c297 Modified Files -

Re: pgadmin4 l10n issues

2017-10-24 Thread Alexander Lakhin
Hi Ashesh, 23.10.2017 08:21, Ashesh Vashi wrote: Hi Dave/Alexander, On Thu, Oct 19, 2017 at 6:43 PM, Dave Page > wrote: Akshay, can you review/commit this, and look into why the remaining strings Alexander notes are not getting translated please? Did you f

Jenkins build is back to normal : pgadmin4-master-python35 #358

2017-10-24 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python27 #358

2017-10-24 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python36 #357

2017-10-24 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python34 #348

2017-10-24 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python33 #357

2017-10-24 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python26 #484

2017-10-24 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Allow to send error, and warning on console from the

2017-10-24 Thread Ashesh Vashi
Allow to send error, and warning on console from the javascript modules. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8adf005ef8e7b181e303221bc36dc2206e69e8b5 Modified Files -- web/.eslintrc.js | 5 +++-- 1 file changed, 3 insert