Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Rob Emery
Hiya, I've just confirmed neither of these patches resolve the issue, it appears in the error case I'm experiencing the JobThread::Entry() never executes. To clarify I'm talking about the path entering the else in pgAgent.cpp:125 which will save into pga_joblog with jlgstatus = "i" This path exp

Re: pgadmin4 l10n issues

2017-10-23 Thread Dave Page
Should be upthread I believe - archives.postgresql.org if you cannot find it? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 23 Oct 2017, at 07:21, Ashesh Vashi wrote: > > Hi Dave/Alexander, >

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Rob Emery
Hiya, Actually, on reflection (I've not tested yet) but I don't think that'll actually work. Looking at pgAgent.cpp:119, Create and Run are only executed if it's Runnable. I've never used WXWidgets before so I'm not sure but I would guess that Create and Run execute the Entry() method on the new t

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Rob Emery
Hiya, That seems absolutely fine. I've tested the patch I had over the weekend, the problem is pretty easy to reproduce with a job that runs every minute and 4 instances of pgagent. I'll give this version a test as well, but I'm confident it should be fine. Thanks, Rob On 23 October 2017 at 06:

Re: [pgAgent][Patch] Fixing connection pool leak

2017-10-23 Thread Neel Patel
Hi Ashesh, I just added condition before delete the job otherwise it looks good. Correct me if I am wrong. if (job != NULL) { delete job; job = NULL; } I have created two instances of pgagent on database cluster. As of now not able to see any leak and keep you updated if found anything.