Build failed in Jenkins: pgadmin4-master-python36 #356

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix check constraint regression tests. [Dave Page] Update yarn lock file. [Dave Page] Show how the config/storage directory can be mounted on the host under -

Build failed in Jenkins: pgadmin4-master-python26 #483

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 [Dave Page] Fix name of 'check-constraints' to follow the usual singular convention. [Dave Page] Fix ch

Build failed in Jenkins: pgadmin4-master-python33 #356

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix name of 'check-constraints' to follow the usual singular convention. [Dave Page] Fix check constraint regression tests. [Dave Page] Update yarn lock file. [Dave Page] Sho

Build failed in Jenkins: pgadmin4-master-python35 #357

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix check constraint regression tests. [Dave Page] Update yarn lock file. [Dave Page] Show how the config/storage directory can be mounted on the host under -

Build failed in Jenkins: pgadmin4-master-python27 #357

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Show how the config/storage directory can be mounted on the host under -- [...truncated 157.09 KB...] runTest (pgadmin.browser.server_g

pgAdmin 4 commit: Show how the config/storage directory can be mounted

2017-10-16 Thread Dave Page
Show how the config/storage directory can be mounted on the host under docker. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2c4fb02bc7a53710db733575a1bc47b9292740d Modified Files -- pkg/docker/README | 3 ++- 1 file changed, 2 i

Build failed in Jenkins: pgadmin4-master-python35 #356

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 [Dave Page] Fix name of 'check-constraints' to follow the usual singular convention. --

pgAdmin 4 commit: Update yarn lock file.

2017-10-16 Thread Dave Page
Update yarn lock file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9f10ddad12cc3aef68077fa6fdad69199ae10cf Modified Files -- web/yarn.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: Fix check constraint regression tests.

2017-10-16 Thread Dave Page
Fix check constraint regression tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=890fece73a0f261bde566ace2828b6e7d9a46ff5 Modified Files -- .../constraints/check_constraint/tests/test_check_constraint_add.py | 2 +- .../co

Build failed in Jenkins: pgadmin4-master-python34 #346

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 [Dave Page] Fix name of 'check-constraints' to follow the usual singular convention. --

Build failed in Jenkins: pgadmin4-master-python36 #355

2017-10-16 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 [Dave Page] Fix name of 'check-constraints' to follow the usual singular convention. --

pgAdmin 4 commit: Fix name of 'check-constraints' to follow the usual s

2017-10-16 Thread Dave Page
Fix name of 'check-constraints' to follow the usual singular convention. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=784f3f59d8e3dc7a81d935affb21ec6db0900f8c Author: Murtuza Zabuawala Modified Files -- .../constraints/check_co

Re: [pgAdmin4][Patch]: Fix naming convention for Check constraint.

2017-10-16 Thread Dave Page
Thanks, applied. On Mon, Oct 16, 2017 at 3:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to correct the naming convention for Check constraint module. > (only plural to singular, no change in any functionality) > > Please review. > > -- > Regards, > Mur

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Thanks - applied with a minor tweak to the help message. On Mon, Oct 16, 2017 at 1:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Oct 16, 2017 at 5:56 PM, Dave Page wrote: > >> Hi >> >> On Mon, Oct 16, 2017 at 1:21 PM,

pgAdmin 4 commit: Ensure auto-indent honours the spaces/tabs config set

2017-10-16 Thread Dave Page
Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0cb57848f87e036d086ab59aafd1f363483a4723 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/__init

[pgAdmin4][Patch]: Fix naming convention for Check constraint.

2017-10-16 Thread Murtuza Zabuawala
Hi, PFA patch to correct the naming convention for Check constraint module. (only plural to singular, no change in any functionality) Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. On Mon, Oct 16, 2017 at 5:56 PM, Dave Page wrote: > Hi > > On Mon, Oct 16, 2017 at 1:21 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Sorry, that was a typo in 'sqleditor/__init__.py'. >> >> I have updated the patch, We require thi

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Hi On Mon, Oct 16, 2017 at 1:21 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Sorry, that was a typo in 'sqleditor/__init__.py'. > > I have updated the patch, We require this option because by default > codemirror indent the code with spaces. > > Steps to re-produce (withou

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Murtuza Zabuawala
Sorry, that was a typo in 'sqleditor/__init__.py'. I have updated the patch, We require this option because by default codemirror indent the code with spaces. Steps to re-produce (without patch): 1) With preference option Use spaces? = False Tab size = 4 2) Open query tool - Press Tabs key 3

Re: [pgAdmin4][Patch]: To fix Indentation issue in query tool

2017-10-16 Thread Dave Page
Hi On Mon, Oct 16, 2017 at 5:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where indentation is not working as expected, > when user opt for tab based indentation instead of space based indentation. > RM#2780 > Shouldn't we just use th

pgAdmin 4 commit: Use HTTPS for accessing help docs.

2017-10-16 Thread Dave Page
Use HTTPS for accessing help docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce5f5015b3f0855cbf45f252593583a200bda047 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/help/__init__.py | 4 ++-- 1 file changed, 2 insert

Re: [pgAdmin4][Patch]: Use https:// to open postgres online help documents

2017-10-16 Thread Dave Page
Thanks, applied. On Fri, Oct 13, 2017 at 6:28 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to use the https:// instead of http:// to open online > help documents. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > Th