Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-17 Thread Akshay Joshi
Thanks patch applied. On Fri, Sep 15, 2017 at 6:16 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > It's not issue; Try without quotes. As char data type stores only one > character so it's storing only leading quote (') and > truncating remaining characters (a'). > O

pgAdmin 4 commit: Changed array representation and formatting for the d

2017-09-17 Thread Akshay Joshi
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30e701607713edc1ba43173556c911c98fc09eb5 Author: Harshal Dhumal Modified Files --

Re: [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

2017-09-17 Thread Harshal Dhumal
I think this is similar issue.. https://redmine.postgresql.org/issues/2134 On Mon, Sep 18, 2017 at 11:16 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While configuring pgAdmin4 with Apache mod_wsgi, it fails to run apache > server due to python error. > > [mod_wsgi (pid=1

pgAdmin 4 commit: Fixed the jasmine tests regression due to changes in

2017-09-17 Thread Ashesh Vashi
Fixed the jasmine tests regression due to changes in the webpacking implementation. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0eb01384aaeeedc63edfbfc2e897684c914d58e0 Modified Files -- web/karma.conf.js

pgAdmin 4 commit: Add capability to print the javascript console errors

2017-09-17 Thread Ashesh Vashi
Add capability to print the javascript console errors, and warnings on stderr (standard error) for the feature tests. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c259043df8007866ba1aa5f1a6b053d2809c38d Modified Files --

pgAdmin 4 commit: Updating the packing, and ci test scripts as per chan

2017-09-17 Thread Ashesh Vashi
Updating the packing, and ci test scripts as per changes in the webpack implementation. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ce6b5e87113d8418e74cacadff910bcd8758782 Modified Files -- Make-MinGW.bat | 2

[pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set

2017-09-17 Thread Surinder Kumar
Hi While configuring pgAdmin4 with Apache mod_wsgi, it fails to run apache server due to python error. [mod_wsgi (pid=12596): Target WSGI script '/opt/pgadmin4_2/virtualenv/lib/python2.7/site-packages/pgadmin4/pgAdmin4.wsgi' cannot be loaded as Python module. mod_wsgi (pid=12596): Exception occur

[pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5

2017-09-17 Thread Surinder Kumar
Hi While looking into a React bug, I tried running pgAdmin4 code with Reactv15.5 or with Reactv16-RC-3, the code fails to run. Because React's PropTypes is no more part of React Module. Reference link . Pl

pgAdmin 4 commit: Do not run javascript bundler, when BUILD_JSMODULES i

2017-09-17 Thread Ashesh Vashi
Do not run javascript bundler, when BUILD_JSMODULES is set to False in the config file. In that case - we should run the webpack in wait mode in a separate console/terminal/command-prompt. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h

pgAdmin 4 commit: Expose the register_module_initializer, and register_

2017-09-17 Thread Ashesh Vashi
Expose the register_module_initializer, and register_module in the pgAdmin javascript module to allow to register any javascript modules as part of any javascript module entry, and initialize them. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=comm

pgAdmin 4 commit: Handle the executor nodes, which are unknown to the E

2017-09-17 Thread Ashesh Vashi
Handle the executor nodes, which are unknown to the Explain module, gracefully by showing the 'ex_unknown.png' for such nodes. Reported by: Murtuza Refs #2706 Branches WEBPACK_DEVEL master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55e14e4d78cac3822c

pgAdmin 4 commit: No longer using the 'get_own_javascripts' method for

2017-09-17 Thread Ashesh Vashi
No longer using the 'get_own_javascripts' method for refering the javascript modules exposed through a module, instead added them in the webpack (shim) configuration directly. Instead - exposed a new method - 'get_javascript_entries' to be used later by the new implementation of the webpack config

pgAdmin 4 commit: Moved the webcabin-docker in the 'web/pgadmin/static/

2017-09-17 Thread Ashesh Vashi
Moved the webcabin-docker in the 'web/pgadmin/static/vendor' directory to resolve a possible issue, when we created webpack reference for vendor. webcabin-docker uses the jquery.1.11.1 as hard dependency, and latest jquery for 1.11.2 is available as npm, and which is used by us. Webpack referenc

pgAdmin 4 commit: Extending the tools, and miscellaneous javascript mod

2017-09-17 Thread Ashesh Vashi
Extending the tools, and miscellaneous javascript modules from the browser tools. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a050a169cb4182aeb71567c6efe3d45d1b7ae7ef Modified Files -- web/pgadmin/misc/bgprocess/static/j

pgAdmin 4 commit: Enable webpackaging the pgadmin javascript files in d

2017-09-17 Thread Ashesh Vashi
Enable webpackaging the pgadmin javascript files in different small modules, which can be referred from other modules. We can have two types of webpack modules. 1. Reference (using the dll plugin of webpack) This type of webpack module can be referred from the other webpack modules. And, it

pgAdmin 4 commit: Moving the sqleditor specific javascript/jsx files in

2017-09-17 Thread Ashesh Vashi
Moving the sqleditor specific javascript/jsx files into the 'pgadmin/tools/sqleditor/static' directory. NOTE: This has broken the compilation with the current webpack implementation, which will be fixed in the upcoming commits. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.o