Re: [pgadmin-hackers] Autoformatting

2017-09-14 Thread Jing Li
Hi Murtuza, We had to put the autoformatting feature on hold for a while to focus on some greenplum work. We have a library in progress but we're not currently far enough along with this to submit a patch. Thanks,~Jing On Wed, Sep 13, 2017 1:13 AM, Murtuza Zabuawala murtuza.zabuaw...@enterp

pgAdmin 4 commit: Handle the executor nodes, which are unknown to the E

2017-09-14 Thread Ashesh Vashi
Handle the executor nodes, which are unknown to the Explain module, gracefully by showing the 'ex_unknown.png' for such nodes. Reported by: Murtuza Refs #2706 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55e14e4d78cac3822c9197ee7f740d63262d

pgAdmin 4 commit: Branch refs/heads/WEBPACK_DEVEL was created

2017-09-14 Thread git
Branch refs/heads/WEBPACK_DEVEL was created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=shortlog;h=refs/heads/WEBPACK_DEVEL

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Shirley Wang
Hi Harshal and Akshay, I'm noticing that the screenshots you attached have fonts that look different (ex. no font weights for table headers). Is that a result of the font bundling and needs to be updated? On Fri, Sep 15, 2017 at 12:18 AM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: >

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Harshal Dhumal
Thanks, I'll look into it. On Sep 14, 2017 5:31 PM, "Akshay Joshi" wrote: > Hi Harshal > > I have reviewed your patch it looks good to me. Only one issue I have > found with char[], when I store {'a','b','c'} it gets stored and when I > refreshed it shows {',','}. Please look into this issue. >

Re: pgAdmin 4 v2.0-rc1 builds

2017-09-14 Thread Fahar Abbas
Hi Dave! I have finished one Round of testing on this RC1 Build. 1400+ test cases executed during functional verification and track all test cases through our local test suit. New RM reported for *pgAdmin4* *2.0-RC1* Build: https:

[pgAdmin4][Patch]: pgAdmin4 not displaying schema if it start with 'pg'

2017-09-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where pgAdmin4 is not displaying the schema if it starts with 'pg', for example if schema name is 'pgabc' then it won't display it under browser tree. RM#2709 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Post

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-14 Thread Dave Page
Nope - it shouldn't look like that. Atul, Can you take a look at it please? On Thu, Sep 14, 2017 at 2:26 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > After latest pull fonts from context menu looks different, PFA screenshot. > I tried on macOS: 10.10 (Web mode

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-14 Thread Murtuza Zabuawala
Oops Sorry, after clearing the cache 2nd time, it is working fine now. On Thu, Sep 14, 2017 at 6:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > After latest pull fonts from context menu looks different, PFA screenshot. > I tried on macOS: 10.10 (Web mode) on

Re: v2.0-rc1 not starting, runtime not building

2017-09-14 Thread Willy-Bas Loos
On Thu, Sep 14, 2017 at 11:07 AM, Neel Patel wrote: > I don't know the installed packages on your system but what I can help > only - Download Qt 5.5 installers from "https://download.qt.io/archive/qt/"; > and install it on custom path ( e.g. /opt/Qt5.5" and use "qmake" installed > in that direct

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Akshay Joshi
It works, sorry for the noise. On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi wrote: > Harshal, > > Can you please rebase the patch, it's not applied with the latest code. > > On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Tue, Sep 12, 2017 a

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-14 Thread Akshay Joshi
Harshal, Can you please rebase the patch, it's not applied with the latest code. On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi wrote: > > > On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: > >> Adding Akshay... >> > > Sure. > >> >> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: >> >>

Re: v2.0-rc1 not starting, runtime not building

2017-09-14 Thread Neel Patel
Hi, I don't know the installed packages on your system but what I can help only - Download Qt 5.5 installers from "https://download.qt.io/archive/qt/"; and install it on custom path ( e.g. /opt/Qt5.5" and use "qmake" installed in that directory during compilation and let us know result. Thanks, N