Re: Fonts for pgAdmin

2017-09-13 Thread Shirley Wang
Thanks! On Wed, Sep 13, 2017 at 11:23 PM Dave Page wrote: > Thanks, applied. > > On Wed, Sep 13, 2017 at 2:21 PM, Atul Sharma > wrote: > >> Hi, >> >> PFA patch which add new fonts to pgAdmin. >> >> Regards, >> Atul >> >> On Tue, Sep 12, 2017 at 10:26 PM, Surinder Kumar < >> surinder.ku...@enter

Re: Fonts for pgAdmin

2017-09-13 Thread Dave Page
Thanks, applied. On Wed, Sep 13, 2017 at 2:21 PM, Atul Sharma wrote: > Hi, > > PFA patch which add new fonts to pgAdmin. > > Regards, > Atul > > On Tue, Sep 12, 2017 at 10:26 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Sure. I will send a patch. >> >> On Tue, Sep 12, 2017

pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-13 Thread Dave Page
Bundle fonts with pgAdmin so we have a standard set for all platforms. Research by Shirley at Pivotal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8 Author: Atul Sharma Modified Files --

pgAdmin 4 commit: Always pack React in prod mode to avoid a bug in debu

2017-09-13 Thread Dave Page
Always pack React in prod mode to avoid a bug in debug mode that prevents the history tab working. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e819465e386aabeeced8b530c85634dd2d2d0ec9 Author: Surinder Kumar Modified Files --

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Dave Page
Thanks, applied. On Wed, Sep 13, 2017 at 1:26 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > If we set 'NODE_ENV' to 'production' variable in definePlugin, the React > will always build in production mode. > > Please find an attached patch. > > Thanks, > Surinder > >

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Surinder Kumar
Hi Dave, If we set 'NODE_ENV' to 'production' variable in definePlugin, the React will always build in production mode. Please find an attached patch. Thanks, Surinder On Wed, Sep 13, 2017 at 4:36 PM, Dave Page wrote: > > > On Wed, Sep 13, 2017 at 10:34 AM, Surinder Kumar < > surinder.ku...

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Dave Page
On Wed, Sep 13, 2017 at 10:34 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Wed, Sep 13, 2017 at 2:52 PM, Dave Page wrote: > >> >> >> On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> >>> ​ >>> On Wed, Sep 13, 2017 at 2:18 PM,

pgAdmin 4 commit: Update cast icons with improved design.

2017-09-13 Thread Dave Page
Update cast icons with improved design. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ff79dfc1861a7ffca803638afa8608736f3b2c96 Author: Chethana Kumar Modified Files -- .../browser/server_groups/servers/databases/casts/static/img

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Surinder Kumar
On Wed, Sep 13, 2017 at 2:52 PM, Dave Page wrote: > > > On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> >> ​ >> On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote: >> >>> Thanks, committed - though I did add a bundle-dev target to the Makefile >>>

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Dave Page
On Wed, Sep 13, 2017 at 10:06 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > ​ > On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote: > >> Thanks, committed - though I did add a bundle-dev target to the Makefile >> for convenience. >> >> I'm a little concerned though that the query

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Surinder Kumar
​ On Wed, Sep 13, 2017 at 2:18 PM, Dave Page wrote: > Thanks, committed - though I did add a bundle-dev target to the Makefile > for convenience. > > I'm a little concerned though that the query history still doesn't work in > dev mode. Is that fixable? > ​That's an issue with ReactJS and I had l

pgAdmin 4 commit: Update server and database icons with a clearer desig

2017-09-13 Thread Dave Page
Update server and database icons with a clearer design. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3779c36d0f61415ffeec7118b0fe1fd92e901703 Author: Chethana Kumar Modified Files -- .../server_groups/servers/databases/static/i

Re: [pgAdmin4][Patch]: Fix regression issues

2017-09-13 Thread Dave Page
Thanks, applied. On Tue, Sep 12, 2017 at 2:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patches, > > 1) > To fix the issue where base types are displaying in create/edit dialog, > also corrected the condition to show hidden system types. > RM#2692 > > This i

pgAdmin 4 commit: Fix an issue in User mapping module where users were

2017-09-13 Thread Dave Page
Fix an issue in User mapping module where users were not listed. Fixes #2693 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80ce889c3d0ad09f9383ede6972bb4c328b2b1e8 Author: Murtuza Zabuawala Modified Files -- .../foreign_servers/

pgAdmin 4 commit: Fix an issue where base types are not displaying in t

2017-09-13 Thread Dave Page
Fix an issue where base types are not displaying in the create/edit domain dialog, also corrected the condition to show hidden system types. Fixes #2692 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5891bda06a21586fbdc9731ad0b0f9644a5dc8d5 A

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-13 Thread Dave Page
Thanks, committed - though I did add a bundle-dev target to the Makefile for convenience. I'm a little concerned though that the query history still doesn't work in dev mode. Is that fixable? On Tue, Sep 12, 2017 at 11:57 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, >

pgAdmin 4 commit: Run webpack in production mode when building for rele

2017-09-13 Thread Dave Page
Run webpack in production mode when building for releases. Fixes #2660 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=120dbcc7d89544e9519b48af975bf67ab7d93670 Author: Surinder Kumar Modified Files -- Makefile | 3 +++