Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

Hi As per the review comment given by Ashesh: 1) The test cases with target `check:` must run in `prod` mode by default. 2) Add another target `check-dev:` to run test cases in `dev` mode. So, the patch is updated with fixed review comments. Please find an updated patch and review. Thanks, Su

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

Hi Dave, I have added a new target to run build in 'dev' mode. By default, it will run in production mode. By dev mode it means, run `yarn run bundle:dev` and by prod mode, run `yarn run bundle:prod`. In Mac bundle, added new target `make appbundle-dev` to generate build with command `yarn run b

Re: pgAdmin 4 v2.0-rc1 builds

Hi Dave, I have completed Sanity verification of pgAdmin4 with PG-10 server on RC1 Build and detail testing is in progress: RM reported for pgAdmin4: - https://redmine.postgresql.org/issues/2691 https://redmine.postgresql.org/issues/2692 https://redmine.postg

Re: pgAdmin 4 v2.0-rc1 builds

That's fine then. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 11 Sep 2017, at 15:49, Fahar Abbas wrote: > > pgAdmin4 is working fine on MAC 10.10(testing is in progress) however on MAC > 1

Array representation and save array data from datagrid [RM2671][pgAdmin4]

Hi, Please find attached patch to represent array data in datagrid with curly braces and also allow user to save array with values like , , ' *""*' and "*''*" -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --gi

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

Code looks good to me. Thanks patch applied. On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi wrote: > > > On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> > > Sure Dave. > >> >> Thanks. >> >> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wro

pgAdmin 4 commit: Highlighting greenplum keywords in sql editor

Highlighting greenplum keywords in sql editor Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=512afd66182f463e6ce9515910205dcf0221e58c Author: Teng Zhang Modified Files -- web/package.json |

Re: pgAdmin 4 v2.0-rc1 builds

On Mon, Sep 11, 2017 at 2:49 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Mon, Sep 11, 2017 at 6:45 PM, Dave Page wrote: > >> >> >> On Mon, Sep 11, 2017 at 2:12 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> On Mon, Sep 11, 2017 at 6:07 PM,

Re: pgAdmin 4 v2.0-rc1 builds

On Mon, Sep 11, 2017 at 6:45 PM, Dave Page wrote: > > > On Mon, Sep 11, 2017 at 2:12 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> On Mon, Sep 11, 2017 at 6:07 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar < >>> surinder.ku...@

Jenkins build is back to normal : pgadmin4-master-python36 #316

See

Re: pgAdmin 4 v2.0-rc1 builds

Hi You say Mavericks and 10.10 in the same sentence, however, Mavericks is actually 10.9. What does it crash on exactly? We don't support Mavericks (10.9) so I don't really care about that. On Mon, Sep 11, 2017 at 1:49 PM, Fahar Abbas wrote: > Hi Dave, > > pgAdmin4 crash issue is still reproduc

Re: pgAdmin 4 v2.0-rc1 builds

On Mon, Sep 11, 2017 at 2:12 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On Mon, Sep 11, 2017 at 6:07 PM, Dave Page wrote: > >> >> >> On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Mon, Sep 11, 2017 at 5

Re: pgAdmin 4 v2.0-rc1 builds

Hi On Mon, Sep 11, 2017 at 6:07 PM, Dave Page wrote: > > > On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros >> wrote: >> >>> Howdy, >>> >>> Nice work! Don’t see any show-stoppers, but I’l

pgAdmin 4 commit: Using the svg icons for domain constraint, and server

Using the svg icons for domain constraint, and server browser nodes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f79b7f26b1faa9f6df63ee024b247f8b686c9438 Author: Chethana Kumar Modified Files -- .../static/img/domain_constrain

Re: pgAdmin 4 v2.0-rc1 builds

Hi Dave, pgAdmin4 crash issue is still reproducible on MAC OS X mavericks while doing verification on MAC 10.10+ https://redmine.postgresql.org/issues/2680 Kind Regards, On Mon, Sep 11, 2017 at 4:31 PM, Fahar Abbas wrote: > Thanks Dave, I will test the latest RC Build and will update the sta

Re: pgAdmin 4 v2.0-rc1 builds

On Mon, Sep 11, 2017 at 1:18 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros > wrote: > >> Howdy, >> >> Nice work! Don’t see any show-stoppers, but I’ll throw three comments at >> you all. >> >> 1. New tree icons look great.

Re: pgAdmin 4 v2.0-rc1 builds

Hi, On Mon, Sep 11, 2017 at 5:40 PM, Anthony DeBarros wrote: > Howdy, > > Nice work! Don’t see any show-stoppers, but I’ll throw three comments at > you all. > > 1. New tree icons look great. > 2. A few weeks back, there was a test release with a new font for the > query tool. Got used to it and

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote: > Akshay, can you review/commit this please? > Sure Dave. > > Thanks. > > On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wrote: > >> Hi Hackers, >> >> Attached is a patch that makes SQL editor show syntax highlighting with >> Greenplum keywor

Re: pgAdmin 4 v2.0-rc1 builds

Howdy, Nice work! Don’t see any show-stoppers, but I’ll throw three comments at you all. 1. New tree icons look great. 2. A few weeks back, there was a test release with a new font for the query tool. Got used to it and liked it a lot. Hope you consider using it in the future. 3. Still experienci

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

Akshay, can you review/commit this please? Thanks. On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang wrote: > Hi Hackers, > > Attached is a patch that makes SQL editor show syntax highlighting with > Greenplum keywords. > > - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" > - Us

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

On Mon, Sep 11, 2017 at 11:13 AM, Jing Li wrote: > Can we get this patch into the 2.0 release? > Shouldn't be a problem. It didn't make todays build though. > > > On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezh...@pivotal.io wrote: > >> Hi Hackers, >> >> Attached is a patch that makes SQL editor

Re: pgAdmin 4 v2.0-rc1 builds

Thanks Dave, I will test the latest RC Build and will update the status accordingly. Here is list of issues reported in Previous (dev) build. https://redmine.postgresql.org/issues/2677

pgAdmin 4 v2.0-rc1 builds

Initial builds of 2.0-rc1 are at https://developer.pgadmin.org/~dpage/2.0-rc1/ for sanity testing and building of additional packages. Please let me know if any show-stoppers are found. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterpr

Build failed in Jenkins: pgadmin4-master-python36 #315

See Changes: [Dave Page] Add new icons to release notes. -- [...truncated 341.22 KB...] SynonymPutTestCase (Fetch synonym Node URL)

Re: pgAdmin4 - Tree view icons for final reveiw

it is acceptable only if we are able to edit the icons through css otherwise we will have to have 3 sets of icons and it is nor recommended. So I am trying do a quick RnD on it so please hold on will come up with a solution. Thanks, Chethana kumar On Mon, Sep 11, 2017 at 3:54 PM, Murtuza Zabuawa

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Chethana, On Mon, Sep 11, 2017 at 3:04 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > > > On Mon, Sep 11, 2017 at 1:15 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> I also observed few issues, >> >> 1) In my opinion, New icons looks dull

pgAdmin 4 commit: Add new icons to release notes.

Add new icons to release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=51fd8f29fb61be992b8e6f5879b45547130eed6a Modified Files -- docs/en_US/release_notes_2_0.rst | 1 + 1 file changed, 1 insertion(+)

Jenkins build is back to normal : pgadmin4-master-python26 #439

See

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

Can we get this patch into the 2.0 release? On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezh...@pivotal.io wrote: Hi Hackers, Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords. - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" - Use

pgAdmin 4 commit: Use wheel==0.29.0 with Python 2.6 and 3.3.

Use wheel==0.29.0 with Python 2.6 and 3.3. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=732c373dfb381f5847b7fd89d7ddb0880bbe3902 Modified Files -- ci/run_feature_tests.sh | 11 +-- ci/run_python_tests.sh | 11 +--

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

Yes that I understood. I was targeting Python2.6 in general and by the way on 2020 we'll also have EOL for Python2.7 ;-) On Mon, Sep 11, 2017 at 3:29 PM, Dave Page wrote: > Well this is only for the CI of course - and we could limit it to just > Python 2.6. > > Plus... the wheel package is only

Jenkins build is back to normal : pgadmin4-master-python35 #313

See

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

Well this is only for the CI of course - and we could limit it to just Python 2.6. Plus... the wheel package is only used for creating the wheel, which is done on 2.7 anyway. On Mon, Sep 11, 2017 at 10:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > That will work but If

Jenkins build is back to normal : pgadmin4-master-python36 #313

See

Jenkins build is back to normal : pgadmin4-master-python33 #315

See

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

That will work but If we stick with older versions then we won't be able to take advantages of bug fixes, security related fixes etc until CentOS6 is dead(which is 30 Nov 2020 EOL), I personally don't think that's a good idea. On Mon, Sep 11, 2017 at 3:01 PM, Dave Page wrote: > Hi > > On Mon, Se

[pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

Hi Hackers, Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords. - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" - Use "x-gpsql" mode for sql editor when connecting database is greenplum - No behavior change to pg and ppas, still use "x

Build failed in Jenkins: pgadmin4-master-python26 #438

See Changes: [Dave Page] Bump the build suffix in preparation for release. [Dave Page] Remove menu icon tests that are no longer required. -- Started by an SCM c

Re: pgAdmin4 - Tree view icons for final reveiw

On Mon, Sep 11, 2017 at 1:15 PM, Murtuza Zabuawala wrote: > Hello, > > I also observed few issues, > > 1) In my opinion, New icons looks dull in main header menu due to dark > background, attaching screenshot for your reference. > Icons for the dialog boxes area will go in white. > > 2) Spacin

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

Hi On Mon, Sep 11, 2017 at 10:27 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > This is what I have in my system, which is working fine > > (venv26) murtuza@ubuntu-vm:[~/projects/pgadmin4/web/regression]$ python > Python 2.6.9 (default, Mar 6 2016, 02:31:36) > [GCC 5.3.1 20

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

This is what I have in my system, which is working fine (venv26) murtuza@ubuntu-vm:[~/projects/pgadmin4/web/regression]$ python Python 2.6.9 (default, Mar 6 2016, 02:31:36) [GCC 5.3.1 20160225] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import wheel >>> w

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

It's newer version of wheel is breaking this, set literals are not implemented in Python2.6. Unsupported syntax for Python2.6: { 'PKG-INFO', 'requires.txt', 'SOURCES.txt', } They released newer version couple of hours before :( On Mon, Sep 11, 2017 at 2:32 PM, Dave Page wrote: > Please al

Build failed in Jenkins: pgadmin4-master-python35 #312

See Changes: [Dave Page] Remove icons from the menus to de-clutter the UI and make it more [Dave Page] Bump the build suffix in preparation for release. -- [...t

pgAdmin 4 commit: Remove menu icon tests that are no longer required.

Remove menu icon tests that are no longer required. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cca7526b9ba8c1bec7446faa7259af6468ed17f0 Modified Files -- web/regression/javascript/browser/menu_spec.js | 18 -- 1

Build failed in Jenkins: pgadmin4-master-python36 #312

See Changes: [Dave Page] Remove icons from the menus to de-clutter the UI and make it more [Dave Page] Bump the build suffix in preparation for release. -- [...t

Build failed in Jenkins: pgadmin4-master-python33 #314

See Changes: [Dave Page] Remove icons from the menus to de-clutter the UI and make it more -- [...truncated 362.61 KB...] PhantomJS 2.1.1 (Linux 0.0.0): E

pgAdmin 4 commit: Bump the build suffix in preparation for release.

Bump the build suffix in preparation for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b5b3195c4b5037a4b13421b56a8ea9d5e2975d5 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

Please also check the python wheel builds OK - iirc, packages with conditionals in them in requirements.txt need special handling in setup.py. On Mon, Sep 11, 2017 at 9:55 AM, Dave Page wrote: > Great, but what's breaking Jenkins? > > On Mon, Sep 11, 2017 at 9:54 AM, Murtuza Zabuawala enterpris

Build failed in Jenkins: pgadmin4-master-python26 #437

See Changes: [Dave Page] Remove icons from the menus to de-clutter the UI and make it more -- Started by an SCM change Started by an SCM change [EnvInject] - Load

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

Great, but what's breaking Jenkins? On Mon, Sep 11, 2017 at 9:54 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I'm able to run tests & pgAdmin4 on my machine using Python2.6. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

I'm able to run tests & pgAdmin4 on my machine using Python2.6. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] On Mon, Sep 11, 2017 at 2:08 PM, Dave Pag

Re: pgAdmin4 - Tree view icons for final reveiw

On Mon, Sep 11, 2017 at 9:19 AM, Ashesh Vashi wrote: > On Mon, Sep 11, 2017 at 1:46 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the attached patch for not showing icons for menu items. >> I have not completely removed it, but - commented the code (wi

pgAdmin 4 commit: Remove icons from the menus to de-clutter the UI and

Remove icons from the menus to de-clutter the UI and make it more consistent with most OSs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3bbd1a8a48aac6a1f2b72dbe951f58fc32ed3bda Author: Ashesh Vashi Modified Files -- web/pgadm

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

Murtuza, please look into this ASAP. I need the builds to go green so I can cut the release! On Mon, Sep 11, 2017 at 9:32 AM, pgAdmin 4 Jenkins wrote: > See 436/display/redirect?page=changes> > > Changes: > > [Dave Page] Stick with the

Build failed in Jenkins: pgadmin4-master-python26 #436

See Changes: [Dave Page] Stick with the older Flask-Script module for Python 2.6 -- Started by an SCM change Started by an SCM change Started by an SCM change Sta

Re: pgAdmin4 - Tree view icons for final reveiw

On Mon, Sep 11, 2017 at 1:46 PM, Ashesh Vashi wrote: > Hi Dave, > > Please find the attached patch for not showing icons for menu items. > I have not completely removed it, but - commented the code (will remove it > in final patch). > We will need to remove the icons from the individual modules l

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Dave, Please find the attached patch for not showing icons for menu items. I have not completely removed it, but - commented the code (will remove it in final patch). Please review, and commit it (if it looks good to you). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Pos

Re: Build failed in Jenkins: pgadmin4-master-python26 #433

The response should be something like: "We do use CentOS 7, however we have thousands of downloads per year from CentOS 6 users, and we know that many of our customers still use RHEL 6 which is in support for a number of years yet for Enterprise users who may not be in a position to upgrade. This

Re: Build failed in Jenkins: pgadmin4-master-python26 #433

Thanks, applied. On Sat, Sep 9, 2017 at 5:53 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Please disregard my previous patch and find updated patch in which we will > use hard coded version only Python2.6 and not other versions.​ > > ​Please review. > ​ > > On Sat, Sep 9,

pgAdmin 4 commit: Stick with the older Flask-Script module for Python 2

Stick with the older Flask-Script module for Python 2.6 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b1aeadaf0347fb27bc7756cdf03aad32d03f3da Modified Files -- requirements.txt | 1 + 1 file changed, 1 insertion(+)

Re: pgAdmin4 - Tree view icons for final reveiw

On Mon, Sep 11, 2017 at 8:59 AM, Ashesh Vashi wrote: > On Mon, Sep 11, 2017 at 1:25 PM, Dave Page wrote: > >> Hmm, scrub the revert - it looks like you just fixed a bunch of the >> issues. >> > K. > >> >> The main thing I think that remains as an issue is the colouring on the >> headers and menu

Re: pgAdmin4 - Tree view icons for final reveiw

On Mon, Sep 11, 2017 at 1:25 PM, Dave Page wrote: > Hmm, scrub the revert - it looks like you just fixed a bunch of the issues. > K. > > The main thing I think that remains as an issue is the colouring on the > headers and menus - the former of which needs fixing somehow, the latter we > were go

Re: pgAdmin4 - Tree view icons for final reveiw

Hmm, scrub the revert - it looks like you just fixed a bunch of the issues. The main thing I think that remains as an issue is the colouring on the headers and menus - the former of which needs fixing somehow, the latter we were going to remove to de-clutter the UI anyway. On Mon, Sep 11, 2017 at

Re: pgAdmin4 - Tree view icons for final reveiw

Agreed - these issues need to be resolved before we can proceed. Ashesh, please revert the patch for now. Chethana, please figure out what we need to change to resolve the various issues raised. Iirc, we'd already decided to remove icons from the menus right? On Mon, Sep 11, 2017 at 8:45 AM, Mur

Build failed in Jenkins: pgadmin4-master-python26 #435

See Changes: [Ashesh Vashi] Miscellaneous fixes for icon sizing issue, missing tree nodes to be [Ashesh Vashi] Rename the SecurityGroupUnderSchema to SecurityGroupSchema, and -

pgAdmin 4 commit: Rename the SecurityGroupUnderSchema to SecurityGroupS

Rename the SecurityGroupUnderSchema to SecurityGroupSchema, and redefined in the database (instead of schema) javascript module, as it is also used by the foreign-server node too. Reported by: Neel Patel Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=comm

pgAdmin 4 commit: Miscellaneous fixes for icon sizing issue, missing tr

Miscellaneous fixes for icon sizing issue, missing tree nodes to be webpacked, etc. - Fixed the background-size for the svg icons to 20x20 px such that it does not adjust it's size when a context menu height is different due to length of the node label, also - it allows us to fix the issue of