Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-07 Thread Dave Page
No, let's just have two targets in one makefile. It's only for our convenience. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 8 Sep 2017, at 05:34, Surinder Kumar > wrote: > > Hi > >> On Th

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-07 Thread Surinder Kumar
Hi On Thu, Sep 7, 2017 at 8:48 PM, Dave Page wrote: > Hi > > On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> When we run Webpack in production mode, it performs optimization on code >> while in development we don't optimize generated JS a

Build failed in Jenkins: pgadmin4-master-python26 #432

2017-09-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix layout of password prompt dialogue. Fixes #2684 [Dave Page] Fix quoting of index column names on tables. Fixes #2619 -- Started by a

Re: [pgAdmin4][Patch]: Fix CREATE Script issue in Index module

2017-09-07 Thread Dave Page
Thanks, applied. On Thu, Sep 7, 2017 at 2:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where sql from CREATE Script/SQL Panel > doesn't escape column names in Table reversed engineered sql (if table has > index) & Index reversed

pgAdmin 4 commit: Fix quoting of index column names on tables. Fixes #2

2017-09-07 Thread Dave Page
Fix quoting of index column names on tables. Fixes #2619 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d248dab4c09a5c637569e3b4fb166c02ebff17a Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/tables/ind

pgAdmin 4 commit: Fix layout of password prompt dialogue. Fixes #2684

2017-09-07 Thread Dave Page
Fix layout of password prompt dialogue. Fixes #2684 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5f60e1a47b122dab133f2567efaf1a6dea8b6aa Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/js/alertify.pgadmin.defaul

Re: [pgAdmin4][Patch]: Fix 'Connect to Server' dialog layout

2017-09-07 Thread Dave Page
Thanks, applied. On Thu, Sep 7, 2017 at 11:12 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the 'Connect to Server' dialog layout issue. > RM#2684 > > This issue is regression of commit: Link >

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-07 Thread Dave Page
Hi On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > When we run Webpack in production mode, it performs optimization on code > while in development we don't optimize generated JS and CSS bundles as dev > mode is for developer use. > > So we should

[pgAdmin4][Patch]: Fix CREATE Script issue in Index module

2017-09-07 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where sql from CREATE Script/SQL Panel doesn't escape column names in Table reversed engineered sql (if table has index) & Index reversed engineered sql. RM#2619 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgAdmin4][Patch]: Fix 'Connect to Server' dialog layout

2017-09-07 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the 'Connect to Server' dialog layout issue. RM#2684 This issue is regression of commit: Link -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com