Jenkins build is back to normal : pgadmin4-master-python33 #290

See

Re: [Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar

Thanks patch applied. On Wed, Aug 23, 2017 at 10:16 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Adding more info... > > Before this patch, when Datetimepicker is selected, it expands from the > top, so it was impossible to scroll and hence the user cannot select the > date. > >

pgAdmin 4 commit: Datetimepicker will expand from bottom instead of Top

Datetimepicker will expand from bottom instead of Top, because of that user won't be able to select start and end time properly. Fixes #2656 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb9a05a7e7fb09b39afffb016b8824074eb325aa Author: Surin

Re: [Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar

Adding more info... Before this patch, when Datetimepicker is selected, it expands from the top, so it was impossible to scroll and hence the user cannot select the date. Now, after applying this patch, the Datetimepicker will expand to bottom and the subgrid will be scrollable, so the user can e

[Patch][pgAdmin4][pgAgent]: RM_2656 - Unable to select start and end time for scheduler from calendar

Hi *Issue:* When a user tries to select start and end time using the calendar, the calendar gets hidden and inaccessible to the user. *Solution:* ​ Set `Backform.DatetimepickerControl` option `widget positioning > vertical` to `bottom` which ensures Datepicker widget expands to bottom whenever i

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

On 22 August 2017 at 16:41, Dave Cramer wrote: > Ok, > > Surely this : > > self.table_template_path = 'table/sql/' + ( > +'#{0}#{1}#'.format(server_type, ver) > +if server_type == 'gpdb' else > +'#{0}#'.format(ver) > +) > > could be writ

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Ok, Surely this : self.table_template_path = 'table/sql/' + ( +'#{0}#{1}#'.format(server_type, ver) +if server_type == 'gpdb' else +'#{0}#'.format(ver) +) could be written in a more readable manner ?? Dave Cramer On 22 August 2017 at

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi, I've been able to get back to this and test it. So far so good. It applies more or less cleanly against 1.6 and everything I've tried so far works I'll update more as I test it. Thanks Dave Cramer On 21 August 2017 at 05:29, Teng Zhang wrote: > Hi, > > Thanks for the review, here is a fi

Re: Selecting tables from Browser

On Tue, Aug 22, 2017 at 8:27 AM Dave Page wrote: > On Tue, Aug 22, 2017 at 12:17 AM, Shirley Wang wrote: > >> Hi Rob >> On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt >> wrote: >> >>> Shirley, >>> >>> I have a few questions. >>> >>>1. Why 20. It is a dunbar number and seems smallish but is

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

​​ https://redmine.postgresql.org/issues/2008 ​ On Tue, Aug 22, 2017 at 7:14 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Aug 22, 2017 at 6:07 PM, Dave Page wrote: > >> >> >> On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >>

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

On Tue, Aug 22, 2017 at 6:07 PM, Dave Page wrote: > > > On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> *Issue:* >> >> The user seems to enter sometimes paths with quotes and sometimes add >> spaces which lead to failure of Backup, Restore

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issue:* > > The user seems to enter sometimes paths with quotes and sometimes add > spaces which lead to failure of Backup, Restore or Maintenance utility. > > *Changes:* > > - Added a note in help

[pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

Hi *Issue:* The user seems to enter sometimes paths with quotes and sometimes add spaces which lead to failure of Backup, Restore or Maintenance utility. *Changes:* - Added a note in help string `Note: Don't add quote(s) or space(s) before or after the path.` - Remove whitespace before/after

Re: Selecting tables from Browser

On Tue, Aug 22, 2017 at 12:17 AM, Shirley Wang wrote: > Hi Rob > On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt > wrote: > >> Shirley, >> >> I have a few questions. >> >>1. Why 20. It is a dunbar number and seems smallish but is there >>another reason? >> >> The browser fits about 30 is

[pgAdmin4] [pgAgent] [Patch]: RM_ 2657 - Syntax error while saving changes when start/end time is changed from scheduler

Hi *Issues fixed:* - Syntax error while saving changes when start/end time is updating in Edit mode. - The data type of `jscstart` should be `timestamptz` not `text`. Please find attached patch and review. Thanks, Surinder RM_2657.patch Description: Binary data

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Surinder, The dimensions remain same as 16x16, there is no change in it. The .svg file which I sent earlier was not the one you use it for your development, it was just to showcase the all icons in a single view. Regards, Chethana kumar On Tue, Aug 22, 2017 at 11:53 AM, Surinder Kumar < sur