Re: pgAdmin4 - Tree view icons for final reveiw

Hi Chethana, The icons dimensions seem to vary in attached SVG. I have attached screenshot. Ideally, the icon(s) must fit(take full width/height) in the dimensions either it is 16x16 or 14x14. because we will not adjust the pixels for each icon. Can you please tell what are the dimensions for an

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Chethana, - The icons for Server node is missing, we will need given set of icons for server. 1) Basic Server icon (Disconnect state) 2) PG (Connected state) 3) EPAS (Connected state) 4) GreenPlum (Connected state) [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum server icon

Re: pgAdmin4 - Tree view icons for final reveiw

Yes Shirley, I have already thought through on it. Basically, we need to have one more set of icons in white color mode so that we can use it on dialog headers as well. As the blue theme icons won't fit there. Please share your thoughts. Regards, Chethana kumar On Tue, Aug 22, 2017 at 4:32 AM, S

Re: Selecting tables from Browser

On Mon, Aug 21, 2017 at 7:17 PM, Shirley Wang wrote: > Hi Rob > On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt > wrote: > >> Shirley, >> >> I have a few questions. >> >>1. Why 20. It is a dunbar number and seems smallish but is there >>another reason? >> >> The browser fits about 30 ish

Re: Selecting tables from Browser

Hi Rob On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt wrote: > Shirley, > > I have a few questions. > >1. Why 20. It is a dunbar number and seems smallish but is there >another reason? > > The browser fits about 30 ish items right now on my smallish laptop screen. The question we asked o

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Chethana, I just thought of something with these icons. What happens with the ones that appear in dialog headers? In the blue bar? On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hello Team, > > I have applied labels for each icon for identification

Build failed in Jenkins: pgadmin4-master-python33 #289

See Changes: [Dave Page] Refactor keyboard shortcut functions in the query tool. Fix some -- [...truncated 336.04 KB...] ResourceGroupsDeleteTestC

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

Thanks, patches applied. On Mon, Aug 21, 2017 at 1:14 PM, Ashesh Vashi wrote: > > > On Wed, Aug 16, 2017 at 8:55 AM, Violet Cheng wrote: > >> Hi, >> >> Is there any update on these patches? Will it be committed soon? >> > Dave - would please take care of this? > > -- > > Thanks & Regards, > > A

pgAdmin 4 commit: Refactor keyboard shortcut functions in the query too

Refactor keyboard shortcut functions in the query tool. Fix some incorrect keycodes and update docs. Initial work by Sarah & Violet @ Pivotal, with additional tweaks by Murtuza @ EDB. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b585063a2

Jenkins build is back to normal : pgadmin4-master-python26 #409

See

pgAdmin 4 commit: Ensure role names are escaped in the membership contr

Ensure role names are escaped in the membership control. Fixes #2606 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e2ca260206baaf0f5e5de6d571c9bf7cb7d7e17 Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/ro

Re: [pgAdmin4][Patch]: Update codemirror to latest version

Thanks, applied. On Mon, Aug 21, 2017 at 12:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to update CodeMirror to latest version(5.28.0 > ) which will fixes below listed > issues, > > *Fixes:* > RM#1697 > RM#216

pgAdmin 4 commit: Update CodeMirror version. Fixes #1697. Fixes #2168.

Update CodeMirror version. Fixes #1697. Fixes #2168. Fixes #2447. Fixes #2562. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=654326a0d12a923b8e9fa9c0290448b78b32816e Author: Murtuza Zabuawala Modified Files -- web/package.json |

Re: [pgAdmin4][Patch]: To fix validation issue in connection string for pgAgent Job Step

Thanks, applied. On Mon, Aug 21, 2017 at 12:12 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where it was throwing error for valid > connection string if user passed host value as ip address. > RM#2655 > > -- > Regards, > Murtuza Zab

pgAdmin 4 commit: Fix connection string validation for pgAgent jobs. Fi

Fix connection string validation for pgAgent jobs. Fixes #2655 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d757d8698d095d249d434da0f1d65f85a2f01d74 Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/pgagent/

pgAdmin 4 commit: Update datetime picker. Fixes #2654

Update datetime picker. Fixes #2654 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d7b54eb62259dc53ffa36b012ccbf62126ab1bb Author: Surinder Kumar Modified Files -- web/package.json

Re: [pgAdmin4][Patch]: RM_ 2654 - Unable to set start and end time while creating pgAgent Job

Thanks, applied. On Mon, Aug 21, 2017 at 11:38 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > The bootstrap-datetimepicker > library being used > was an older version which had this issue. > So updated the bootstrap-dat

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

On Wed, Aug 16, 2017 at 8:55 AM, Violet Cheng wrote: > Hi, > > Is there any update on these patches? Will it be committed soon? > Dave - would please take care of this? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://

[pgAdmin4][Patch]: Update codemirror to latest version

Hi, PFA patch to update CodeMirror to latest version(5.28.0 ) which will fixes below listed issues, *Fixes:* RM#1697 RM#2168 RM#2447 RM#2562 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image

[pgAdmin4][Patch]: To fix validation issue in connection string for pgAgent Job Step

Hi, PFA minor patch to fix the issue where it was throwing error for valid connection string if user passed host value as ip address. RM#2655 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/s

[pgAdmin4][Patch]: RM_ 2654 - Unable to set start and end time while creating pgAgent Job

Hi, The bootstrap-datetimepicker library being used was an older version which had this issue. So updated the bootstrap-datetimepicker library to the latest one and this issue is fixed in n

Re: PATCH: pgagent connection string parsing

On Mon Aug 21, 2017 09:47:47AM +0100, Dave Page wrote: > On Mon, Aug 21, 2017 at 9:46 AM, Ashesh Vashi wrote: > > On Mon, Aug 21, 2017 at 1:41 PM, Dave Page wrote: > >> Regardless of that, connection.cpp does need to be taught the correct > >> name for connect_timeout, as well as the additional a

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi, Thanks for the review, here is a fixed patch working for GBDP which shows the appropriate graphs. In this fix, we toke out the changes to diver/psycopg2 and implemented the greenplum version checking process in the ppas way mentioned by Dave Cramer. Regards, Teng Zhang & Hao Wang On Mon, Aug

Re: PATCH: pgagent connection string parsing

On Mon, Aug 21, 2017 at 9:46 AM, Ashesh Vashi wrote: > On Mon, Aug 21, 2017 at 1:41 PM, Dave Page wrote: > >> >> >> On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Aug 21, 2017 10:52, "Thomas Krennwallner" >>> wrote: >>> >>> On Mon Aug

Re: PATCH: pgagent connection string parsing

On Mon, Aug 21, 2017 at 1:41 PM, Dave Page wrote: > > > On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> On Aug 21, 2017 10:52, "Thomas Krennwallner" >> wrote: >> >> On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: >> >On Aug 20, 201

Re: PATCH: pgagent connection string parsing

On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi wrote: > > > On Aug 21, 2017 10:52, "Thomas Krennwallner" > wrote: > > On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: > >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1] > tk+pg...@postsubmeta.net> > >wrote: > > > > % ./pgage

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

On Mon, Aug 21, 2017 at 1:23 PM, Dave Page wrote: > Ashesh, do you have a recommended way to do this? > > I haven't looked at the patch, but I assume it adds a database driver > module for GPDB? > I have not looked at the patch yet. I will take a look at it. -- Thanks & Regards, Ashesh Vashi E

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Ashesh, do you have a recommended way to do this? I haven't looked at the patch, but I assume it adds a database driver module for GPDB? On Mon, Aug 21, 2017 at 8:50 AM, Jing Li wrote: > Hi Dave, > > Since we're hoping to get this change working for GPDB we've currently > using this method to d

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi Dave, Since we're hoping to get this change working for GPDB we've currently using this method to detect if it's gpdb and show the appropriate graphs. Right now it displays errors on the dashboard if it's connected to a gpdb server.For this patch specifically, the goal is to improve the experie