Jenkins build is back to normal : pgadmin4-master-python33 #286

See

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for UUID creation issues with test > objects for FTS configurations, FTS dictionaries and FTS parsers. > Previously(refer email with subject "Build failed

Build failed in Jenkins: pgadmin4-master-python26 #408

See Changes: [Ashesh Vashi] Fixes #2567 - Use the proper database connection to fetch the default -- [...truncated 339.82 KB...] PackagePutTestCa

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

On Tue, Aug 8, 2017 at 3:46 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Patch looks good to me. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > [image: https://community.postgresrocks.net/] >

pgAdmin 4 commit: Fixes #2567 - Use the proper database connection to f

Fixes #2567 - Use the proper database connection to fetch the default prileges in the properties tab of the database. Reviewed by: Murtuza Zabuawala Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6223c9a490ead577e5c6f3058e6db51d0d2c5b7 Autho

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

Great! Thanks a lot. Violet On Fri, Aug 18, 2017 at 12:13 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> The patch looks good to me. >> >>> Thanks, >> Khushboo >> >> On Fri, Aug

Jenkins build is back to normal : pgadmin4-master-python36 #281

See

Build failed in Jenkins: pgadmin4-master-python33 #285

See Changes: [Ashesh Vashi] Extract the generate_url(..) function from node.js, and collection.js -- [...truncated 337.36 KB...] 159 tests passed

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > >> Thanks, > Khushboo > > On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng w

pgAdmin 4 commit: Extract the generate_url(..) function from node.js, a

Extract the generate_url(..) function from node.js, and collection.js Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d527769bf8251595bf3adfcbd9c2a58e0ab1cc92 Author: Violet Cheng Modified Files -- web/pgadmin/browser/static/js/co

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Awesome, thanks! Akshay Joshi 于2017年8月17日 周四下午8:24写道： > Thanks patch applied. > > On Wed, Aug 16, 2017 at 11:30 AM, Violet Cheng wrote: > >> Thanks Surinder! Hope it could be committed soon :) >> >> On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >

Build failed in Jenkins: pgadmin4-master-python36 #280

See Changes: [akshay.joshi] User can not add New Server through Quick links. Fixes #2634 -- [...truncated 335.99 KB...] TableAddTestCase (Create R

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

Thanks patch applied. On Tue, Aug 8, 2017 at 1:55 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for the same. > > Thanks Surinder for pointing that out, I assumed that we had a typo in > that file. > > > > -- > Regards, > Murtuza Zabuawala > Enterp

pgAdmin 4 commit: User can not add New Server through Quick links. Fixe

User can not add New Server through Quick links. Fixes #2634 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9b80dae9c0dc3e054512c16b4c38a98c8980c93 Author: Murtuza Zabuawala Modified Files -- .../browser/server_groups/servers/ro

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Thanks patch applied. On Wed, Aug 16, 2017 at 11:30 AM, Violet Cheng wrote: > Thanks Surinder! Hope it could be committed soon :) > > On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi Violet, >> >> I have already reviewed this patch. Here is the

pgAdmin 4 commit: Fixed alertify notification messages where checkmark

Fixed alertify notification messages where checkmark box disconnected from frame. Fixes #2644 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dee5186f655b46ac239a504d676c571e1e071d20 Author: Sarah McAlear Modified Files -- web/pg

pgAdmin 4 commit: Unset compression ratio if it is an empty string in B

Unset compression ratio if it is an empty string in Backup module. Fixes #2582 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7686dee054ef8a77ace02c1c4e4eed65a475602 Author: Surinder Kumar Modified Files -- web/pgadmin/tools/bac

Re: [pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value

Thanks patch applied. I have adding server side validation too. On Wed, Aug 16, 2017 at 6:11 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issue:* > In Backup, compression field can only accept values between 0 to 9. But if > the field is clicked, an empty value is set in

Re: [pgAdmin4][Patch]: RM_2646 - Spinner icon not found error when a server node is connected

Thanks patch applied. On Fri, Aug 11, 2017 at 12:35 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Since Acitree is removed from vendor directory, but when a server is > connected, the load-node.gif file is still referencing tovendor directory > instead of referencing to st

pgAdmin 4 commit: Fixed the path reference of load-node.gif which was r

Fixed the path reference of load-node.gif which was referencing to vendor directory. Fixes #2646 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bff48e0b2de6ba7e63f1f3ee8ae6cadfabf75938 Author: Surinder Kumar Modified Files -- we

Re: [pgAdmin4][PATCH] To fix pgAgent job step issues

Thanks patch applied with one minor change. On Wed, Aug 16, 2017 at 6:12 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix below given issues from pgAgent Jobs > Steps module. > 1) 'Connection Type' cell was not honouring to 'Kind' opti

pgAdmin 4 commit: 1) Connection Type cell was not honouring to 'Kind' o

1) Connection Type cell was not honouring to 'Kind' option in Subnode control. 2) Kind option was not saved properly 3) User was not be able to update Kind option in edit mode. Fixes #2633 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2df462

Jenkins build is back to normal : pgadmin4-master-python27 #280

See

Re: Unified server/desktop config

Thanks. Out of interest, what changes were required? All, this reinforces to me that this should be a v2.0 change. Other thoughts? On Mon, Aug 14, 2017 at 4:59 AM, Bing Xu wrote: > Hi hackers, > > We've reviewed this patch and it need us changing our own config_local.py > file. It's ok and we'l

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

Thanks patch applied. On Wed, Aug 9, 2017 at 4:25 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com>

pgAdmin 4 commit: Use dict based data instead of 2d-array in Type modul

Use dict based data instead of 2d-array in Type module as we are adding keys on the fly. Reviewed By: Harshal Dhumal Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6c4a16cecd8586c9ee5c9fa8456b6074813f46 Author: Murtuza Zabuawala Modified