Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Thanks Surinder! Hope it could be committed soon :) On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Violet, > > I have already reviewed this patch. Here is the link >

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Violet, I have already reviewed this patch. Here is the link . Thanks, Surinder On Wed, Aug 16, 2017 at 8:57 AM, Violet Cheng wrote: > Hi, > > Any update on this patch? Could it be c

Re: Code Folding in Code Mirror

On Tue, Aug 15, 2017 at 2:33 PM, Sarah McAlear wrote: > Ok, it does work for the cases defined. We misunderstood how it works. > Still, could we enable this everywhere? > Yes. > What is the reason not to? > I don't see any reason not to do it. -- Thanks, Ashesh > > Thanks, > Bing & Sarah > > O

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi, Any comment on this patch? If no, will it be committed soon? Thanks, Violet On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear wrote: > Hi Hackers! > > This patch enables Greenplum users to see the same charts on the dashboard > as postgres users. It also adds some additional information to th

Re: [pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 2:46 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > I reviewed this patch and it looks good to me. > > Thanks, > Surinder > > On Fri, Aug 11, 2017 at 9:13 AM, Sarah Mc

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 2:38 PM, Ashesh Vashi wrote: > On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > >> Hi hackers, >> >> We tried to extract and refactor generate_url function in node.js and >> collecti

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi, Any update on this patch? Could it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 1:40 PM, Sarah McAlear wrote: > Hi! > > We fixed that issue and created a new patch >

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

Hi, Is there any update on these patches? Will it be committed soon? Thanks, Violet On Thu, Aug 10, 2017 at 2:31 PM, Wenlin Zhang wrote: > Hi hackers, > >We have rebased all the three patches and they are ready to be applied. > > Thanks, > > Wenlin & Matt > > On Wed, Aug 9, 2017 at 11:20 A

Re: [pgAdmin4][patch] Fix feature tests failure

Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang wrote: > As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for > those who would like to join) yesterday, these errors seem to occur only on > her U

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi It seems like the keyboard shortcuts for commenting got mixed up. Block commenting: CMD+Shift+/ should comment like /* */ Inline commenting: CMD + / should comment like -- As of now it's reversed. Shirley On Wed, Jul 26, 2017 at 7:51 AM Dave Page wrote: > Thanks, applied. I also exte

Re: Code Folding in Code Mirror

Ok, it does work for the cases defined. We misunderstood how it works. Still, could we enable this everywhere? What is the reason not to? Thanks, Bing & Sarah On Tue, Aug 15, 2017 at 5:00 PM, Sarah McAlear wrote: > Hi Hackers! > > We are working on unifying the CodeMirror stuff into one locatio

Code Folding in Code Mirror

Hi Hackers! We are working on unifying the CodeMirror stuff into one location. While looking at this we noticed that while there is logic for code folding, it doesn't seem to be working. Does it work for everyone else? We also started to wonder if there is a specific reason that code folding shoul

[pgaweb][patch] Use https link for git repo

Hi Hackers, As per discussion on https://www.postgresql.org/message-id/flat/CAGRPzo-_dSYr5Y1D%2B0uBLo39Bb6MVTg3%3DCM%3DhrmX7LdF%3DfQbhQ%40mail.gmail.com#CAGRPzo-_dSYr5Y1D+0uBLo39Bb6MVTg3=CM=hrmX7LdF=fq...@mail.gmail.com, I've updated the pgadmin website with the attached patch. Instead of the docs