Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

2017-08-07 Thread Surinder Kumar
Hi Murtuza, As type server-group is renamed to server_group, I can see there are other occurrences of string server-group which needs to be replaced when I perform search in pgAdmin4. Can you please take care of those occurrences? Thanks, Surinder On Tue, Aug 8, 2017 at 12:02 PM, Murtuza Zabuaw

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-07 Thread Ashesh Vashi
Murtuza, Please review this one. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma wrote: > Hi, > >

Re: Can someone tell me what this code does ?

2017-08-07 Thread Murtuza Zabuawala
Hi, This piece of code allow us to dynamically import all the available driver modules from '../utils/driver/' directory into our application. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <

Re: [gpAdmin4][patch] query history updates

2017-08-07 Thread Wenlin Zhang
Hi Khushboo, Thanks for your review. About the copy/paste function bug, we just found that this is an existing bug in master. Except for the query History tab, this bug also exist in the query data output . If you copy the data row in "Data Output" tab, it works fine, but the copy/past

[pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

2017-08-07 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where add new server functionality through Quick link on Dashboard is broken. RM#2634 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/]

Re: Unified server/desktop config

2017-08-07 Thread Surinder Kumar
Hi On Ubuntu-14.04, I got error Application Server couldn't be contacted: *Steps performed:* - I have already installed pgAdmin4-1.4 which come with PostgreSQL-9.6 installer. then I run root@ubuntu:/opt/PostgreSQL/9.6/pgAdmin 4/bin# ./pgAdmin4./. - Now took latest git pull from HEAD

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-07 Thread Ashesh Vashi
On Mon, Aug 7, 2017 at 9:06 PM, Dave Page wrote: > > > On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Could you comment on the new design update for subnode control ? >> >> Attached designs - >> >> 1. subnode_current.png - The exist

Re: Fix key error

2017-08-07 Thread Surinder Kumar
Hi, On Tue, Aug 8, 2017 at 12:23 AM, Dave Cramer wrote: I don't think this line in web/pgadmin/browser/server_groups/servers/types.py > does what it should. > > default_path = config.DEFAULT_BINARY_PATHS[st.stype] or "" > > will ever succeed if the key does not exist > > Attached patch should wo

Can someone tell me what this code does ?

2017-08-07 Thread Dave Cramer
I'm fairly new to Python so excuse my naiveté. This code: in web/pgadmin/utils/driver/__init__.py does not appear to load the drivers into the drivers dictionary ? Or am I missing something def init_app(app): drivers = dict() setattr(app, '_pgadmin_server_drivers', drivers) DriverRe

Fix key error

2017-08-07 Thread Dave Cramer
I don't think this line in web/pgadmin/browser/server_groups/servers/types.py does what it should. default_path = config.DEFAULT_BINARY_PATHS[st.stype] or "" will ever succeed if the key does not exist Attached patch should work. Dave Cramer fixkeyerror.patch Description: Binary data

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-07 Thread Dave Page
On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Dave, > > Could you comment on the new design update for subnode control ? > > Attached designs - > > 1. subnode_current.png - The existing view > 2. subnode_new.png - The updated view > 3. current_new.p

Re: [PATCH] Work with newer Flask-Security.

2017-08-07 Thread Ashesh Vashi
Harshal, Please take a look at it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Aug 7, 2017 at 6:46 PM, Wouter van Kesteren wrote:

Re: Unified server/desktop config

2017-08-07 Thread Dave Page
On Mon, Aug 7, 2017 at 1:43 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > The patch seems to work in Runtime mode, but fails in Server mode with > error: > > (pgAdmin_27)Laptop195:pgadmin4 surinder$ python web/pgAdmin4.py > Traceback (most recent call last): > File "web/

[PATCH] Work with newer Flask-Security.

2017-08-07 Thread Wouter van Kesteren
I installed it on my system and i got the following error: Traceback (most recent call last): File "/usr/x86_64-pc-linux-gnu/lib/python3.4/site-packages/flask/app.py", line 1997, in __call__ return self.wsgi_app(environ, start_response) File "/usr/x86_64-pc-linux-gnu/lib/python3.4/site-pa

Re: Unified server/desktop config

2017-08-07 Thread Surinder Kumar
Hi, The patch seems to work in Runtime mode, but fails in Server mode with error: (pgAdmin_27)Laptop195:pgadmin4 surinder$ python web/pgAdmin4.py Traceback (most recent call last): File "web/pgAdmin4.py", line 55, in exec(open(file_quote(setupfile), 'r').read()) File "", line 35, in F

Re: Unified server/desktop config

2017-08-07 Thread Surinder Kumar
On Mon, Aug 7, 2017 at 4:11 PM, Ashesh Vashi wrote: > On Mon, Aug 7, 2017 at 3:59 PM, Dave Page wrote: > >> Anyone? >> > Surinder - please give this one priority. > Sure ​.​ > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company >

Re: Unified server/desktop config

2017-08-07 Thread Ashesh Vashi
On Mon, Aug 7, 2017 at 3:59 PM, Dave Page wrote: > Anyone? > Surinder - please give this one priority. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: Unified server/desktop config

2017-08-07 Thread Dave Page
Anyone? On Thu, Jul 20, 2017 at 5:03 PM, Dave Page wrote: > All, > > Attached is a patch that aims to allow us to have a standardised config > that will work out of the box for both web and desktop modes. It does this > by doing two things: > > 1) The runtime sets SERVER_MODE in the Python envir

[pgAdmin4][patch] Fix feature tests failure

2017-08-07 Thread Wenlin Zhang
Hi Hackers, This patch is about fixing the feature tests failure. Thanks, Wenlin, Violet & Hao diff --git a/web/pgadmin/feature_tests/query_tool_journey_test.py b/web/pgadmin/feature_tests/query_tool_journey_test.py index 0795028c..dcab7241 100644 --- a/web/pgadmin/feature_tests/query_tool_journ

pgAdmin 4 commit: Changed the mapping of cell from 'numeric' to 'intege

2017-08-07 Thread Akshay Joshi
Changed the mapping of cell from 'numeric' to 'integer' for integer control as numeric cell has been removed from the code. Fixes #2631 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e418cb838730ce186c620cdf39c064eca02a7d61 Modified Files --