Re: [pgAdmin4][Patch]: RM_ 2620 - Getting error "Violates check constraint" while creating pgAgent job

2017-08-04 Thread Akshay Joshi
Hi Surinder As per discussion, this should be fixed at server side instead of client(js) side. I have fixed and committed the code. On Wed, Aug 2, 2017 at 6:07 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > It gives error because database value is passed in query generated

pgAdmin 4 commit: Set the database name to blank('') when job type is s

2017-08-04 Thread Akshay Joshi
Set the database name to blank('') when job type is set to batch, while creating pgAgent job. Fixes #2620 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801a05891e94304d267e91adb98a92b5d8ea48cd Modified Files -- .../server_groups

Re: Add basic function search

2017-08-04 Thread jvenegasperu .
Hello Good morning everyone Attached image I consider it very necessary Add a file finder There must be a way to find the script within the selected directory. 2017-08-04 7:11 GMT-05:00 Ashesh Vashi : > Hi José, > On Thu, Aug 3, 2017 at 2:10 AM, jvenegasperu . > wrote: > >> Please add a file

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-08-04 Thread Ashesh Vashi
Harshal, On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > Ashesh, can you deal with this please? Thanks. > > On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM #2603: Import/Export File >> iss

Jenkins build is back to normal : pgadmin4-master-python34 #267

2017-08-04 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-04 Thread Murtuza Zabuawala
Hi Sarah, Could you please rebase and send the patch again, I am not able to apply any of the patch. murtuza@laptop:~/Documents/projects/pgadmin4$ git apply ~/Downloads/1_refactor_keyactions.diff error: patch failed: web/pgadmin/tools/sqleditor/static/js/sqleditor.js:552 error: web/pgadmin/tools/

Re: Add basic function search

2017-08-04 Thread Ashesh Vashi
Hi José, On Thu, Aug 3, 2017 at 2:10 AM, jvenegasperu . wrote: > Please add a file finder in the PgAdmin4 query tool > > Files are listed but there is no search engine with PgAdmin3 I was used to > looking there the script I needed I guess more people work that way > > Check the option to do the

Re: [Patch][pgAdmin4]: RM_2617 - pgAgent module is not loading after webpacking

2017-08-04 Thread Akshay Joshi
Thanks, patch applied. On Tue, Aug 1, 2017 at 11:45 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Added an entry for pgAgent JS module to imports-loader to fix the issue. > > Please find attached patch and let me know for review comments. > > Thanks, > Surinder > -- *

pgAdmin 4 commit: Added missing pgagent file in webpack.config.js Fixes

2017-08-04 Thread Akshay Joshi
Added missing pgagent file in webpack.config.js Fixes #2617 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06a65ecf71ccbbfb20cce86ebc1ad0b4b4289cdd Author: Surinder Kumar Modified Files -- web/webpack.config.js | 3 ++- 1 file cha

Re: [gpAdmin4][patch] query history updates

2017-08-04 Thread Ashesh Vashi
Khushboo, On Thu, Aug 3, 2017 at 9:03 AM, Hao Wang wrote: > Hi Hackers, > > Here is a patch for query tools history UX improvements: > >- Add copy button for query text >- Historical queries are binned by day > > Please review it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA:

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-04 Thread Ashesh Vashi
Murtuza, On Thu, Aug 3, 2017 at 3:38 PM, Sarah McAlear wrote: > Hi Hackers! > > Attached is a patch that extracts the functions called by the > keyboard_shortcuts function extracted earlier from sqlEditor. This > includes > >- executeQuery >- explainAnalyze >- explain >- download

Build failed in Jenkins: pgadmin4-master-python34 #266

2017-08-04 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue in query tool where messages were not displaying from -- [...truncated 336.14 KB...]

Re: [pgAdmin4][Patch]: To fix Function/Procedures messages issue in query tool

2017-08-04 Thread Akshay Joshi
Thanks patch applied. On Wed, Aug 2, 2017 at 4:10 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where in query tool, messages were not > displaying from functions/procedures properly. > RM#2555 > > Needs to be reviewed with (Success/Fail/E

pgAdmin 4 commit: Fixed issue in query tool where messages were not dis

2017-08-04 Thread Akshay Joshi
Fixed issue in query tool where messages were not displaying from functions/procedures properly. Fixes #2555 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef48c2ed91b023e4075259c3279484b48f437e49 Author: Murtuza Zabuawala Modified Files --