Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

On 20 Jul 2017, at 23:02, Shirley Wang wrote: >> >> Iirc, we did some back and forth over that about 18 months ago, as dialogues >> didn't look quite right without the bold - and I do think that it looks a >> little light on your mockup. I don't think there's a hard requirement they >> matc

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

> > > Iirc, we did some back and forth over that about 18 months ago, as > dialogues didn't look quite right without the bold - and I do think that it > looks a little light on your mockup. I don't think there's a hard > requirement they match table headers; they are distinct types of header. > > H

Jenkins build is back to normal : pgadmin4-master-python34 #245

See

pgAdmin 4 commit: Move Query Tool keyboard shortcut code into a new mod

Move Query Tool keyboard shortcut code into a new module and add tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86dc1e81f110f7716fee36c5d3f69976c11c2878 Author: Sarah McAlear Modified Files -- .../static/js/sqleditor/keybo

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thanks, applied. On Thu, Jul 20, 2017 at 9:31 PM, Sarah McAlear wrote: > Hello, > > Attached is a refactor that extracts the keyAction function in the sqlEditor > and placed it into a keyboard_shortcuts file. The extracted code is unit > tested. I did not look at the feature tests. > > We are pl

Build failed in Jenkins: pgadmin4-master-python34 #244

See Changes: [Dave Page] Improve the history UI. -- [...truncated 336.15 KB...] ResourceGroupsAddTestCase (Add resource groups) Pa

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hello, Attached is a refactor that extracts the keyAction function in the sqlEditor and placed it into a keyboard_shortcuts file. The extracted code is unit tested. I did not look at the feature tests. We are planning on diving into it a bit more but maybe not immediately. Up next we will be pull

Re: [PATCH] Persist opened nodes in tree

Versus, We are about to start a story to persist the Tabs and History. Since pgAdmin 4 is centered around the tree we need to be able to persist this first. If you are interested in making the changes suggested above we have some additional work to do, otherwise we'd be happy to pick this up and

Re: [pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

Thanks, applied. On Thu, Jul 20, 2017 at 8:23 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > This patch updates the SCSS files of the styleguide to move all the colors > into variables to be easier to use in the application. > > Thanks > Joao && Matt > -- D

Re: Request a feature

Nick, We were looking at adding this feature but ran into the same problem you are describing, e.g. when to include and when to not include headers. Honestly we were waiting for people to start using the new UX for the differing copy and paste functionality and waiting to see what people said. T

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Murtuza, Is there a particular reason you choose the keyboard shortcuts that you choose. When we were looking at this earlier to see what was being used elsewhere we discovered: jetbrains cmd+/ pycharmcmd+/ SublimeCtrl+/ Toggle line comment Ctrl+Shift+/ Toggle bloc

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Ah, OK - I was working on them one at a time. Thanks, patches applied! On Thu, Jul 20, 2017 at 7:01 PM, Matthew Kleiman wrote: > Hi Dave, > > In our previous email, the second patch fixed the linting issue from the > first patch. > However, we've remade these two patches so they both pass the l

pgAdmin 4 commit: Improve the history UI.

Improve the history UI. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e29cd8d83dfbb00911caf2c3ea5065a7511bd11c Author: Matthew Kleiman Modified Files -- .../feature_tests/query_tool_journey_test.py | 4 +++ .../jsx/history

pgAdmin 4 commit: Allow navigation of query history using the arrow key

Allow navigation of query history using the arrow keys. Fixes #2590 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=21bfcd83f42ba06f146ed1d2010fd66db0ed Author: Matthew Kleiman Modified Files -- .../feature_tests/query_tool_jo

[pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

Hi Hackers, This patch updates the SCSS files of the styleguide to move all the colors into variables to be easier to use in the application. Thanks Joao && Matt diff --git a/pgaweb/static/css/styleguide/_alert.scss b/pgaweb/static/css/styleguide/_alert.scss index 26680b7..2c85514 100644 --- a/pg

[pgAdmin4][Patch] Font sizes to 13 px and not bolded

Hi Attached is a patch for changing the font sizes of dialog, table, and graph headers to 13 px and unbold them. Let us know your thoughts. Shirley + Shruti -- *Shirley Wang* Product Designer Pivotal Labs 01-change-header-font-sizes.patch Description: Binary data

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi Dave, In our previous email, the second patch fixed the linting issue from the first patch. However, we've remade these two patches so they both pass the linting test. Thanks, Matt and João On Thu, Jul 20, 2017 at 12:56 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 2:18 PM, Joao De Al

Re: [pgAdmin4][Patch]: To make session more secure in web mode

Thanks, applied. On Thu, Jul 20, 2017 at 3:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > > On Thu, Jul 20, 2017 at 6:17 PM, Dave Page wrote: > >> >> >> On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> It is base

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: > Hi > > On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find patch attached, There were two issues, >> 1) We removed the default button to clear the editor window, it >> broke _clear_query_

pgAdmin 4 commit: Add the Flask-Paranoid module for a little extra, wel

Add the Flask-Paranoid module for a little extra, well, paranoia in web mode. Fixes #2584 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64f3a559abadd62b9c49b78e1a937191fb0253ef Author: Murtuza Zabuawala Modified Files -- requir

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find patch attached, There were two issues, > 1) We removed the default button to clear the editor window, it > broke _clear_query_tool() functionality. > 2) The buttons arrang

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Dave, > Did you use the latest one patch we sent? > We realised that this was an issue in the second email we sent. > Just checked again, and yes, that was the third and latest version I've rece

Re: Unified server/desktop config

LOL! On Thu, Jul 20, 2017 at 5:53 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Oops sorry my bad, I did not removed it. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 20, 2017 at 10:22 P

Re: Unified server/desktop config

Oops sorry my bad, I did not removed it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 20, 2017 at 10:22 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Partial patch for feature test got in

Re: Unified server/desktop config

Hi Dave, Partial patch for feature test got included in you patch :) On Thu, Jul 20, 2017 at 9:33 PM, Dave Page wrote: > All, > > Attached is a patch that aims to allow us to have a standardised config > that will work out of the box for both web and desktop modes. It does this > by doing two

Unified server/desktop config

All, Attached is a patch that aims to allow us to have a standardised config that will work out of the box for both web and desktop modes. It does this by doing two things: 1) The runtime sets SERVER_MODE in the Python environment before starting the app. If this value is set, then it overrides t

pgAdmin 4 commit: Remove debug logging of the URL map which is extremel

Remove debug logging of the URL map which is extremely long now, and not of a great deal of use. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83ac1f3555066322077b1cdc212ee7ff74cf3322 Modified Files -- web/pgadmin/__init__.py |

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Surinder & Murtuza! We are actually working on that right now. We should be sending a patch soon. Thanks! Shruti & Sarah On Thu, Jul 20, 2017 at 7:52 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Can the code related to Menu KeyEvents be moved out into a sepa

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Murtuza, Can the code related to Menu KeyEvents be moved out into a separate file say 'menu_actions.js' if feasible ? As the more functionality will be added to sqleditor, codemirror and its file menu in future, the codebase will eventually increase. It will ease writing jasmine test cases as

Re: [pgAdmin4][Patch]: To make session more secure in web mode

On Thu, Jul 20, 2017 at 6:17 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> It is based on Flask-Login module but >> 1) Flask-Login will mark a user as logged out when it detects that an >> existing session suddenly appears to come fro

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, Please find patch attached, There were two issues, 1) We removed the default button to clear the editor window, it broke _clear_query_tool() functionality. 2) The buttons arrangements, we added new Edit button in between Delete and Filter button causing the "Explain" -> "Explain Options"

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hello Dave, Did you use the latest one patch we sent? We realised that this was an issue in the second email we sent. Thanks Joao On Thu, Jul 20, 2017, 8:15 AM Dave Page wrote: > Hi > > On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: > >> Hi again! >> >> Attached are the most updated patche

Re: [pgAdmin4][Patch]: To make session more secure in web mode

On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > It is based on Flask-Login module but > 1) Flask-Login will mark a user as logged out when it detects that an > existing session suddenly appears to come from a different originating IP > address or a

Re: [pgAdmin4]: Webpacking of static JS/CSS

Thanks, applied. On Thu, Jul 20, 2017 at 1:35 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Can you please review this patch please? I guess it was missed as i send 2 > patches back to back in same email chain. > Please find inline detailed description of issue. > >

pgAdmin 4 commit: Fix webpacking of loading icon.

Fix webpacking of loading icon. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae3acbdbbc9e40fde8f085e0291deed2d265a558 Author: Surinder Kumar Modified Files -- web/pgadmin/misc/file_manager/templates/file_manager/index.html |

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi Dave, Can you please review this patch please? I guess it was missed as i send 2 patches back to back in same email chain. Please find inline detailed description of issue. On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > The loading icon ima

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, I am working on this, will send you patch soon. On Thu, Jul 20, 2017 at 5:53 PM, Dave Page wrote: > Did you get a chance to look at this yet Murtuza? > > On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Sure, Will take a look. >> >> -- >> Regards, >> Mu

Re: [pgAdmin4][Patch]: To make session more secure in web mode

It is based on Flask-Login module but 1) Flask-Login will mark a user as logged out when it detects that an existing session suddenly appears to come from a different originating IP address or a different browser. But it is unfortunate that Flask-Login does not enable this option by default. 2) It

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Did you get a chance to look at this yet Murtuza? On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Sure, Will take a look. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On

Jenkins build is back to normal : pgadmin4-master-python26 #370

See

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi On Wed, Jul 19, 2017 at 8:33 PM, Shruti Iyer wrote: > Hi again! > > Attached are the most updated patches. We found an issue with the previous > implementation. So we generated the new patches. > The 01 patch fails linting: /Users/dpage/git/pgadmin4/web/regression/javascript/history/query_h

Re: [pgAdmin4][Patch]: To make session more secure in web mode

Hi On Thu, Jul 20, 2017 at 12:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Tested it with PEM7 RestApi testsuite and it is working fine :) > The docs for this module say it's based on Flask-Login's session protect mechanism, and was intended to allow sessi

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

On Thu, Jul 20, 2017 at 1:04 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 1:02 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jul 19, 2017 at 1:58 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Jul 18, 2017 at 8:31 PM, Dave Page wrote: >>>

pgAdmin 4 commit: Don't attempt to render binary data in the query tool

Don't attempt to render binary data in the query tool result grid. Fixes #2080. Fixes #2074. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54882e061cd1f29e220cfee375586f4e2fe17d5e Author: Harshal Dhumal Modified Files -- .../fe

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

On Thu, Jul 20, 2017 at 1:02 PM, Dave Page wrote: > Hi > > On Wed, Jul 19, 2017 at 1:58 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Jul 18, 2017 at 8:31 PM, Dave Page wrote: >>> >>> >>> Thanks, that passes. >>> >>> Now I've played with it though, I

pgAdmin 4 commit: More webpack cleanup - add comments liberally and ren

More webpack cleanup - add comments liberally and rename lib.css to style.css Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2eb151c2d9e261ccd4a157e5f7ac00fc47b97d41 Author: Surinder Kumar Modified Files -- web/pgadmin/static/css

pgAdmin 4 commit: Fix regressions introduced by PG10's partitioning cod

Fix regressions introduced by PG10's partitioning code. Fixes #2043. Fixes #2324. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d4da6724724e6e24d243e1c3f1ca93ef7c91046 Author: Akshay Joshi Modified Files -- .../servers/databas

[pgAdmin4][Patch]: To make session more secure in web mode

Hi, PFA minor patch to make session more secure in web mode. RM#2584 Ref: https://flask-paranoid.readthedocs.io/en/latest/ Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/requirements.txt b/requirements.txt in

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi *Changes:* Add proper comments in webpack configuration files. Rename lib_css to style.css Please find attached patch and review Thanks, Surinder On Thu, Jul 20, 2017 at 12:37 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > The loading icon image is used in FileManage

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi The loading icon image is used in FileManager and it is still referenced from vendor `aciTree`(which is removed) so it gives 404 not found when FileManager is opened from Query tool/Backup utility. Please find attached patch and review. Thanks, Surinder Kumar webpack_file_manager_icon_issue