Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

Hi Dave, Please find updated patch for the same. On Mon, Jul 17, 2017 at 8:59 PM, Dave Page wrote: > Hi > > On Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add SSL support for database connection. >> RM#2170 >> >> Included test to check

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Hi! I can't seem to get the patch to completely work on my computer, only the close icon shows up plus the dialog and success/error messages, but here are some comments: +1 to Dave's comment about refreshing after the cancel operation - We're working on a patch for updating alerts in the Dashboa

Re: Testing out font changes in query editor tool

Thank you! We also realized it would be easier on people to have both Mac and Windows test builds from the same url above. If it's not too difficult, would you also be able to add that as well? On Mon, Jul 17, 2017 at 5:55 AM Dave Page wrote: > On Fri, Jul 14, 2017 at 5:06 AM, Murtuza Zabuawala

[pgadmin-hackers][pgaweb][Patch] Add style guide to pga website

Hello Hackers, With this patch we added the style guide to the current pgAdmin website. It is not 100% migrated yet, but we already have the Alerts and colors. Thanks Matt && João diff --git a/README.md b/README.md index 3b1c852..0eaec2e 100644 --- a/README.md +++ b/README.md @@ -65,9 +65,12 @@ p

[pgadmin-hackers] 10k Tables and more

Hi Hackers, We were looking at a schema that had 10k+ tables on it and we noticed a substantial decrease of performance while loading the tables and after they are loaded and we try to scroll over them. After some search on the web we found a post of the ACITree maintainer here

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

Hi On Mon, Jul 17, 2017 at 1:09 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find updated patch. Now placeholder string for bytea and bytea[] > data will only appear in datagrid (view all/1000/500 rows). If user > executes query using Query tool then placeholder w

Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

Hi On Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add SSL support for database connection. > RM#2170 > > Included test to check if current connection is using SSL or not > I think the SSL test needs a little work. Instead of

Build failed in Jenkins: pgadmin4-master-python35 #243

See Changes: [Dave Page] Modify the runtime to use time-based timeouts rather than retry based. [Dave Page] Remove change made for debugging and committed in error. ---

Re: [pgAdmin4][Patch]: RM #2556: Runtime connection retry loop timeout

Thanks, applied! On Mon, Jul 17, 2017 at 1:53 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM #2556: Runtime connection retry loop > timeout > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

pgAdmin 4 commit: Remove change made for debugging and committed in err

Remove change made for debugging and committed in error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d04ac7656a33e9076b6e2b68ed51dd60a7e8e820 Modified Files -- runtime/pgAdmin4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 delet

pgAdmin 4 commit: Modify the runtime to use time-based timeouts rather

Modify the runtime to use time-based timeouts rather than retry based. Fixes #2556 This allows for slow vs. fast connection failures (e.g. an active rejection vs. no response). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5461827894bc99a

[RM2544][pgAdmin4] Add SSL database connection support in Regression tests

Hi, PFA patch to add SSL support for database connection. RM#2170 Included test to check if current connection is using SSL or not. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/d

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Mon, Jul 17, 2017 at 4:52 PM, Dave Page wrote: > Hi > > No errors now, but do you know why JS tests are being skipped? > ​No errors/warning in console even after settings `logLevel: config.LOG_DEBUG`. I am still debugging. > > PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 4 of 216 (skipped 212)

[pgAdmin4][Patch]: RM #2556: Runtime connection retry loop timeout

Hi, Please find the attached patch for RM #2556: Runtime connection retry loop timeout Thanks, Khushboo diff --git a/docs/en_US/desktop_deployment.rst b/docs/en_US/desktop_deployment.rst index 9765c77..745b83f 100644 --- a/docs/en_US/desktop_deployment.rst +++ b/docs/en_US/desktop_deployment.rst

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

Thanks, applied with tweaks to the README and removal of yarn.lock - the server uses npm instead of yarn, because of various packaging issues/conflicts with hosting maintenance policy. On Fri, Jul 14, 2017 at 3:38 PM, Sarah McAlear wrote: > Hello Hackers, > > We regenerated the add-readme.diff t

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi No errors now, but do you know why JS tests are being skipped? PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 4 of 216 (skipped 212) SUCCESS (0.085 secs / 0.046 secs) Thanks! On Mon, Jul 17, 2017 at 12:07 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi Dave, > > I didn't remo

Jenkins build is back to normal : pgadmin4-master-python36 #240

See

Jenkins build is back to normal : pgadmin4-master-python33 #243

See

Re: [RM2544][pgAdmin4] Fix for malformed query generated when using custom type

Thanks, applied. On Wed, Jul 12, 2017 at 2:01 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix malformed sql for data type. > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enter

pgAdmin 4 commit: Correct for malformed query generated when using cus

Correct for malformed query generated when using custom type. Fixes #2544 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3942461c502854aa4075da48dd7dea0570df25f5 Author: Harshal Dhumal Modified Files -- .../schemas/types/templat

Build failed in Jenkins: pgadmin4-master-python36 #239

See Changes: [Dave Page] Remove the comma from PIDs in the statistics panel. [Dave Page] Stop tool buttons from changing their styling unexpectedly. Fixes #2559 [Dave Page] Fix handline of large file

Re: [pgAdmin4][Patch]: Minor patch to fix a typo in README

Thanks, applied. On Mon, Jul 17, 2017 at 5:14 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find a minor patch to fix a typo in README. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterp

Build failed in Jenkins: pgadmin4-master-python33 #242

See Changes: [Dave Page] Prevent the tab bar being hidden when detached tabs are being closed. [Dave Page] Remove the comma from PIDs in the statistics panel. [Dave Page] Stop tool buttons from changi

pgAdmin 4 commit: Fix typo

Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=059d671af5b09ffdfa931fd305be8a7aba6f7f68 Author: Khushboo Vashi Modified Files -- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Tidy up tab styling. Fixes #2557

Tidy up tab styling. Fixes #2557 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dc6a1936f5c13002188addc3b67db80e3ccdf659 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp | 43 +++

Re: [pgAdmin4][runtime][Patch]: Fix RM #2557

Thanks, applied. On Fri, Jul 14, 2017 at 12:11 PM, Neel Patel wrote: > Hi, > > Please find attached patch file for the fix of below issue in runtime. > > RM #2557 - UI issues with tabs on secondary windows. > > Do review it and let me know for comments. > > Thanks, > Neel Patel > -- D

Re: Testing out font changes in query editor tool

On Fri, Jul 14, 2017 at 5:06 AM, Murtuza Zabuawala wrote: > Hi Shirley, > > It's easy on the eyes :) > Agreed. As requested, there's a test build for Windows at https://developer.pgadmin.org/~dpage/query_tool_font_test/ -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enterpr

Re: [RM2153][pgAdmin4] handle large file uploads

Thanks, patch applied. On Fri, Jul 14, 2017 at 10:37 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to handle upload of large files and also to > show upload error if > error occurs instead of showing undefined. > > -- > *Harshal Dhumal* > *Sr. S

pgAdmin 4 commit: Fix handline of large file uploads and properly show

Fix handline of large file uploads and properly show any errors that may occur. Fixes #2153 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bbcf0ab364f1ede76da51a1d0d6033799a76d72 Author: Harshal Dhumal Modified Files -- web/pga

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi I'm currently working on first TODO: "Automatically handle static and template JS files" As discussed with Ashesh, currently the paths to module id are written manually in webpack.config.js, instead the path defined in moudle's `def get_own_javascript()` should be used. So, we will be genera

Re: [pgAdmin4][runtime][Patch]: Fix RM #2559

Thanks, applied. On Fri, Jul 14, 2017 at 10:16 AM, Neel Patel wrote: > Hi, > > Please find attached patch file for the fix of below issue in runtime. > > RM #2559 - Toolbuttons ( Back/Forward/Close) on tab become 3D. > > I have tested with all 3 platforms. Do review it and let me know for

pgAdmin 4 commit: Stop tool buttons from changing their styling unexpec

Stop tool buttons from changing their styling unexpectedly. Fixes #2559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dcc74af87b2c9fb9484a9349584c704fd39a8579 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp | 9 --

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

On Mon, Jul 17, 2017 at 3:01 PM, Dave Page wrote: > Hi > > On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> hiHi, >> >> PFA patch to add functionality which will allow super user to cancel long >> running queries from dashboard. >> RM#1812 >> >> *Steps used to tes

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi On Mon, Jul 17, 2017 at 10:31 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jul 17, 2017 at 2:33 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jul 12, 2017 at 1:16 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, On Mon, Jul 17, 2017 at 2:33 PM, Dave Page wrote: > Hi > > On Wed, Jul 12, 2017 at 1:16 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which will add functionality to allow user to comment/uncomment >> code in query editor. >> RM#2456 >> > > This is cool, but I

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Hi On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > hiHi, > > PFA patch to add functionality which will allow super user to cancel long > running queries from dashboard. > RM#1812 > > *Steps used to test:* > 1) Open psql session, Connect to 'test'

Build failed in Jenkins: pgadmin4-master-python36 #238

See Changes: [Dave Page] Show tablespace on partitions. Fixes #2551 [Dave Page] Prevent the tab bar being hidden when detached tabs are being closed. -- [...tru

pgAdmin 4 commit: Remove the comma from PIDs in the statistics panel.

Remove the comma from PIDs in the statistics panel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f83780049ed5fbb95ad26c3659e790622736964 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/statistics/static/js/statist

Re: [pgAdmin4][Patch] Not to display PID comma separated in statistics panel

Thanks, applied. On Thu, Jul 13, 2017 at 12:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where PID column was displaying comma > separated in statistics panel. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.ente

Re: [pgAdmin4][runtime]: Fix RM #2558

Thanks, applied. On Thu, Jul 13, 2017 at 11:09 AM, Neel Patel wrote: > Hi, > > Please find attached patch file for the fix of below issue in runtime. > > RM #2558 - Tab bar on main window vanishes when closing child via > tab button > > I have tested with all 3 platforms. Do review it and

pgAdmin 4 commit: Prevent the tab bar being hidden when detached tabs a

Prevent the tab bar being hidden when detached tabs are being closed. Fixes #2558 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fe0d5192537c0fcd6105d0aafff3ab2cb218273 Author: Neel Patel Modified Files -- runtime/TabWindow.cpp

Re: [RM2544][pgAdmin4] Fix for malformed query generated when using custom type

On Wed, Jul 12, 2017 at 2:01 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix malformed sql for data type. > Can you give me some steps to reproduce this please, as I cannot using either lower or mixed case identifiers. -- Dave Page Blog:

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi On Wed, Jul 12, 2017 at 1:16 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which will add functionality to allow user to comment/uncomment > code in query editor. > RM#2456 > This is cool, but I'm not sure it's right as-is: * I prefer SQL style commen

Re: [pgAdmin4]: Webpacking of static JS/CSS

On Mon, Jul 17, 2017 at 2:15 PM, Dave Page wrote: > Hi > > On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> While this patch is in review, i have not attached patch for "unvendored >> libs" which is around 10MB in size and needs not to revi

pgAdmin 4 commit: Show tablespace on partitions. Fixes #2551

Show tablespace on partitions. Fixes #2551 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07aa74eaf56db72eab55dd735c710a4796abd669 Author: Harshal Dhumal Modified Files -- .../templates/partition/sql/10_plus/create.sql | 8 +

Re: [RM2551][pgAdmin4] show tablespace on partitions.

Thanks, applied. On Wed, Jul 12, 2017 at 11:23 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to show tablespace on partitions. > Also reformatted sql slightly in sql tab. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi On Wed, Jul 12, 2017 at 4:04 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > While this patch is in review, i have not attached patch for "unvendored > libs" which is around 10MB in size and needs not to review. > Attached is the patch which can be reviewed. > > *Changes:

Re: How to modify font size of displayed view?

Yes, one does need the shift key. Nothing happens with a plain cmd+, but cmdShift+ does the trick. On other apps (Terminal for example), the shift is not necessary. (I guess the Terminal developers thought that no-one would use cmd= for anything. To make the font size smaller, cmd- works fin

Re: pgAdmin 4 v1.6 Released!

On Fri, Jul 14, 2017 at 1:58 PM, Pawel Hadam wrote: > Thank you Dave and Khushboo for advises. > > 1) (re)moving 'pgadmin4.db' - did not help. > > 2) I have disabled teredo - did not help. > > 3) localhost is resolved to IPv6 address: > > $ ping localhost > > Pinging ogrodowa [::1] with 32 bytes

Re: pgadmin-for-web is going nowhere

On Fri, Jul 14, 2017 at 7:17 PM, Josh Berkus wrote: > On 07/14/2017 01:01 AM, Dave Page wrote: > > > Setting up in server mode by following those docs takes just a few > minutes. > > > > > > Six months ago, I jumped on this with the goal of solving it, partly > > through use of linux cont