make subnode rows the same height for rows without dropdowns

2017-07-05 Thread George Gelashvili
Hello Hackers, We found that in subnodes without dropdowns, the rows had smaller height, making them appear unintentionally different than those with dropdowns. An example place in the app is Create Table -> Security tab -> add a row for each of Privileges and Security labels. Attached is a fix.

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-05 Thread Matthew Kleiman
Sorry Dave. It looks like we had formatted the patch incorrectly. We have recreated the patch. Matt and Sarah On Wed, Jul 5, 2017 at 10:49 AM, Dave Page wrote: > Hi > > On Wed, Jul 5, 2017 at 2:54 PM, Matthew Kleiman > wrote: > >> 1) I see the font used for class .query-history .entry​ is mono

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-05 Thread Sarah McAlear
Hello, > *​Things to discuss:* > > How to differentiate between a static and template JS > ​​ > . > What is the advantage of webpacking templated JS? It seems as though this creates a system in which the bundled dependencies have to refer back to the backend to load the templates. If there is a

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-05 Thread Dave Page
Hi On Wed, Jul 5, 2017 at 2:54 PM, Matthew Kleiman wrote: > 1) I see the font used for class .query-history .entry​ is monospace, >> shouldn't it be Helvetica as per style guide ? the font for Messages > text >> is also monospace. >> > > As per Dave's comment, we have added this to the styleguid

Build failed in Jenkins: pgadmin4-master-python35 #218

2017-07-05 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow use of Shift+Tab to un-indent selected text. Fixes #1988 -- [...truncated 289.03 KB...] Update materialized view under schema node

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-07-05 Thread Matthew Kleiman
> > 1) I see the font used for class .query-history .entry​ is monospace, > shouldn't it be Helvetica as per style guide ? the font for Messages > text > is also monospace. > As per Dave's comment, we have added this to the styleguide backlog. We will be adding monospace entries to the styleguide

Re: [pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab in query editor

2017-07-05 Thread Dave Page
Thanks - applied, along with a doc update. On Wed, Jul 5, 2017 at 1:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch which will add functionality to allow user to delete > Tab(s) using Shift-Tab keys. > RM#1988 > > -- > Regards, > Murtuza Zabuawala >

pgAdmin 4 commit: Allow use of Shift+Tab to un-indent selected text. Fi

2017-07-05 Thread Dave Page
Allow use of Shift+Tab to un-indent selected text. Fixes #1988 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9de6c08d28ea04dbd83f7f90a2dbfd4063d1780e Author: Murtuza Zabuawala Modified Files -- docs/en_US/keyboard_shortcuts.rst

[pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab in query editor

2017-07-05 Thread Murtuza Zabuawala
Hi, PFA minor patch which will add functionality to allow user to delete Tab(s) using Shift-Tab keys. RM#1988 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/b

Jenkins build is back to normal : pgadmin4-master-python27 #221

2017-07-05 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Fix alert layout when more than one are shown at once

2017-07-05 Thread Dave Page
Fix alert layout when more than one are shown at once. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2bb01e2d1a60df72d2b1569e2de87ba63c831a39 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alert.scss | 2 +-