Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

Hi, Please find the attached updated patch which includes following fixes: 1. The plus button to add a constraint with the domain dialogue doesn't work. 2. The Domain Constraint node doesn't load. 3. On update, the domain constraint node name doesn't change. Thanks, Khushboo On Mon, Jul 3, 201

Jenkins build is back to normal : pgadmin4-master-python33 #212

See

pgAdmin 4 commit: Remove unnecessary whitespace from stored procedure S

Remove unnecessary whitespace from stored procedure SQL. Fixes #2146 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0aa763b70680707136036ed1b7d3f994e70161de Author: Murtuza Zabuawala Modified Files -- .../schemas/functions/templa

Re: [pgAdmin4][Patch] To fix the issue in Debugger & Procedure module for EPAS server

Thanks, applied. On Mon, Jul 3, 2017 at 9:01 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where 'Debug' option was not displaying on > Package -> Function if the user if non-super user. > RM#1948 > > Another minor issue where there was a

pgAdmin 4 commit: Allow debugging of functions in packages. Fixes #1948

Allow debugging of functions in packages. Fixes #1948 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c7dcaba81c55846f5d9a85f1226abdee8cc1856 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/packages/edbf

Build failed in Jenkins: pgadmin4-master-python33 #211

See Changes: [Dave Page] Fix deletion of table rows with the column definition having NOT NULL [Dave Page] Allow breakpoints to be set on triggers on views. Fixes #2528 ---

pgAdmin 4 commit: Allow breakpoints to be set on triggers on views. Fix

Allow breakpoints to be set on triggers on views. Fixes #2528 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=070a9c077ecd0794d66ed625215c9eca5866e0e5 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/debugger/templates/d

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

Thanks, both applied. On Mon, Jul 3, 2017 at 6:09 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 3, 2017 at 11:57 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> 1. When we try to delete the table row with the column definition having

Re: [pgAdmin4]: Webpacking of static JS/CSS

Hi All, *​Things to discuss:* How to differentiate between a static and template JS ​​ . ​In Webpack we have to resolve paths to the modules same as in requirejs.config(base.html). but previously we were using 'current_app.javascripts' which holds the the path references for modules registered.

pgAdmin 4 commit: Fix deletion of table rows with the column definition

Fix deletion of table rows with the column definition having NOT NULL TRUE and HAS NO DEFAULT VALUE. Fixes #2527 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f6b879233c1c9f554a43094e1d82d3e16cff23fa Author: Khushboo Vashi Modified Files -

Jenkins build is back to normal : pgadmin4-master-python34 #201

See

Re: Tree view icon samples

Hi On Mon, Jul 3, 2017 at 10:25 AM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Dave, > > I have updated the icons "Conversions, Function and Function Trigger" as > per you suggestions. > Nice. > > I feel the curved shapes won't look clear in 16px measurement which is > happe

Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

Hi On Mon, Jul 3, 2017 at 6:10 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jul 3, 2017 at 1:10 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> The Domain Constraint module doesn't load as it can not find the >> domain_constraints.js fil

Re: [pgAdmin4][Patch] To fix the issues in Debugger module

Hi On Fri, Jun 30, 2017 at 10:15 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find patch to fix the below issues, > > 1) Debugger page layout > RM#2512 > > 2) To fix the issue when you user clicks on Stop button and gets > connection lost error. > RM#2511 >

pgAdmin 4 commit: Improve the debugger's default page layout, and preve

Improve the debugger's default page layout, and prevent attempts to continue debugging after the user has stopped. Fixes #2512, Fixes #2511 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d5e55964ad811690ac1b52efdc632e8b485e943 Author: Murtuz

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

On Mon, Jul 3, 2017 at 5:36 AM, Dave Page wrote: > > > On Fri, Jun 30, 2017 at 12:19 PM, Shirley Wang wrote: > >> Hello! >> >> Currently the app uses 'monospace' to define the font family for SQL >> queries and messages, which looks a little squished when in uppercase. PT >> mono is another mono

Re: [pgAdmin4][Patch]: Refactor of the History Tab

Hi > 2) Can 1px top border be added above first entry in left panel to > differentiate from above panels ? > > It sounds like you're describing the distinction between the query history entries and the Messages, History, etc. tab bar (screenshot attached). If so, the gray/blue contrast should be s

Re: Tree view icon samples

Hi On Mon, Jul 3, 2017 at 8:53 AM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Dave, > > I am attaching the updated icons along with new icons added. > > Also I have tried to address the issues raised in our previous review - > > 1. Cast and Conversion: Eliminated the texty feel

[pgAdmin4][Patch] To fix the issue in Debugger & Procedure module for EPAS server

Hi, PFA patch to fix the issue where 'Debug' option was not displaying on Package -> Function if the user if non-super user. RM#1948 Another minor issue where there was a whitespace on SQL panel while displaying reversed engineering sql for Procedure. RM#2146 -- Regards, Murtuza Zabuawala Enterp

Build failed in Jenkins: pgadmin4-master-python34 #200

See Changes: [Dave Page] Fix clipboard handling with large datasets. Fixes #2489 -- [...truncated 289.04 KB...] Update materialized view under schema node ... ok

pgAdmin 4 commit: Fix clipboard handling with large datasets. Fixes #24

Fix clipboard handling with large datasets. Fixes #2489 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1977a5fcda44b78b00d6eaac2e6a99df355d5105 Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/selection/clipboard.js

Re: [pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

On Mon, Jul 3, 2017 at 1:10 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The Domain Constraint module doesn't load as it can not find the > domain_constraints.js file. > To fix this issue, renamed the domain_constraint.js to > domain_constraints.js. > > RM #2529

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

On Mon, Jul 3, 2017 at 11:57 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > 1. When we try to delete the table row with the column definition having > NOT NULL TRUE and HAS NO DEFAULT VALUE then it fails. > Please find the attached patch for the same. (delete_row.patch)

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

Can you create some then please? As they're user-visible issues, they should be tracked. On Mon, Jul 3, 2017 at 6:00 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Nope. I found these issues when I tried to reproduce another issue :). > > On Mon, Jul 3, 2017 at 3:29 PM, Dave Page

pgAdmin 4 commit: Fix a syntax error in the SQL Editor.

Fix a syntax error in the SQL Editor. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e21cdb64bc68c20d195a63c17b2f926e75a Author: Harshal Dhumal Modified Files -- web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.j

Re: Patch for sqleditor js syntax issue

Thanks, patch applied. On Fri, Jun 30, 2017 at 3:27 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached minor patch which fixes js syntax issue in > sqleditor.js > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterp

Re: [pgAdmin4][Patch] To fix the duplicate entry in History panel

Thanks, patch applied. On Fri, Jun 30, 2017 at 2:26 PM, George Gelashvili wrote: > Nice! Looks good. We were investigating this bug before you sent this and > it looks like your patch resolves the duplicate calls to > update_msg_history > > Cheers, > Sarah and George > > On Fri, Jun 30, 2017 at

pgAdmin 4 commit: Fix an issue where duplicate entry is made of success

Fix an issue where duplicate entry is made of successful executed query, one with status message and one without status message. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e427890de93f83d2b1ffb0e25b1c6f6d8bd8389 Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

Nope. I found these issues when I tried to reproduce another issue :). On Mon, Jul 3, 2017 at 3:29 PM, Dave Page wrote: > Are there RMs for these? > > On Mon, Jul 3, 2017 at 2:27 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> 1. When we try to delete the table row

Re: [pgAdmin4][Patch]: Fixed couple of minor issues

Are there RMs for these? On Mon, Jul 3, 2017 at 2:27 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > 1. When we try to delete the table row with the column definition having > NOT NULL TRUE and HAS NO DEFAULT VALUE then it fails. > Please find the attached patch for the

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

On Fri, Jun 30, 2017 at 12:19 PM, Shirley Wang wrote: > Hello! > > Currently the app uses 'monospace' to define the font family for SQL > queries and messages, which looks a little squished when in uppercase. PT > mono is another monospaced font (available on Google fonts) that looks > similar to

Re: Tree view icon samples

Hi On Friday, June 30, 2017, Strauch, Sheldon wrote: > Dave et al, > > Might I suggest flipping the foreign key icon left for right? That way, > the key "points" to the left, back toward something pre-existing whilst the > primary key "points" to the right, forward towards something new? > I li

[pgAdmin4][Patch]: Fixed the issue related to Domain Constraint module

Hi, The Domain Constraint module doesn't load as it can not find the domain_constraints.js file. To fix this issue, renamed the domain_constraint.js to domain_constraints.js. Please find the attached fix. diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/domain_cons