Re: Tree view icon samples

2017-06-28 Thread Ashesh Vashi
On Thu, Jun 29, 2017 at 9:09 AM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Ashesh, > > I tried to eliminate the colour blind issue which might occur with the > primary & foregin key icons. > But still I will use the app to test the colors, just let me know your > opinion now. >

Re: Tree view icon samples

2017-06-28 Thread Chethana Kumar
Hi Ashesh, I tried to eliminate the colour blind issue which might occur with the primary & foregin key icons. But still I will use the app to test the colors, just let me know your opinion now. Regards, Chethana kumar On Wed, Jun 28, 2017 at 11:13 PM, Ashesh Vashi < ashesh.va...@enterprisedb.co

Re: Tree view icon samples

2017-06-28 Thread Chethana Kumar
Hi Shirley, I tried installing the app from itunes but it seems like my account is expired and needs payment to be done for re-activation of it. So can anybody please share your account credentials just to install this application for color blind testing. Or do I have any other way to install th

Re: Tree view icon samples

2017-06-28 Thread Robert Eckhardt
That's better. On Wed, Jun 28, 2017 at 10:55 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Robert, > > Please check the icons of Database Disconnected and Database Corrupted, > just let me know if still can't be able to differentiate between > themselves. > > Regards, > Chet

Re: Tree view icon samples

2017-06-28 Thread Chethana Kumar
Hi Robert, Please check the icons of Database Disconnected and Database Corrupted, just let me know if still can't be able to differentiate between themselves. Regards, Chethana kumar On Wed, Jun 28, 2017 at 10:32 PM, Robert Eckhardt wrote: > I like them as well. The only comment I have is tha

Re: [pgadmin-hackers][Patch] Change alert styling

2017-06-28 Thread Dave Page
Hi On Wed, Jun 28, 2017 at 4:40 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > In this patch we are introducing SCSS that we generated for the style > guide. > [image: Inline image 1] > > The patch is split into 2 files: > - 01-add-scss-building-to-webp

Re: Tree view icon samples

2017-06-28 Thread Dave Page
On Wed, Jun 28, 2017 at 3:48 PM, Shirley Wang wrote: > I recommend using Sim Daltonism to test colors! > > https://itunes.apple.com/us/app/sim-daltonism/id693112260?mt=12 > Excellent idea - Chethana, please grab a copy and verify that all icons are distinct when tested for different types of col

Re: Tree view icon samples

2017-06-28 Thread Shirley Wang
I recommend using Sim Daltonism to test colors! https://itunes.apple.com/us/app/sim-daltonism/id693112260?mt=12

Re: Tree view icon samples

2017-06-28 Thread Ashesh Vashi
On Jun 28, 2017 22:32, "Robert Eckhardt" wrote: I like them as well. The only comment I have is that the red icon on disconnected DB and corrupted DB are difficult to make out. They are clearly differentiable but the icon itself is unclear. A colour blind person may not be able to differentiate

Re: Tree view icon samples

2017-06-28 Thread Robert Eckhardt
I like them as well. The only comment I have is that the red icon on disconnected DB and corrupted DB are difficult to make out. They are clearly differentiable but the icon itself is unclear. -- Rob On Wed, Jun 28, 2017 at 12:49 PM, Dave Page wrote: > Hi > > > On 28 Jun 2017, at 12:41, Chethan

Re: Tree view icon samples

2017-06-28 Thread Dave Page
Hi > On 28 Jun 2017, at 12:41, Chethana Kumar > wrote: > > Hi Team, > > I am coming up with some sample icons for Tree View Control. > > Thought process behind the concept - > > 1. Included EDB color brand feel (gray and blue colors) You mean pgAdmin colour brand :-). EDB is orange & black.

Tree view icon samples

2017-06-28 Thread Chethana Kumar
Hi Team, I am coming up with some sample icons for Tree View Control. Thought process behind the concept - 1. Included EDB color brand feel (gray and blue colors) 2. Eliminated the distraction of too many colors and provided consistency through the icons 3. User will recognize the icon shapes ra

Build failed in Jenkins: pgadmin4-master-python35 #205

2017-06-28 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] A number of minor cleanups to the recent changes to the query tool. -- [...truncated 289.00 KB...] Update materialized view under schema

Build failed in Jenkins: pgadmin4-master-python27 #210

2017-06-28 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix encoding issue when saving servers. Fixes #2518 [Dave Page] A number of minor cleanups to the recent changes to the query tool. -- S

Build failed in Jenkins: pgadmin4-master-python35 #204

2017-06-28 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix encoding issue when saving servers. Fixes #2518 -- [...truncated 300.72 KB...] webpack: wait until bundle finished: webpack: wait un

pgAdmin 4 commit: A number of minor cleanups to the recent changes to t

2017-06-28 Thread Dave Page
A number of minor cleanups to the recent changes to the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7389744ecff66cb070c118682992d9c5cb5b04ee Author: Harshal Dhumal Modified Files -- web/pgadmin/feature_tests/view_d

Re: crypto.py bug on server add form (button save) with python 3.5 - Can't convert 'bytes' object to str implicitly

2017-06-28 Thread Dave Page
Thanks, patch applied. On Wed, Jun 28, 2017 at 12:19 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch which will fix the password > encryption/decryption for python3. > I have modified the fix suggested by Ladislav to work with both python2 > a

pgAdmin 4 commit: Fix encoding issue when saving servers. Fixes #2518

2017-06-28 Thread Dave Page
Fix encoding issue when saving servers. Fixes #2518 Patch by Khushboo, based on a suggested fix from Ladislav Jech Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=301798d87a25e7ed2290af909a814a89107fd667 Author: Khushboo Vashi Modified Files

[pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid is extremely slow and fails with large datasets

2017-06-28 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets. Thanks, Khushboo diff --git a/web/pgadmin/static/js/selection/clipboard.js b/web/pgadmin/static/js/selection/clipboard.js index 9794ae7..844e20c 100644 --- a/web/pga