Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

Hi all, We've updated the borders around alerts so that they are more prominent. [image: error alert (1).png] [image: success alert (2).png] [image: Neutral alert.png] Everything else stays the same. Let me know your thoughts if any. Shirley & Shruti On Wed, May 31, 2017 at 3:02 PM Shirley Wang

Build failed in Jenkins: pgadmin4-master-python35 #186

See Changes: [Dave Page] Maintain a client-side cache of preference values, populated using an -- [...truncated 289.08 KB...] Update materialized view under sche

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Looking good. The only issue I found so far occurs if you open the query tool, then immediately click on the history tab: TypeError: Cannot read property 'CodeMirror' of undefined at Object. (sqleditor.js:882) at triggerEvents (backbone.js:208) at Object.trigger (backbone.js:148)

pgAdmin 4 commit: Maintain a client-side cache of preference values, po

Maintain a client-side cache of preference values, populated using an async call. Fixes #2487 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67fd119de834afd022f95c8c153a3b0c8c7b7fae Author: Khushboo Vashi Modified Files -- .../b

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, patch applied! On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi wrote: > Hi, > > Please find attached patch to fix RM #2487: get_preference() uses a > synchronous AJAX request. > > Introduced the client side caching for preferences to get rid of synchronous > AJAX request. > > > Thanks, >

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

Thanks, applied. On Wed, Jun 21, 2017 at 11:25 AM, Murtuza Zabuawala wrote: > Apologies disregard my previous patch also, > > I missed changes in "pga_job.js". > > Thanks to Harshal pointing that out. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Ente

pgAdmin 4 commit: Update MatView and pgAgent modules to work with recen

Update MatView and pgAgent modules to work with recent integer/numeric changes. Fixes #2504 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9f6fb95456a540287ef7aca02ff885068b64cd5 Author: Murtuza Zabuawala Modified Files -- .../

Re: [pgAdmin4][PATCH] To fix the issue in Synonym node

Thanks, applied. On Wed, Jun 21, 2017 at 6:45 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to handle the deleted Synonym node gracefully when user clicks SQL > or Properties Panel. > RM#2503 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise Pos

pgAdmin 4 commit: Handle missing/dropped synonyms gracefully. Fixes #25

Handle missing/dropped synonyms gracefully. Fixes #2503 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9736cbd74c723ce914fa3beaafe03fd284daf45 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/synonyms/__

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi On Wed, Jun 21, 2017 at 3:23 PM, Sarah McAlear wrote: > Hello! > > Thank you for committing the patch! > > We are currently looking into CEF > (https://bitbucket.org/chromiumembedded/cef) as an alternative to QTWebKit. > So far it looks promising. It works on all platforms. It is the base for

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hello! Thank you for committing the patch! We are currently looking into CEF ( https://bitbucket.org/chromiumembedded/cef) as an alternative to QTWebKit. So far it looks promising. It works on all platforms. It is the base for Google Chrome, so it should be maintained for some time to come. Versi

[pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi, Please find attached patch to fix RM #2487: get_preference() uses a synchronous AJAX request. Introduced the client side caching for preferences to get rid of synchronous AJAX request. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/te

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi George On Tue, Jun 20, 2017 at 10:29 PM, George Gelashvili wrote: > We learned that the underlying issue was related to react-dom's > SyntheticEvent.augmentClass function being undefined. > > This seems to be caused by attempted property assignment after the > SyntheticEvent had been replaced

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

Apologies disregard my previous patch also, I missed changes in "pga_job.js". Thanks to Harshal pointing that out. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 3:44 PM, Murtuza Zabuawala < murtuza.zabuaw...@e

pgAdmin 4 commit: Fix React to work with QtWebKit

Fix React to work with QtWebKit We learned that the underlying issue was related to react-dom's SyntheticEvent.augmentClass function being undefined. This seems to be caused by attempted property assignment after the SyntheticEvent had been replaced by a Proxy of itself. This works fine in Chr

pgAdmin 4 commit: Vendorize React. This is required at this time becaus

Vendorize React. This is required at this time because we need to modify it to work with QtWebKit. The patch to do that has been submitted upstream; if accepted, we can un-vendorize again. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a45b

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

Hi, Please ignore previous patch. Attached is the updated patch which includes fixes for Materialized View & pgAgent modules are also included. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 1:54 PM, Murtuza Zabu

Re: [pgAdmin4][PATCH] Consolidating Selection Colors

Thanks, patch applied. On Tue, Jun 20, 2017 at 9:39 PM, Shruti B Iyer wrote: > Hi Hackers! > > Attached is a patch that consolidates selection colors in the drop down menu > and browser tree to match the light blue agreed upon in the styleguide. > > Thanks, > Shirley and Shruti -- Dave Page B

pgAdmin 4 commit: Consolidate selection colors in the drop down menu an

Consolidate selection colors in the drop down menu and browser tree to match the light blue agreed upon in the styleguide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=281b67952a94bc1599536c2b6c469252f233aa69 Author: Shruti B Iyer Modifie

Re: [pgAdmin4][PATCH] To increase the size of Grant Wizard dialog

Thanks, applied. On Tue, Jun 20, 2017 at 5:48 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to make Grant Wizard dialog size larger so that it displays > all the privileges properly when opened in smaller resolution screen. > RM#2013 > > Tested on 1024 x 768 screen resolution. > > -- > R

pgAdmin 4 commit: Increase the default size of the Grant Wizard to enab

Increase the default size of the Grant Wizard to enable it to properly display privileges at the default size on smaller displays. Fixes #2013 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0202228d0820e27645e05c73908352b58c8c30f Author: Mur

Build failed in Jenkins: pgadmin4-master-python27-feature #6

See -- [...truncated 82.62 KB...] File "

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

Hi Murtuza, It seems like 'integer' control is replaced by 'numeric' control. Can you find and replace type: 'integer' to 'numeric' wherever necessary ? On Wed, Jun 21, 2017 at 1:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue wh

Build failed in Jenkins: pgadmin4-master-python27-feature #5

See -- [...truncated 36.31 KB...] runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest) Tests the path through the query tool ... ok runTest (pgadmi

[pgAdmin4][PATCH] To fix the issue in Materialized View

Hi, PFA minor patch to fix the issue where create dialog opens blank due to JS error. RM#2504 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/views/templates/mview/j