Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Barry Smith
Great, thanks for your patience and for testing out the new "improved" Fortran interfaces. > On Jun 26, 2024, at 11: 44 PM, Adrian Croucher wrote: > > Thanks very much Barry, that seems to have fixed ZjQcmQRYFpfptBannerStart This Message Is From an External Sender

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Adrian Croucher
Thanks very much Barry, that seems to have fixed it. My code runs again now. - Adrian On 27/06/24 3: 20 pm, Barry Smith wrote: > > I determined the problem. I had not updated PetscLayout to type(tPetscLayout) so its initial value was indeterminate ZjQcmQRYFpfptBannerStart

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Barry Smith
I determined the problem. I had not updated PetscLayout to type(tPetscLayout) so its initial value was indeterminate thus causing the problem. I rebased the branch, so you must delete it and check it out again. Sorry I also permanently added ZjQcmQRYFpfptBannerStart Thi

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Adrian Croucher
PS, I also just tried adding that line to src/dm/imps/plex/tests/ex26f90. F90 using an earlier version of PETSc (before the Fortran interface changes) and that did run ok. - Adrian -- Dr Adrian Croucher Senior Research Fellow Department of Engineering ZjQcmQRYFpfptBannerStart

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Adrian Croucher
On 27/06/24 2: 30 pm, Barry Smith wrote: > >   Can you add > > PetscCallA(PetscSectionGetValueLayout(PETSC_COMM_WORLD, section, > layout, ierr)) > > to line 276 of src/dm/imps/plex/tests/ex26f90. F90 and see if it runs ok? ZjQcmQRYFpfptBannerStart This Message Is From a

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Barry Smith
Can you add PetscCallA(PetscSectionGetValueLayout(PETSC_COMM_WORLD, section, layout, ierr)) to line 276 of src/dm/imps/plex/tests/ex26f90.F90 and see if it runs ok? Are you initializing layout or doing anything to it before your call to PetscSectionGetValueLayout()? > On Jun 26, 2024, at 9

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Adrian Croucher
hi Barry, On 27/06/24 4:46 am, Barry Smith wrote: Another issue arising from the tighter type checking. I have fixed the issue in the branch, again I rebased the branch so you cannot just git pull it (sorry). Thanks, that has fixed that issue. Now it seems another one is popping up with Pets

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-26 Thread Barry Smith
Another issue arising from the tighter type checking. I have fixed the issue in the branch, again I rebased the branch so you cannot just git pull it (sorry). Also you will now need to change PETSC_NULL_OBJECT with PETSC_NULL_MAT for the second ZjQcmQRYFpfptBannerStart

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-23 Thread Adrian Croucher
hi Barry, I tried pushing the branch of my code that contains the commits needed for your Fortran interface changes up to Github so it would try building it on the CI pipeline - so a completely clean VM with just a single fresh build of PETSc ZjQcmQRYFpfptBannerStart Th

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-21 Thread Barry Smith
This is puzzling since I think the usage in your code is pretty much the same as the usage in ex1f. F90. Are you sure you are compiling and linking your code against your latest PETSc build in this branch? In particular, remove any generated ZjQcmQRYFpfptBannerStart Thi

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-20 Thread Adrian Croucher
hi Barry, On 21/06/24 10: 54 am, Barry Smith wrote: > >   Can you get (again) the latest of the branch and try > src/snes/tests/ex1f. F90 with the option -snes_fd_coloring and see if > it works? > >   Its funny my change broke ZjQcmQRYFpfptBannerStart This Message Is Fr

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-20 Thread Barry Smith
Can you get (again) the latest of the branch and try src/snes/tests/ex1f.F90 with the option -snes_fd_coloring and see if it works? Its funny my change broke your code since ex1f.F90 works for me. Barry > On Jun 20, 2024, at 6:41 PM, Adrian Croucher > wrote: > > hi Satish, > > On 2

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-20 Thread Adrian Croucher
hi Satish, On 21/06/24 1:37 am, Satish Balay wrote: To make sure - I would just do: git fetch git checkout origin/barry/2024-06-14/fix-fortransnessetjacobianmatfdcoloring And I see the following (latest) hash: $ git show -q commit d8404dd8eec4fc8ef95e7bfda269d9da2efce085 (HEAD, origin/barry/

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-20 Thread Satish Balay
On Thu, 20 Jun 2024, Adrian Croucher wrote: > (though it is a bit hard to tell since it's been rebased). To make sure - I would just do: git fetch git checkout origin/barry/2024-06-14/fix-fortransnessetjacobianmatfdcoloring And I see the ZjQcmQRYFpfptBannerStart This Me

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-19 Thread Adrian Croucher
hi Barry, Thanks for that. I deleted the branch and checked it out again as you suggested, did make clean and rebuilt everything, then rebuilt my code. It has fixed the second problem (build error calling SNESSetJacobian()) but now I am getting the original problem back again (run-time error

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-19 Thread Barry Smith
Adrian, Sorry for the delay. I think it is now fixed in the branch Since I rebased the branch it is simplest if you do in the PETSc directory git checkout main git fetch git branch -D barry/2024-06-14/fix-fortransnessetjacobianmatfdcoloring git checkout barry/2024-06-1

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-16 Thread Adrian Croucher
hi Barry, On 15/06/24 7:56 am, Barry Smith wrote:    Thanks for reporting the problem. It was an oversight on my part when working on the Fortran interfaces.     It should work now in https://urldefense.us/v3/__https://gitlab.com/petsc/petsc/-/merge_requests/7631__;!!G_uCfscf7eWS!fA-CO1ZKRn

Re: [petsc-dev] New error in SNESComputeJacobianDefaultColor()

2024-06-14 Thread Barry Smith
Thanks for reporting the problem. It was an oversight on my part when working on the Fortran interfaces. It should work now in https://urldefense.us/v3/__https://gitlab.com/petsc/petsc/-/merge_requests/7631__;!!G_uCfscf7eWS!dg1VE_-LFuCOw2KepU4EUKsswe4d7-N2rZHG1bsWJlD6KgUFfnrrr6KavG3Da50X