Moritz Lenz via RT wrote:
On Sun Aug 24 03:59:15 2008, bacek wrote:
Hello.
There is almost copy-pasted version of rindex.
... which breaks the build for me (after a realclean):
Or do I have to run some other commands except Configure.pl && make?
You probably missed second diff from patch.
Will Coleda wrote:
On Thu, Sep 11, 2008 at 8:11 AM, James E Keenan <[EMAIL PROTECTED]> wrote:
Is it just me ...?
Yup.
When I went to rt.perl.org just now to reply to a ticket, I could not find
the toggle for automatically CC-ing [EMAIL PROTECTED] I know it was
there just last night. I am
Will Coleda wrote:
Now that we can subclass PMCs with Objects, we need to go through all
the code in src/pmc/*.pmc that directly fiddles with PMC guts (e.g.
PMC_int_val(...) and PMC_num_val(...) and replace them with VTABLE
accessor methods, or constructs like SELF.get_integer().
Just for clar
chromatic wrote:
Just for clarification, it attached patch is actually what this ticket
about?
Yes, that's correct.
Ok, so I go ahead and try to fix more pmcs. There is single line patch
for float.
--
Bacek
diff --git a/src/pmc/float.pmc b/src/pmc/float.pmc
index d315627..fa03356 100644
--
INTERP, arg);
}
commit 377da82bd0a527193d684dc211007839785f2409
Author: Vasily Chekalkin <[EMAIL PROTECTED](none)>
Date: Sat Sep 13 10:05:30 2008 +1000
Use less PMC_str_val in favour of VTABLE_get_string. Replace VTABLE_get_string(INTERP, SELF) with SELF.get_string() for readablity sake
dif
Hello.
Another question: there is a lot of PMC_\S+_val accesses to Key pmc.
Should they be replaced with VTABLE analogues as well? Or Key isn't
supposed to be inherited by some other class and it will only sacrifice
performance?
--
Bacek.
chromatic wrote:
On Saturday 13 September 2008 04:51:04 Vasily Chekalkin wrote:
Another question: there is a lot of PMC_\S+_val accesses to Key pmc.
Should they be replaced with VTABLE analogues as well? Or Key isn't
supposed to be inherited by some other class and it will only sacr
NotFound wrote:
+=item C
+
+Removes the element at C.
+
+=cut
+
+*/
+
+VTABLE void delete_keyed_int(INTVAL key) {
+INTVAL size = PMC_int_val(SELF);
With the use of the set_integer_native entry later, this should probably be:
INTVAL size = SELF.get_integer();
I borrowed it f
NotFound wrote:
Patches to bigint, complex, float and string applied in r31370, thanks.
Thanks. There is little bit more patches.
Just replacing most obvious calls.
--
Bacek
diff --git a/src/pmc/bigint.pmc b/src/pmc/bigint.pmc
index 0c00f18..b94d513 100644
--- a/src/pmc/bigint.pmc
+++ b/src/
Patrick R. Michaud via RT wrote:
On Thu, Sep 25, 2008 at 05:05:16AM -0700, Vasily Chekalkin via RT wrote:
This bug caused by "runops_args" which doesn't populcate
interp->current_args which used in "mmd_arg_tuple_func" to calculate
signature for MMD.
chromatic
chromatic wrote:
On Wednesday 22 October 2008 09:28:38 Bernhard Schmalhofer via RT wrote:
Does this mean that this ticket can be closed and the deprecation item
in DEPRECATED.pod be removed?
Not until we apply this patch and all tests still pass.
Looks like you've missed few lines from this
chromatic wrote:
On Wednesday 22 October 2008 09:28:38 Bernhard Schmalhofer via RT wrote:
Does this mean that this ticket can be closed and the deprecation item
in DEPRECATED.pod be removed?
Not until we apply this patch and all tests still pass.
Looks like you missed few lines from this p
Andrew Whitworth wrote:
Since I'm monkeying around in the relevant code anyway, this might be
a good task for the next calling_conventions branch. Or, if you
prefer, we could create a second branch for this conversion and do the
work there.
Looks like it can be part of lex2 branch.
--
Bacek
chromatic wrote:
On Thursday 20 November 2008 00:21:01 Andreas J. Koenig via RT wrote:
According to examples/benchmarks/primes2.pir there was a nearly 30x
slowdown in the last weeks. Two random data points:
https://svn.perl.org/parrot/[EMAIL PROTECTED] was fast (~ 8 secs)
https://svn.perl.org/
Hello.
There is patch for src/pmc/integer.pmc which changes usage of
PMC_int_val to SELF.get_integer() for fetching value.
--
Bacek.
Index: src/pmc/integer.pmc
===
--- src/pmc/integer.pmc (revision 27652)
+++ src/pmc/integer.pmc (
Ivan B. Serezhkin wrote:
Hello.
I think i can fix this.
But please say, is it correct if in Class pmc be array of all it
subclasses depth 1 ?
And anytime when class reinstantiate it reinstantiates all of it
subclass and remove links to subclasses on old Class?
/join #parrot
:)
--
Bacek
chromatic wrote:
There is little bit different patch for it.
--- a/src/exceptions.c
+++ b/src/exceptions.c
@@ -772,7 +772,9 @@ associated exceptions free list for the specified
interpreter.
void
destroy_exception_list(PARROT_INTERP)
{
-really_destroy_exception_list(interp->exceptions);
jerry gay wrote:
would you reformat this in universal diff format please? my patch
program doesn't speak git.
Strange... It is 'universal diff' format. Can be applied with
'patch -p1 < eval.diff' in top-level parrot directory. Or with
'patch -p3 < eval.diff' in languages/perl6.
Anyway, attache
jerry gay wrote:
On Wed, Jun 4, 2008 at 2:46 PM, Moritz Lenz <[EMAIL PROTECTED]> wrote:
Oops, forgot to attach patch. Now it's really there.
thanks, applied as of r28074.
~jerry
This is wrong patch. eval() shouldn't throws any exceptions.
Correct patch for 'eval()' and Test.pm attached.
-
Patrick R. Michaud wrote:
I'll either adjust the C node to have a 'false value returns'
attribute, or move it entirely into the Perl 6 compiler.
+1 for 'move entirely'. It's very Perl6 specific behavior.
--
Bacek
Hello.
There is patch that fixes this error (and makes first 6 tests from
S06/slurpy-params.t passing). Unfortunately it triggers bug from #58718
--
Bacek.
diff --git a/languages/perl6/src/parser/actions.pm b/languages/perl6/src/parser/actions.pm
index 349f433..27ddcd0 100644
--- a/languages/per
Hello.
This is parsing bug.
"say defined $a and defined %b{$a}" parsed as "(say defined $a) and
defined %b{$a}"
--
Bacek.
Hello.
This bug caused by "runops_args" which doesn't populcate
interp->current_args which used in "mmd_arg_tuple_func" to calculate
signature for MMD.
--
Bacek.
There is a patch for src/pmc/integer.pm to use SELF.get_integer()
instead of PMC_int_val.
Index: src/pmc/integer.pmc
===
--- src/pmc/integer.pmc (revision 27652)
+++ src/pmc/integer.pmc (working copy)
@@ -200,7 +200,7 @@
*/
V
On Mon Oct 22 05:22:23 2007, pcoch wrote:
> In src/pmc/integer.pmc:add() there is the todo item:
>
> * TODO
> * check for exact Integer type
> * e.g. MMD_Integer_EXACT
>
> This needs to be implemented.
Is it still should be done? Or just use SELF.get_integer()?
--
Bacek.
On Tue May 20 23:20:41 2008, bacek wrote:
> There is another implementation based on FixedPMCArray.
Reworked version of patch after Jonathan review of old one.
--
Bacek
Index: src/classes/List.pir
===
--- src/classes/List.pir (revi
On Tue May 20 05:53:16 2008, bacek wrote:
> Hello.
>
> There is initial implementation of sort for Lists. Only
> src/classes/List.pir affected.
There is another implementation based on FixedPMCArray.
--
Bacek
sort.diff
Description: Binary data
On Tue May 20 13:18:36 2008, [EMAIL PROTECTED] wrote:
>
> This is correct. PMC_*_val must die.
I've created patch with replacing PMC_int_val with SELF.get_integer().
It's attached to ticket as integer2.diff
--
Bacek.
On Fri Jun 06 01:07:56 2008, bacek wrote:
> Hello.
New version of fix after jonathan comments.
--
Bacek.
range2.diff
Description: Binary data
On Fri Jun 06 20:11:36 2008, particle wrote:
(Sorry for spam if any. Looks like my message was rejected by mailman.)
eval() shouldn't throws any exceptions.
Correct patch for 'eval()' and Test.pm attached.
--
Bacek.
===
--- Test.pm (orig)
+++ Te
On Sun Jun 08 23:14:00 2008, bacek wrote:
> Hello.
>
> MMD try to deref parameters during dispatch.
>
Trivial patch attached.
--
Bacek.
--- a/src/mmd.c
+++ b/src/mmd.c
@@ -1265,7 +1265,10 @@
arg = constants[idx]->u.key;
else
arg =
31 matches
Mail list logo
