I just ran purify against the current Parrot CVS as of today at 10 AM PDT.
Here are the results:
jwilmes@jwilmes-sun:/apps/users/jwilmes/devel/parrot$ ./test_prog test.pbc
Purify instrumented test_prog (pid 2187 at Wed Sep 12 10:05:34 2001)
* Purify 5.2 Solaris 2 (32-bit), Copyright (C)
FYI..
There are a few interesting things in here which look like they may be
real errors. (i'd ignore the PLKs for now)
--Josh
perl assemble.pl t/test.pasm > t/test.pbc
./test_prog t/test.pbc > t/test.out
Purify instrumented test_prog (pid 17982 at Thu Sep 13 02:08:41 2001)
* Purify
> wrote:
> On Thu, Sep 13, 2001 at 02:21:16AM -0700, Josh Wilmes wrote:
> > There are a few interesting things in here which look like they may be
> > real errors. (i'd ignore the PLKs for now)
>
> Thanks for doing this, but to be honest, I expect our memory alloc
This time i've filtered out all the memory leak related data so all that
shows up are legitimate errors. (hopefully)
I have set up a cheesy script to update the following URL with the current output
of purify on the current CVS test_prog (test,test2,test3,euclid) every hour.
http://www.hitchh
s only running every day. Can we get it to
> run every hour? Perhaps even on demand? I think I have fixed all of the
> memory access errors but one.
>
> -Original Message-
> From: Josh Wilmes
> To: [EMAIL PROTECTED]
> Sent: 9/15/2001 5:16 PM
> Subject: "A
ote:
> The hourly should be fine...can you do me one other favor and run the
> following c snippet through Purify:
>
> int main() {
> char* c = (char*)malloc(0);
> printf( "%.*s\n", 0, c );
> return 0;
> }
>
> -Original Message-
> From:
At 1:30 on 09/18/2001 BST, Simon Cozens <[EMAIL PROTECTED]> wrote:
> On Mon, Sep 17, 2001 at 10:38:35AM -0500, Jonathan Scott Duff wrote:
> > Parrot/Opcode.pm only uses Digest::MD5 for fingerprinting the opcode
> > file which could be done without Digest::MD5 IMHO. For instance,
> > using unpack
solaris 2.7
--Josh
At 0:13 on 09/19/2001 CDT, Gibbs Tanton - tgibbs <[EMAIL PROTECTED]> wrote:
> What type of machine is the hourly purify running on. It keeps dieing with
> a SIGBUS on most set_n_nc calls (meaning invalid alignment). This is really
> bad. I would like to know the type of a
This patch adds Dan Sugalski's explanation to the code.
Index: memory.c
===
RCS file: /home/perlcvs/parrot/memory.c,v
retrieving revision 1.9
diff -u -r1.9 memory.c
--- memory.c2001/09/16 01:45:51 1.9
+++ memory.c2001/09
At 13:16 on 09/21/2001 EDT, Uri Guttman <[EMAIL PROTECTED]> wrote:
> > "DS" == Dan Sugalski <[EMAIL PROTECTED]> writes:
>
> DS> At 09:37 AM 9/21/2001 -0400, Gregor N. Purdy wrote:
> >> The names are unique in the first 31 chars. Are we OK, or do I need
> >> to mangle the names? I could
We could use the bsd gettext though, couldn't we?
--Josh
At 12:49 on 09/24/2001 PDT, "Wizard" <[EMAIL PROTECTED]> wrote:
> Michael Maraist wrote:
> > But wouldn't that make parrot GPL'd?
> Yes, Yes it would.
> (cup o' coffee and a sux donut, please.)
> Never mind. I'll take a look at the docs
Here's a fixed version of that patch I sent a while back:
Index: Parrot/Opcode.pm
===
RCS file: /home/perlcvs/parrot/Parrot/Opcode.pm,v
retrieving revision 1.7
diff -u -r1.7 Opcode.pm
--- Parrot/Opcode.pm2001/09/20 14:39:17
e being ignored (either casting to void
or doing something with them)
- cast IVs to (unsigned int) when printfing them with "%x".
- remove unused variables (only in one function)
- return a value in some places where there was a void return but the
function had a retur
What's the state of the coding standards? This is the last draft of it
i've noticed in the archives:
http://www.mail-archive.com/perl6-internals%40perl.org/msg03422.html
Is this going to become a PDD or at least move into the doc directory for
parrot?
--Josh
--
Josh Wilme
er than
quieting up lint, though. It'd feel a little less silly if i was only
casting in one direction. Is there a reason not to convert the memory
subsystem to use size_t for all its length parameters?
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Here's a replacement for my previous patch. This one includes the
following:
Makefile target for "lint" (runs lclint with some very permissive settings)
Fixes some ignored return values
A few minor casts.
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www
It seems to me that we should look at cons before writing Yet Another Perl
Build System. (i haven't used it myself, so I don;'t know if it's good
or not). For reference: http://www.dsmit.com/cons/
--Josh
At 12:18 on 10/11/2001 PDT, Robert Spier <[EMAIL PROTECTED]> wrote:
>
> | I'm OK req
If anyone is interested in a non-IRC discussion system, there's something
I use called lily. Its main feature for this sort of thing is that it
does server-side logging of discussions and allows you to detach and
"review" what you've missed.
If anyone is interested, the URL to sign up is
ht
length(s)) {
+printf("%.*s",(int)string_length(s),(char *) s->bufstart);
+ }
}
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Here are a few of the more clear-cut fixes I noticed from -Wall's whinings.
Index: key.c
===
RCS file: /home/perlcvs/parrot/key.c,v
retrieving revision 1.2
diff -u -r1.2 key.c
- --- key.c 12 Dec 2001 02:52:52 - 1.2
+++
Oops. Sorry, i'll attach it next time.
--Josh
At 11:10 on 12/13/2001 EST, Dan Sugalski <[EMAIL PROTECTED]> wrote:
> At 11:33 PM 12/12/2001 -0500, Josh Wilmes wrote:
> >Here are a few of the more clear-cut fixes I noticed from -Wall's whinings.
>
> Applied,
I'm no sure if i've submitted some of these before, but here goes.
Diffs against current cvs:
Index: Configure.pl
===
RCS file: /home/perlcvs/parrot/Configure.pl,v
retrieving revision 1.39
diff -u -r1.39 Configure.pl
--- Configure.
This makes it pass podchecker and look more aesthetically pleasing.
Index: core.ops
===
RCS file: /home/perlcvs/parrot/core.ops,v
retrieving revision 1.53
diff -u -r1.53 core.ops
--- core.ops20 Dec 2001 01:53:14 - 1.53
gcc users.
Here they are (attached):
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Index: Configure.pl
===
RCS file: /home/perlcvs/parrot/Configure.pl,v
retrieving revision 1.44
diff -u -r1.44 Co
At 13:36 on 12/31/2001 GMT, Simon Cozens <[EMAIL PROTECTED]> wrote:
> You are, of course, correct. gcc is a lot laxer than many other compilers,
> so we want to get away with as little as possible. -Wall should be default
> for gcc. (And please remember that not every compiler supports -Wall, so
This silences these warnings:
test_main.c: In function `main':
test_main.c:165: warning: passing arg 6 of `mmap' with different width due to p
rototype
pdump.c: In function `main':
pdump.c:55: warning: passing arg 2 of `mmap' as unsigned due to prototype
pdump.c:55: warning: passing arg 6 of `mm
I don't know if these functions might be obsolete, but here's a
simple patch to add the missing prototypes if they are not.
Fixes this warning:
register.c:429: warning: no previous prototype for `Parrot_push_on_stack'
register.c:436: warning: no previous prototype for `Parrot_pop_off_stack'
In
This patch changes the makefiles to call LD rather than CC where
appropriate.
This doesn't address the linking of shared libs. I'll look into that next.
Index: Configure.pl
===
RCS file: /home/perlcvs/parrot/Configure.pl,v
retrie
Huh- this sneaked into my patch. Looks like docs/Makefile should be removed
from CVS, since it's autogenerated now.
--Josh
> Index: docs/Makefile
> ===
> RCS file: /home/perlcvs/parrot/docs/Makefile,v
> retrieving revision 1.4
>
I'm fiddling with a compiler called tcc (i'll add it to tinderbox
shortly). It was complaining that struct _vtable was not completely
defined while building one of the test programs in Configure.pl. It was
right- at that point we generate an empty version of vtable.h, so this
struct isn't d
oes its own checking for such things, it may be
interesting to try this out. I'm not too clear on how well it would actually
work. Seems interesting in concept though.
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Index: classes/.cvsignore
===
RCS file: /home/perlcvs/parrot/classes/.cvsignore,v
retrieving revision 1.2
diff -u -r1.2 .cvsignore
--- classes/.cvsignore 11 Dec 2001 12:03:23 - 1.2
+++ classes/.cvsignore 5 Jan 2002 06:29:2
With these, it at least compiles. Lots of warnings, and a few test
failures. Note that I do not have that much confidence in my lcc
installation. It failed some of its own tests. When I have time, i'll
reinstall and see if I can figure out what's wrong.
Index: classes/perlhash.pmc
==
I'll see what I can do as far as upgrading my lcc installation or
reporting this as a bug to the lcc people. But for now, here is a
workaround for this error, just to get the tinderbox going again:
lcc -I./include -DHAS_JIT -o test_main.o -c test_main.c
/tmp/lcc62401.s: Assembler messages:
/
Who is the keeper of the FAQ? This is gold.
--Josh
--- Forwarded Messages
Date:Thu, 24 Jan 2002 12:35:05 -0800
From:"Brent Dax" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>, <[EMAIL PROTECTED]>
Subject: RE: How Powerful Is Parrot?
[EMAIL PROTECTED]:
# I've been watching the P
.
If anyone figures out the proper way to cast these function pointers this
may not be necessary.
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Index: Configure.pl
===
RCS file: /home/perlcvs/parrot
I think your suggestions sound pretty good to me.Personally, i'd lean
towards possibility 2, since 1 is doable if you plan for 2, but not
necessarily vice-versa.
Otherwise I think your proposal sounds good. But then again i'm nobody ;)
--Josh
At 23:24 on 02/03/2002 GMT, [EMAIL PROTECTED
is doesn't look at macros, includes, and the like- just
symbols in the object files.
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Index: Makefile.in
===
RCS file: /home/perlcvs/parrot/Makefile.in,v
retr
d'
I don't want to blindly cast this without understanding what the intent
was.
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
tcc is a rather picky compiler. It found the following:
"warnings.c", line 61: Error:
[ISO 5.1.1.2]: File does not end in newline character.
"misc.c", line 163: Error:
[Syntax]: Parse error before '/'.
"misc.c", line 541: Error:
[ISO 6.1.4]: End of line in string literal.
Her
At 8:42 on 02/06/2002 PST, "Brent Dax" <[EMAIL PROTECTED]> wrote:
> Andy Dougherty:
> # On Wed, 6 Feb 2002, Mattia Barbon wrote:
> # > Probably not: IIRC the standard requires the parts inside
> # > #if 0/#endif to be tokenizable.
> #
> # If I recall correctly, some AIX compilers will complain ab
At 22:37 on 02/06/2002 EST, Jason Gloudon <[EMAIL PROTECTED]> wrote:
> On Wed, Feb 06, 2002 at 12:09:22PM -0800, Steve Fink wrote:
>
> > but I think that's because re_backtrack returns a void*. run_native()
> > returns an opcode_t*, which is fine for the regular core_ops.c but
> > gets returned
I've updated the script to also support scanning the source using the
"cxref" tool.
Here's an updated version of the script and patch. The output looks like
this:
perl lib_deps.pl object exceptions.o global_setup.o interpreter.o parrot.o register.o
core_ops.o core_ops_prederef.o memory.o pa
return (opcode_t*) interpreter->code->byte_code + offset_in_ops;
}
-static inline void** opcode_to_prederef(struct Parrot_Interp* interpreter,
+static void** opcode_to_prederef(struct Parrot_Interp* interpreter,
opcode_t* opcode_addr)
{
ssize_t offset_in_ops;
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
This patch removes unnecessary function pointer conversions (which have
undefined behavior in ANSI C). This gets rid of several warnings encountered
with the lcc compiler and isolates our function pointer misbehavior to
only the jit code.
--Josh
Index: core.ops
=
al_exception(int exitcode, const char * format, ... );
+void do_panic(struct Parrot_Interp *interpreter, char *message, char *file, int line);
#define PANIC(message)\
do_panic(interpreter, message, __FILE__, __LINE__)
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Oops, my patch introduced some more warnings in other files. Here's a
fixed version.
Index: exceptions.c
===
RCS file: /home/perlcvs/parrot/exceptions.c,v
retrieving revision 1.2
diff -u -r1.2 exceptions.c
--- exceptions.c1
Fixes some bad returns, some unused variables, and some mismatched formats.
This should be distinct from my other pending patch, which changes the way
function pointers are handled outside of the JIT.
--Josh
Index: embed.c
===
RC
At 22:02 on 02/15/2002 PST, "Brent Dax" <[EMAIL PROTECTED]> wrote:
> # +++ misc.c 16 Feb 2002 05:36:46 -
> It's not indenting the nested switch() statements the same as their
> matched break;s.
Hrm. It _should_ be indented OK.. not sure what happened there- can
whoever applies the patch
array.pmc: (in function Parrot_Array_move_to)
array.pmc:70:18: Stack-allocated storage pmc->data reachable from parameter pmc
A stack reference is pointed to by an external reference when the function
returns. The stack-allocated storage is destroyed after the call, leaving a
dangling refer
This patch rolls up all my current patches which haven't yet been applied:
- add makefile target and script to test for external libc dependencies
- fix return values in hash and array PMCs (returning 0 in a void func)
- remove unnecessary data pointer <=> function pointer conversions
Bravo!
PDD 7 (coding standards) is also still MIA, although i understand that it's
basically complete.
--Josh
At 16:18 on 02/17/2002 GMT, Simon Cozens <[EMAIL PROTECTED]> wrote:
> I was just starting to think about writing something on the history and
> evolution of Parrot's design, and came
Daniel,
I've actually got something equivalent for the inline portion of your
patch in the patch I just sent to the list.
As far as the ssize_t part, yeah, this probably belongs in config.h_in or
parrot.h or something.
--Josh
At 0:30 on 02/18/2002 +0100, "Ritz Daniel" <[EMAIL PROTECTED]> wr
Sorry, I goofed on that last patch- corrected version (including rx.h this
time):
[josh-002.patch]
This patch rolls up all my current outstanding patches.
- add makefile target and script to test for external libc dependencies
- fix return values in hash and array PMCs (returning 0 in a
[josh-003.patch]
This patch adds some missing const's to silence a number of gcc warnings.
--Josh
Index: include/parrot/warnings.h
===
RCS file: /home/perlcvs/parrot/include/parrot/warnings.h,v
retrieving revision 1.1
diff -u -r1
At 8:24 on 02/18/2002 GMT, Simon Cozens <[EMAIL PROTECTED]> wrote:
> Josh Wilmes:
> > This patch rolls up all my current outstanding patches.
>
> Cool, applied. Although I killed libdeps; I assume you didn't want
> that in there. (Since there's no patch to
Fixes the following (lcc) warnings:
- interpreter.c:470: warning: expression with no effect elided
(related to the way warnings flags were defined)
- misc.c:352: warning: unreachable code
misc.c:483: warning: unreachable code
(i introduced these with some overzealous de
The "inline" bit of that patch was no longer needed, and the ssize_t thing
really shouldn't be needed either.
Here's a patch to simplify things:
[josh-006.patch]
Index: lib/Parrot/OpTrans/CPrederef.pm
===
RCS file: /home/perlcvs/
This patch adds a new Makefile target called "check_source". This target
scans all the .c and .h files in the directory and checks for conformance to
a number of the standards outlined in PDD 7.
--Josh
[josh-007.patch]
Index: MANIFEST
=
This patch removes cuddled elses, as required by PDD 7.
[josh-008.patch]
Index: jit.c
===
RCS file: /home/perlcvs/parrot/jit.c,v
retrieving revision 1.12
diff -u -r1.12 jit.c
--- jit.c 29 Jan 2002 14:05:31 - 1.12
+++
Any chance of getting this in some time soon? The key.c part of it fixes
the broken tcc (and probably lcc) builds. All tests passed with tcc for
me, which is neat.
--Josh
At 21:06 on 02/18/2002 GMT, Jonathan Stowe <[EMAIL PROTECTED]> wrote:
> On Mon, 18 Feb 2002, Dan Sugalski wrote:
>
> >
At 0:39 on 02/21/2002 +0100, "Ritz Daniel" <[EMAIL PROTECTED]> wrote:
> - add a O_BINARY flag to open() in pdump.c, embed.c (required by bcc)
> - define O_BINARY 0 when it's not defined (win32 knows it, linux not)
Offhand, i'm wondering if it wouldn't be better to make these files use
the Par
This is the key.c portion of Jonathan Stowe <[EMAIL PROTECTED]>'s patch
from <[EMAIL PROTECTED]>
Although there's more work being done on the key stuff and this isn't the
final fix, applying this patch does get parrot to build with two more
compilers, so it's probably worthwhile.
[josh-009.pat
Good stuff! However, regarding the function pointer thing, i've got compilers
(tcc and lcc) which disagree with you.
Using NULL where a function pointer is expected is considered an error by
tcc, and a mandatory warning by lcc. It is my understanding that conversion
between data pointers and
C *
)' and 'unsigned char ( struct Parrot_Interp *, struct PMC * )' are incompatible.
[ISO 6.3.4]: Types in pointer conversion should be compatible.
[ISO 6.3.16]: Can't perform this conversion by assignment.
[ISO 6.5.7]: Initializers are converted as if by assignment.
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
3.0 => "-Wformat-nonliteral -Wformat-security -Wpacked -Wpadded
-Wdisabled-optimization",
# -Wsequence-point is part of -Wall
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
At 6:57 on 02/23/2002 CST, Brian Lee Ray <[EMAIL PROTECTED]> wrote:
> However, a null pointer constant, expressed as either 0 or (void*)0 (and the
> definition of NULL must be one of the above), can be safely compared with
> or assigned to either a function pointer or a data pointer. Consider t
This patch adds a script called "run_indent.pl" which runs the GNU indent
program to reformat code to conform to PDD 7. It also patches PDD 7 to
reflect what is being done.
[josh-011.patch]
Index: MANIFEST
===
RCS file: /home/perl
did something very odd to the switch cases in packfile.c.
- global_setup.c got real ugly.
Yes, this will cause headaches and giant diffs (approx 11000 lines) but if not
now, when? On the plus side, it cuts down the errors from "make check_source"
by 162..
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
}
+
check_source($file, \@lines);
}
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
At 21:14 on 02/23/2002 EST, Josh Wilmes <[EMAIL PROTECTED]> wrote:
> - it introduced spaces before the parens on calls to
> mem_sys_memcpy
> string_*
>This is due to the fact that my run_indent.pl program needed to pick
>up #defined types. So it'
At 2:22 on 02/24/2002 GMT, Simon Cozens <[EMAIL PROTECTED]> wrote:
> If you're prepared to fix the output up manually, feel free to run indent on
> your local copy, fix it up, and then mail me a diff; or we can get you commit
> access.
Commit access would be the easiest way to get this done, as
nough.
So, what should be done about the first three? If it's cool to have
shortcut names for types like that, may I propose that we make a header file
which is for use in-core only and does all those aliases in one place. Then
I can parse that for indent's purposes.
--Josh
--
Josh
]> wrote:
> At 10:43 PM -0500 2/23/02, Josh Wilmes wrote:
> >So indent needs to be told about non-standard type (typedefs) to work best.
> >The problem is that some of the parrot code does this:
> >
> >#define CHARTYPE struct parrot_chartype_t
> >#define ENCO
NINGS_ALL_FLAG);
interpreter->pmc_count = 0;
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
_arena->GC_data, 0, sizeof(PMC *) * PMC_HEADERS_PER_ALLOC);
new_arena->start_PMC = mem_sys_allocate(sizeof(PMC) * PMC_HEADERS_PER_ALLOC);
memset(new_arena->start_PMC, 0, sizeof(PMC) * PMC_HEADERS_PER_ALLOC);
new_arena->free = 0;
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
* Local variables:
+ * c-indentation-style: bsd
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ *
+ * vim: expandtab shiftwidth=4:
+ */
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
At 17:41 on 03/02/2002 GMT, Nicholas Clark <[EMAIL PROTECTED]> wrote:
> On Fri, Mar 01, 2002 at 11:28:48PM -0500, Josh Wilmes wrote:
> >
> > Little patch to fix a compiler warning.
> >
> Thanks, applied.
>
> You didn't say which compiler disliked t
RY for open() (at least for Borland C),
Index: io/io_win32.c
===
RCS file: /home/perlcvs/parrot/io/io_win32.c,v
retrieving revision 1.12
diff -u -r1.12 io_win32.c
--- io/io_win32.c 22 Feb 2002 00:53:40 - 1.12
+++ io/io_win32.c 3 Mar 2002 03:03:49 -
@@ -16,7 +16,7 @@
#ifdef WIN32
-#include
+# include
/* Defined at bottom */
extern ParrotIOLayerAPIpio_win32_layer_api;
@@ -122,11 +122,11 @@
DWORD fAcc, fShare, fCreat;
PIOHANDLE fd;
type = PIO_TYPE_FILE;
-#if 0
+# if 0
if((interpreter->flags & PARROT_DEBUG_FLAG) != 0) {
fprintf(stderr, "PIO_win32_open: %s\n", spath);
}
-#endif
+# endif
if((flags & (PIO_F_WRITE|PIO_F_READ)) == 0)
return (ParrotIO *)NULL;
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
"< $out_f";
{
local $/ = undef;
- $prog_output = ;
+ $prog_output = . '';
$prog_output =~ s/\cM\cJ/\n/g;
}
close OUTPUT;
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
Oops, looks like my fault. Thanks for the patch (applied).
Anyone know what trace_op_b0 and b1 are about anyway? They aren't defined
anywhere, as far as i can see.
--Josh
At 18:45 on 03/04/2002 +0100, "Ritz Daniel" <[EMAIL PROTECTED]> wrote:
> subjects says all...patch too...
>
>
> Index:
We should rename all the PDDs to be consistent. I propose:
old name new name title
--
pdd0.pod => pdd00_pdd.podPerl Design Documents
pdd1.pod => pdd01_overview.pod A high-leve
applied.
At 16:01 on 03/16/2002 GMT, Nicholas Clark <[EMAIL PROTECTED]> wrote:
> On Fri, Mar 15, 2002 at 06:10:11PM -0500, Simon Glover wrote:
> > With a proper fresh checkout, everything builds OK here, but I've run
> > into another problem: Parrot::Assembler:Utils uses Text::Balanced, but
>
I suspect that it's not that VMS can't handle it- it's more likely that
VMS does a better job of placing quotas on memory usage than other OSes.
There's probably something analogous to "ulimit" which would fix the
issue, but requiring that in order to build parrot isn't really reasonable.
If w
FWIW, I really like having make clean delete *~. But since we have things
like make cvsclean, i don't consider it essential.
--Josh
At 7:19 on 03/18/2002 GMT, Jonathan Stowe <[EMAIL PROTECTED]> wrote:
> There may be a very good reason for this that I haven't determined but
> this keeps catchi
-Josh
At 11:11 on 03/16/2002 EST, Josh Wilmes <[EMAIL PROTECTED]> wrote:
> applied.
>
> At 16:01 on 03/16/2002 GMT, Nicholas Clark <[EMAIL PROTECTED]> wrote:
>
> > On Fri, Mar 15, 2002 at 06:10:11PM -0500, Simon Glover wrote:
> > > With a proper fresh check
Here are some stragglers:
../.cvsignore:test_parrot
../MANIFEST.SKIP:^test_parrot$
../docs/intro.pod: % ./test_parrot fib.pbc
../test_main.c:fprintf(stderr, "test_parrot: Invalid flag %c used",
test_main.c should probably be renamed too.
--Josh
--
Josh Wilmes ([EMAIL
Thought this was interesting reading.. this is what's going on over in
mozilla-land with regard to licensing.
http://www.mozilla.org/MPL/relicensing-faq.html
--Josh
--
Josh Wilmes ([EMAIL PROTECTED]) | http://www.hitchhiker.org
I've applied the classes/intqueue.pmc patch. The other needs adjustment.
FWIW, your change doesn't cure the errors on TCC:
"string.c", line 51: Error:
[ISO 6.3.16.1]: Conversion casts away 'const'-ness.
[ISO 6.3.16]: Can't perform this conversion by assignment.
"string.c", line 55: Error
Excellent- applied.
--Josh
At 18:03 on 03/21/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote:
> Times are:
> make quicktest, after caching output: 23 seconds
> make test: 175 seconds
>
> make quicktest could screw up if:
> - you ctrl-c it, or make test (although I haven't had problems wit
Bryan, this is good stuff! One question though- in this section of the
patch:
> - /* file header comments */
> -
> - #if !defined(PARROT__H_GUARD)
> - #define PARROT__H_GUARD
> -
> - /* body of file */
> -
> - #endif /* PARROT__H_GUARD */
> +/* file header comments */
> +
> +#if !d
At 11:34 on 03/22/2002 EST, "Bryan C. Warnock" <[EMAIL PROTECTED]> wrote:
> On Friday 22 March 2002 11:23, Josh Wilmes wrote:
> >
> >
> > This doesn't agree with how we've been doing cpp directive indenting in
> > two ways.
>
> I w
Applied, thanks.
--Josh
At 16:21 on 03/24/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote:
> Below is a patch to fix the two warnings about const-ness I get in
> string.c. This should also fix the tcc build on tinderbox. Hopefully this
> spot-fix to the const-ness problems won't cause fu
Good, thanks, applied.
--Josh
At 23:43 on 03/24/2002 +0100, "Ritz Daniel" <[EMAIL PROTECTED]> wrote:
> parrot_dlclose() uses dlclose() on unix, FreeLibrary() on windoze.
> dlclose returns 0 on success, FreeLibrary returns 0 on failure...fix included
>
>
> Index: platforms/win32.c
>
This is rather concerning to me. As I understand it, one of the goals for
parrot was to be able to have a usable subset of it which is totally
platform-neutral (pure ANSI C). If we start to depend too much on
another library which may not share that goal, we could have trouble
with the par
Mike,
that doesn't want to apply for me- i suspect that the patch got garbled in
the mail. Can you MIME-attach or uuencode it?
--Josh
At 23:17 on 03/25/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote:
> Below is a fix for the use of tabs in test_main.c and resources.c.
>
> Mike Lamber
for anyone, please let me know.
>
> Mike Lambert
>
> Josh Wilmes wrote:
>
> > Date: Mon, 25 Mar 2002 23:22:34 -0500
> > From: Josh Wilmes <[EMAIL PROTECTED]>
> > To: Michel J Lambert <[EMAIL PROTECTED]>
> > Cc: [EMAIL PROTECTED]
> > Subject:
Thanks, done.
At 2:59 on 03/27/2002 EST, Michel J Lambert <[EMAIL PROTECTED]> wrote:
> The introduction "make quicktest" made this missing .cvsignore more
> apparent.
>
> Mike Lambert
>
I added some tests which push larger numbers of stack frames- this
improves our coverage in register.c. However, one of the tests is failing
for me. Is this something I did wrong, or did I find a bug?
I'm getting weird output for the pushp and popp (deep) test.
--Josh
Here's the patch:
In
Mike pointed out that I was missing "end" opcodes in there, so I added
them and went ahead and committed this code to CVS. Currently test #7 is
failing, but I think it's a legitimate bug- if not, I apologize for
breaking the tinderbox ;)
--Josh
At 1:15 on 03/28/2002 E
1 - 100 of 213 matches
Mail list logo
