[perl #50996] [BUG] gc bug with perl6grammar in pdd17pmc branch

2008-03-06 Thread Allison Randal via RT
Alright, I set up a windows box with MSVC and ActivePerl and did a binary search. The commit that caused the breakage is r25266, when we updated the PMC struct. Tomorrow I'll experiment with reverting parts of that commit.

Re: [svn:parrot] r26236 - trunk/compilers/imcc

2008-03-06 Thread chromatic
On Wednesday 05 March 2008 18:33:24 [EMAIL PROTECTED] wrote: > +                if (len && (current[len-1] == '$')) { /* local label */ Better as: current[len - 1] Whitespace is nice. -- c

[perl #51478] PDD17PMC : argument doesn't array

2008-03-06 Thread via RT
# New Ticket Created by Will Coleda # Please include the string: [perl #51478] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=51478 > in PDD17, the following program (which prints "b\n" in trunk), dies: $ ../../parrot tcl.

Re: [svn:parrot] r26236 - trunk/compilers/imcc

2008-03-06 Thread Andy Lester
On Mar 6, 2008, at 2:53 AM, chromatic wrote: Better as: current[len - 1] Whitespace is nice. Don't run ack '\w-1\]' or you might cry. xoxo, Andy -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance

Re: [svn:parrot] r26236 - trunk/compilers/imcc

2008-03-06 Thread chromatic
On Thursday 06 March 2008 07:12:03 Andy Lester wrote: > On Mar 6, 2008, at 2:53 AM, chromatic wrote: > > Better as: > > > > current[len - 1] > > > > Whitespace is nice. > > Don't run ack '\w-1\]' or you might cry. I've been fixing those. Don't even *ask* if some of our code is in logical

Re: [svn:parrot] r26248 - trunk/src/pmc

2008-03-06 Thread chromatic
On Thursday 06 March 2008 07:41:07 [EMAIL PROTECTED] wrote: > Log: > This started out as spacing out some n-1 constructs for chromatic, but > then I looked around and saw a lot of returns from functions and those > kinda make me sad because it's usually nicer to drain out the bottom of > the funct

[perl #50968] [BUG] trouble with perl 6 grammars and capturing '.*?'

2008-03-06 Thread Patrick R. Michaud via RT
On Mon Feb 18 14:00:49 2008, particle wrote: > in rakudo's perl6doc parser > (languages/perl6/src/utils/perl6doc/grammar.pg), i have the following: > > token pod_delimited_block { > ^^ '=' <.unsp>? 'begin' <.ws> * \n > .*? > ^^ '=' <.unsp>? 'end' <.ws> $ \N* > {*} >

Re: [svn:parrot] r26248 - trunk/src/pmc

2008-03-06 Thread Andy Lester
On Mar 6, 2008, at 11:58 AM, chromatic wrote: Ugh. People can get over being sad, but unless there are resource release considerations, increasing the nesting depth of a function, widening the scope of stack variables, and obscuring the control flow with more if/else constructs seems lik

Re: [svn:parrot] r26248 - trunk/src/pmc

2008-03-06 Thread chromatic
On Thursday 06 March 2008 10:53:00 Andy Lester wrote: > Actually, it was to decrease the scope of stack variables. Carry on then. (As long as it's not "Functions should have one entry and one exit point", at which point I pull out the whiteboard and give my "Does this LOOK like FORTRAN to you?

Re: [svn:parrot] r26248 - trunk/src/pmc

2008-03-06 Thread Andy Lester
On Mar 6, 2008, at 1:09 PM, chromatic wrote: Actually, it was to decrease the scope of stack variables. Carry on then. (As long as it's not "Functions should have one entry and one exit point", at which point I pull out the whiteboard and give my "Does this LOOK like FORTRAN to you?" lect

Re: [perl #51478] PDD17PMC : argument doesn't array

2008-03-06 Thread chromatic
On Thursday 06 March 2008 06:22:21 Will Coleda wrote: > in PDD17, the following program (which prints "b\n" in trunk), dies: > > $ ../../parrot tcl.pbc -e "puts [concat {expand}[lindex {a b} 1]]" > argument doesn't array. > > This exception is coming from src/inter_call.c:374 > > 369 d

Re: pdd17pmc branch review

2008-03-06 Thread Patrick R. Michaud
On Tue, Mar 04, 2008 at 06:39:38PM -0800, chromatic wrote: > On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > > So, language developers (and others); please grab a copy of > > https://svn.perl.org/parrot/branches/pdd17pmc and check out the > > languages to see how they fare compared to their

Re: pdd17pmc branch review

2008-03-06 Thread Patrick R. Michaud
> On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > So, language developers (and others); please grab a copy of > https://svn.perl.org/parrot/branches/pdd17pmc and check out the > languages to see how they fare compared to their counterparts in > trunk. APL doesn't run. I suspect the aplvect

Re: [perl #51478] PDD17PMC : argument doesn't array

2008-03-06 Thread Will Coleda
On Thu, Mar 6, 2008 at 2:41 PM, chromatic via RT <[EMAIL PROTECTED]> wrote: > > On Thursday 06 March 2008 06:22:21 Will Coleda wrote: > > > in PDD17, the following program (which prints "b\n" in trunk), dies: > > > > $ ../../parrot tcl.pbc -e "puts [concat {expand}[lindex {a b} 1]]" > > argumen

Re: [perl #51478] PDD17PMC : argument doesn't array

2008-03-06 Thread chromatic
On Thursday 06 March 2008 11:47:41 Will Coleda wrote: > Sure. Take the original: > > > $ ../../parrot tcl.pbc -e "puts [concat {expand}[lindex {a b} 1]]" > > and just tack a --pir on the end: I verified that saving that out to a > .pir file and running *that* through parrot generates the same err

[perl #50996] [BUG] gc bug with perl6grammar in pdd17pmc branch

2008-03-06 Thread Allison Randal via RT
The problem was in the conversion of pobj_t to the new flattened structure for PDD17. I've reverted that part of r25266 for now (in r26254). The problem is probably an incomplete conversion, with some parts of the code still expecting the multi-level structure. I'll work on a more complete conversi

Re: [svn:parrot] r26248 - trunk/src/pmc

2008-03-06 Thread James E Keenan
Andy Lester wrote: We should also have 100% code coverage, too. Ah, I'm so glad someone in addition to me said that! ;-) kid51

Re: pdd17pmc branch review

2008-03-06 Thread Will Coleda
On Thu, Mar 6, 2008 at 2:45 PM, Patrick R. Michaud <[EMAIL PROTECTED]> wrote: > > On Tuesday 04 March 2008 16:48:09 Will Coleda wrote: > > So, language developers (and others); please grab a copy of > > https://svn.perl.org/parrot/branches/pdd17pmc and check out the > > languages to see how they

Re: pdd17pmc branch review

2008-03-06 Thread chromatic
On Thursday 06 March 2008 18:25:57 Will Coleda wrote: > I applied this change, as well as updating the methods to use the > PDD17 conventions (PCCRETURN), etc. Now down to only six failing sub > tests. Again, if I can get PIR that corresponds to these tests (or find out how to generate it myself