Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont->from_ctx

2007-09-25 Thread chromatic
On Tuesday 25 September 2007 15:05:21 Bram Geron wrote: > Reasoning from this model, I can't see what from_ctx is for. After > solving one exception, there is no place that uses the value of > from_ctx. So if a piece of code uses that context, it's stored at > another place and that place should r

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont->from_ctx

2007-09-25 Thread Bram Geron
Mehmet Yavuz Selim Soyturk wrote: >> -if (cc->from_ctx) >> -Parrot_free_context(interp, cc->from_ctx, 0); > > >> -Parrot_free_context(INTERP, from_ctx, 1); > > > I don't know much about this context stuff, so maybe I don't see > something, but how are those conte

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont->from_ctx

2007-09-24 Thread Leopold Toetsch
Am Sonntag, 23. September 2007 20:19 schrieb Bram Geron: > To test if 'from_ctx' is redundant, I tried removing the field and all > accesses to it, and no extra tests failed (see patch). Did you run a memory leak test? The from_ctx is refcounted for some reason. leo

Re: [perl #45695] [PATCH] Remove seemingly unnecessary Parrot_cont->from_ctx

2007-09-24 Thread Mehmet Yavuz Selim Soyturk
> -if (cc->from_ctx) > -Parrot_free_context(interp, cc->from_ctx, 0); > -Parrot_free_context(INTERP, from_ctx, 1); I don't know much about this context stuff, so maybe I don't see something, but how are those contexts freed after your patch?