Re: [perl #16274] [PATCH] Keyed access

2002-08-21 Thread Leopold Toetsch
Mike Lambert wrote: > Anyways, cd to languages/BASIC, run basic.pl, type "LOAD wumpus", and > watch it die on "Not a string!". Tracing this beast down, needs attached patch, to cut displayed arg strings. BTW trace.c nether frees this escaped string. The last instruction executed is: PC=1457;

Re: [perl #16274] [PATCH] Keyed access

2002-08-21 Thread Mike Lambert
Tom Hughes wrote: > Index: basicvar.pasm > === ... > Index: instructions.pasm > === ... Fixes the bug, and wumpus plays yet again. Applied, thanks. Mike Lambert

Re: [perl #16274] [PATCH] Keyed access

2002-08-21 Thread Tom Hughes
? basic.pbc ? merged_basic.pasm Index: basicvar.pasm === RCS file: /cvs/public/parrot/languages/BASIC/basicvar.pasm,v retrieving revision 1.10 diff -u -r1.10 basicvar.pasm --- basicvar.pasm 20 Jun 2002 00:05:09 - 1.10 +++ basicvar

Re: [perl #16274] [PATCH] Keyed access

2002-08-21 Thread Tom Hughes
In message <[EMAIL PROTECTED]> Mike Lambert <[EMAIL PROTECTED]> wrote: > Anyways, cd to languages/BASIC, run basic.pl, type "LOAD wumpus", and > watch it die on "Not a string!". It could be that basic is using keys in > weird ways, or it could be that the key patch is borked...I haven't l

Re: [perl #16274] [PATCH] Keyed access

2002-08-20 Thread Mike Lambert
> I have a clean version that's up to date, and as everybody seems to > be happy with it I'm going to go ahead and commit it now. Ah-ha! I found a showstopper! Oh, it's a little late for that, isn't it? :) Anyways, cd to languages/BASIC, run basic.pl, type "LOAD wumpus", and watch it die on "Not

Re: [perl #16274] [PATCH] Keyed access

2002-08-19 Thread Jeff
Tom Hughes wrote: > > In message <[EMAIL PROTECTED]> > Jeff <[EMAIL PROTECTED]> wrote: > > > Jeff wrote: > > > > > It's not quite applying against the current build, however. > > > classes/default.pmc was easy to fix, assemble.pl not so simple, core.ops > > > and hash.c had other probl

Re: [perl #16274] [PATCH] Keyed access

2002-08-19 Thread Tom Hughes
In message <[EMAIL PROTECTED]> Jeff <[EMAIL PROTECTED]> wrote: > Jeff wrote: > > > It's not quite applying against the current build, however. > > classes/default.pmc was easy to fix, assemble.pl not so simple, core.ops > > and hash.c had other problems. Could I trouble you to fix these

Re: [perl #16274] [PATCH] Keyed access

2002-08-19 Thread Jeff
Jeff wrote: > > Tom Hughes wrote: > > > > In message <[EMAIL PROTECTED]> > > Mike Lambert <[EMAIL PROTECTED]> wrote: > > Oops. That only went in yesterday... Now fixed. > > > > > Overall, tho, the patch looks extemely complete. Tracing support, > > > disassemble.pl support, debug.c supp

Re: [perl #16274] [PATCH] Keyed access

2002-08-19 Thread Jeff
Tom Hughes wrote: > > In message <[EMAIL PROTECTED]> > Mike Lambert <[EMAIL PROTECTED]> wrote: > Oops. That only went in yesterday... Now fixed. > > > Overall, tho, the patch looks extemely complete. Tracing support, > > disassemble.pl support, debug.c support, etc. You even reduced ma

Re: [perl #16274] [PATCH] Keyed access

2002-08-19 Thread Josef Hook
On Sun, 18 Aug 2002, Tom Hughes wrote: > In message <[EMAIL PROTECTED]> > Tom Hughes <[EMAIL PROTECTED]> wrote: > > > What I realised last night however is that there is enough space in > > the private flags on the PMC for the type information and I can then > > attach the data direc

Re: [perl #16274] [PATCH] Keyed access

2002-08-18 Thread Tom Hughes
In message <[EMAIL PROTECTED]> Mike Lambert <[EMAIL PROTECTED]> wrote: > - assemble.pl: > shouldn't the code : > elsif ($_->[0] =~ /^([snpk])c$/) { # String/Num/PMC/Key constant > include support for "kic" somewhere? It doesn't need to as to_bytecode() turns [1] into an ic argu

Re: [perl #16274] [PATCH] Keyed access

2002-08-17 Thread Mike Lambert
> Attached is my first cut of a patch to address the keyed access issues. First, thanks for spending the time to implement and clean up the keyed code. Hopefully this'll clean the floor so that when this list has key discussions, we'll all be arguing about the same thing. :) > This patch doesn't

Re: [perl #16274] [PATCH] Keyed access

2002-08-17 Thread Dan Sugalski
At 3:30 PM + 8/17/02, Tom Hughes (via RT) wrote: > >Attached is my first cut of a patch to address the keyed access issues. > >This patch doesn't do everything, but it does bring things more or less >in line with Dan's recent specification I hope. I'm sure there are also >problems with it so i