Re: Disassembler enhancement for review

2007-12-29 Thread Bob Rogers
From: Allison Randal <[EMAIL PROTECTED]> Date: Sat, 29 Dec 2007 12:08:10 +0200 Looks good. Go ahead and commit. Better abstraction for signature decoding can be added later. Allison Thanks; done in r24268. I also changed it to use PIR syntax, so we wouldn't have a new syntax to

Re: Disassembler enhancement for review

2007-12-29 Thread Allison Randal
Bob Rogers wrote: The attached patch adds decoding of call/return registers to the disassembler, and also fixes a segfault; both are byproducts of a long and otherwise fruitless debugging session. Please let me know what you think. Looks good. Go ahead and commit. Better abstraction for sig

Disassembler enhancement for review

2007-12-28 Thread Bob Rogers
The attached patch adds decoding of call/return registers to the disassembler, and also fixes a segfault; both are byproducts of a long and otherwise fruitless debugging session. Please let me know what you think. -- Bob Rogers