Re: [svn:parrot] r31230 - in trunk: compilers/imcc src src/pmc

2008-09-18 Thread chromatic
On Thursday 18 September 2008 12:03:19 NotFound wrote: > On Thu, Sep 18, 2008 at 8:14 PM, chromatic <[EMAIL PROTECTED]> wrote: > > The comment helps, but defining these magic numbers as magic constants > > might be even clearer (but please keep the comment). > I think that setting a constant is

Re: [svn:parrot] r31230 - in trunk: compilers/imcc src src/pmc

2008-09-18 Thread NotFound
On Thu, Sep 18, 2008 at 8:14 PM, chromatic <[EMAIL PROTECTED]> wrote: >> -char* buf = mem_allocate_n_typed(5*n+1, char *); >> +/* Assumptions: >> + * Flags has no more than 3 hex digits >> + * Plus 0x and , gives 6 char for arg >> + * 4 more for: "( , )", and >> +

Re: [svn:parrot] r31230 - in trunk: compilers/imcc src src/pmc

2008-09-18 Thread chromatic
On Thursday 18 September 2008 08:42:46 [EMAIL PROTECTED] wrote: > Author: julianalbo > Date: Thu Sep 18 08:42:43 2008 > New Revision: 31230 > > Modified: >trunk/compilers/imcc/pcc.c > > Log: > miscellaneous fixes > > Modified: trunk/compilers/imcc/pcc.c > ==