Re: [svn:parrot] r28910 - branches/pdd25cx/src/ops

2008-07-01 Thread chromatic
On Tuesday 01 July 2008 13:21:03 Geoffrey Broadwell wrote: > On Tue, 2008-07-01 at 11:46 -0700, chromatic wrote: > > if (next < interp->code->base.data > > > > || next >= (interp->code->base.data + interp->code->base.size)) > > Oh, that's just pretty. I've long been in the habit of lay

Re: [svn:parrot] r28910 - branches/pdd25cx/src/ops

2008-07-01 Thread Geoffrey Broadwell
On Tue, 2008-07-01 at 11:46 -0700, chromatic wrote: > if (next < interp->code->base.data > || next >= (interp->code->base.data + interp->code->base.size)) Oh, that's just pretty. I've long been in the habit of laying out whitespace for multiple if tests like this: if ( next

Re: [svn:parrot] r28910 - branches/pdd25cx/src/ops

2008-07-01 Thread chromatic
On Tuesday 01 July 2008 11:23:48 [EMAIL PROTECTED] wrote: > Modified: >branches/pdd25cx/src/ops/core.ops > > Log: > [pdd25cx] Add range checking to 'local_return' opcode, to require it be > within the current code segment. > > > Modified: branches/pdd25cx/src/ops/core.ops > ===