[perl #56166] [BUG] [PATCH] Perl::Critic Version Problems

2008-06-29 Thread Will Coleda via RT
On Sun Jun 22 19:35:27 2008, coke wrote: > Attached find a first pass at converting our perlcritic.t into using > Test::Perl::Critic. > > This patch: > > - requires Test::Perl::Critic to do anything useful with the test. (We > can add it to > Bundle::Parrot) > - creates a new perlcritic.conf file

[perl #56166] [BUG] [PATCH] Perl::Critic Version Problems

2008-06-26 Thread James Keenan via RT
Thanks, Coke. On my Linux VM I did not yet have Test::Perl::Critic installed, so I first tested the patch to see if it would DTRT, i.e., skip all. It did. I then installed Test::Perl::Critic via 'cpan' and retested, successfully. (I might add that since the first files to be tested are Configur

Re: [perl #56166] [BUG] [PATCH] Perl::Critic Version Problems

2008-06-26 Thread Will Coleda
On Thu, Jun 26, 2008 at 4:18 PM, James Keenan via RT <[EMAIL PROTECTED]> wrote: > FWIW, the part of the patch pertaining to t/codingstd/perlcritic.t did > not apply cleanly when I tried it on Linux. > > That may just indicate that the guts have been ripped out of that file > and replaced with mostl

[perl #56166] [BUG] [PATCH] Perl::Critic Version Problems

2008-06-26 Thread James Keenan via RT
FWIW, the part of the patch pertaining to t/codingstd/perlcritic.t did not apply cleanly when I tried it on Linux. That may just indicate that the guts have been ripped out of that file and replaced with mostly new code. Perhaps you could post the complete text of your new version of that file?

Re: [perl #56166] [BUG] [PATCH] Perl::Critic Version Problems

2008-06-26 Thread Will Coleda
On Sun, Jun 22, 2008 at 10:35 PM, Will Coleda via RT <[EMAIL PROTECTED]> wrote: > Attached find a first pass at converting our perlcritic.t into using > Test::Perl::Critic. > > This patch: > > - requires Test::Perl::Critic to do anything useful with the test. (We can > add it to > Bundle::Parrot)

[perl #56166] [BUG] [PATCH] Perl::Critic Version Problems

2008-06-23 Thread Will Coleda via RT
Attached find a first pass at converting our perlcritic.t into using Test::Perl::Critic. This patch: - requires Test::Perl::Critic to do anything useful with the test. (We can add it to Bundle::Parrot) - creates a new perlcritic.conf file that represents declaratively a large chunk of the cod