On Wednesday 09 July 2008 08:27:35 Andrew Johnson wrote:
> > Done in r29179, please confirm that gives no warning now.
>
> Confirmed, those warnings have gone. I'm still getting loads of "warning:
> statement not reached" but I'll work out how to suppress those and post a
> fix separately.
Does
On Tuesday 08 July 2008 17:55:42 NotFound wrote:
> On Mon, Jun 23, 2008 at 4:37 PM, Andrew Johnson <[EMAIL PROTECTED]> wrote:
> >> Here is the patch. It avoids the warning both in C and C++ with gcc.
> >
> > Works fine for me, no warning.
> > It might be worth adding a comment into parrot.h to clar
On Mon, Jun 23, 2008 at 4:37 PM, Andrew Johnson <[EMAIL PROTECTED]> wrote:
>> Here is the patch. It avoids the warning both in C and C++ with gcc.
> Works fine for me, no warning.
> It might be worth adding a comment into parrot.h to clarify that
> PARROT_const_cast should *only* be used for c/v q
On Monday 23 June 2008 09:08:07 NotFound wrote:
> Here is the patch. It avoids the warning both in C and C++ with gcc.
Works fine for me, no warning.
It might be worth adding a comment into parrot.h to clarify that
PARROT_const_cast should *only* be used for c/v qualifier changes, and that
addi
On Mon, Jun 23, 2008 at 4:37 PM, Andrew Johnson <[EMAIL PROTECTED]> wrote:
> It might be worth adding a comment into parrot.h to clarify that
> PARROT_const_cast should *only* be used for c/v qualifier changes, and that
> additional casting may be necessary.
Yes, but I don't know how to write it
Here is the patch. It avoids the warning both in C and C++ with gcc.
--
Salu2
Index: src/packfile.c
===
--- src/packfile.c (revisión: 28668)
+++ src/packfile.c (copia de trabajo)
@@ -348,7 +348,7 @@
#ifdef PARROT_HAS_HEADER_SYSMMAN
On Sat, Jun 21, 2008 at 11:10 AM, chromatic <[EMAIL PROTECTED]> wrote:
> On Friday 20 June 2008 10:53:55 Andrew Johnson wrote:
>
>> I'm concluding that these warnings are due to incorrect casting inside of
>> packfile.c.
>>
>> In both cases, the code generating the warnings looks like this:
>>
>>
On Friday 20 June 2008 10:53:55 Andrew Johnson wrote:
> I'm concluding that these warnings are due to incorrect casting inside of
> packfile.c.
>
> In both cases, the code generating the warnings looks like this:
>
> munmap(PARROT_const_cast(opcode_t *, pf->src), pf->size);
>
> pf->src is
On Thursday 19 June 2008 15:33:14 Parrot via RT wrote:
> "src/packfile.c", line 351: warning: argument #1 is incompatible with
> prototype:
> prototype: pointer to char : "/usr/include/sys/mman.h", line 161
> argument : pointer to long
> "src/packfile.c", line 878: warning: argument
