Re: [perl #53352] [PATCH] Build warnings in STRUCT_COPY

2008-04-28 Thread chromatic
On Monday 28 April 2008 14:00:28 NotFound wrote: > The attached patch redoes the changes in these files with the new name. Thanks! Applied in r27223. -- c

Re: [perl #53352] [PATCH] Build warnings in STRUCT_COPY

2008-04-28 Thread NotFound
The attached patch redoes the changes in these files with the new name. -- Salu2 Index: src/encodings/utf16.c === --- src/encodings/utf16.c (revisión: 27222) +++ src/encodings/utf16.c (copia de trabajo) @@ -708,7 +708,7 @@

Re: [perl #53352] [PATCH] Build warnings in STRUCT_COPY

2008-04-28 Thread NotFound
On Mon, Apr 28, 2008 at 10:05 PM, chromatic <[EMAIL PROTECTED]> wrote: > I renamed it to STRUCT_COPY_FROM_STRUCT (but that's only a little better than > your version) and applied it as r27222. Thanks, but in 27222 looks like only include/parrot/parrot.h reflects the changes, not the files in sr

Re: [perl #53352] [PATCH] Build warnings in STRUCT_COPY

2008-04-28 Thread chromatic
On Monday 28 April 2008 11:15:56 NotFound wrote: > The attached patch adds the macro STRUCT_COPY_ST, and uses it in the > src/charset charset init functions. > > All test pass with 27216 in my system (Ubuntu 8.04) I renamed it to STRUCT_COPY_FROM_STRUCT (but that's only a little better than your

Re: [perl #53352] [PATCH] Build warnings in STRUCT_COPY

2008-04-28 Thread NotFound
On Mon, Apr 28, 2008 at 8:15 PM, NotFound <[EMAIL PROTECTED]> wrote: > All test pass with 27216 in my system (Ubuntu 8.04) Sorry, I mean 27219, 27216 was from the modified files. -- Salu2

[perl #53352] [PATCH] Build warnings in STRUCT_COPY

2008-04-28 Thread NotFound
On Sat, Apr 26, 2008 at 8:16 PM, chromatic <[EMAIL PROTECTED]> wrote: > > A possible solution is to add another macro taking as second argument > > the struct instead of a pointer. > That seems cleaner to me; want to try that patch? The attached patch adds the macro STRUCT_COPY_ST, and uses it