Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Dougherty
On Wed, 12 Mar 2008, chromatic wrote: > On Wednesday 12 March 2008 15:07:08 Andy Lester wrote: > > > On Mar 12, 2008, at 4:50 PM, Andy Dougherty via RT wrote: > > > The problem is twofold: > > > > I'm not sure what you're saying is a problem. Are you saying that the > > use of __attribute__nonnu

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread chromatic
On Wednesday 12 March 2008 15:07:08 Andy Lester wrote: > On Mar 12, 2008, at 4:50 PM, Andy Dougherty via RT wrote: > > The problem is twofold: > > I'm not sure what you're saying is a problem. Are you saying that the > use of __attribute__nonnull__ is a problem? Or just that we don't > have it s

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Lester
On Mar 12, 2008, at 4:50 PM, Andy Dougherty via RT wrote: The problem is twofold: I'm not sure what you're saying is a problem. Are you saying that the use of __attribute__nonnull__ is a problem? Or just that we don't have it set correctly everywhere? When we DO get it fixed right, i

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Dougherty
On Wed, 12 Mar 2008, Andy Lester wrote: > > On Mar 12, 2008, at 2:33 PM, Andy Dougherty via RT wrote: > > > +#ifdef HASATTRIBUTE_NONNULL_AND_I_REALLY_WANT_TO_USE_IT > > # define __attribute__nonnull__(a) __attribute__((__nonnull__(a))) > > #endif > > #ifdef HASATTRIBUTE_NORETURN > > >

Re: [PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andy Lester
On Mar 12, 2008, at 2:33 PM, Andy Dougherty via RT wrote: +#ifdef HASATTRIBUTE_NONNULL_AND_I_REALLY_WANT_TO_USE_IT # define __attribute__nonnull__(a) __attribute__((__nonnull__(a))) #endif #ifdef HASATTRIBUTE_NORETURN and "suddenly" (for some value of suddenly that is more like an

[PATCH] Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-12 Thread Andrew Dougherty
[various thoughts on attribute_nonnull] On a lark, I applied this patch: --- parrot-current/include/parrot/compiler.hTue Mar 11 07:19:23 2008 +++ parrot-andy/include/parrot/compiler.h Wed Mar 12 13:22:42 2008 @@ -44,7 +44,7 @@ #ifdef HASATTRIBUTE_MALLOC # define __attribute__malloc__

Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-11 Thread Andy Dougherty
On Tue, 11 Mar 2008, Nicholas Clark wrote: > On Mon, Feb 11, 2008 at 05:48:54PM +0200, Peter Gibbs wrote: > > There are two apparent solutions: check all notnull arguments before > > calling the functions or remove the nonnull attribute where it is not > > true. > > Or assert() every single on

Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-03-11 Thread Nicholas Clark
On Mon, Feb 11, 2008 at 05:48:54PM +0200, Peter Gibbs wrote: > Looking at just this one case, we see that string_ord is called with a > NULL s argument, whereas the function header states that s is nonnull. > The GCC optimiser believes what it is told, and therefore discards the > test for s be

Re: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-02-11 Thread Peter Gibbs
- Original Message - From: "chromatic (via RT)" <[EMAIL PROTECTED]> Sent: Saturday, February 09, 2008 11:29 PM Subject: [perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux) I recompiled Parrot with the -march and -O2 flags, to see what kind of spe

[perl #50684] String Failures with -O2 (GCC 4.1.3, 32-bit x86 Linux)

2008-02-09 Thread via RT
# New Ticket Created by chromatic # Please include the string: [perl #50684] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=50684 > I recompiled Parrot with the -march and -O2 flags, to see what kind of speed boosts we get