Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-23 Thread Alek Storm
On 4/23/07, chromatic <[EMAIL PROTECTED]> wrote: On Monday 23 April 2007 09:07, Jonathan Worthington wrote: > chromatic wrote: > > Jonathan, can you help us figure out why deleting these lines out of > > init() fixes the problem? Are they vestigial? > > > > /* turn on marking of the c

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-23 Thread Leopold Toetsch
Am Montag, 23. April 2007 18:07 schrieb Jonathan Worthington: > >       /* turn on marking of the class_data array */ > >       PObj_data_is_PMC_array_SET(self); > >   > > I saw those before and thought they were very suspect; It's not per se suspect. The (data*) points to an array of obje

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-23 Thread chromatic
On Monday 23 April 2007 09:07, Jonathan Worthington wrote: > chromatic wrote: > > Jonathan, can you help us figure out why deleting these lines out of > > init() fixes the problem? Are they vestigial? > > > > /* turn on marking of the class_data array */ > > PObj_data_is_PMC_array

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-23 Thread Jonathan Worthington
chromatic wrote: Jonathan, can you help us figure out why deleting these lines out of init() fixes the problem? Are they vestigial? /* turn on marking of the class_data array */ PObj_data_is_PMC_array_SET(self); I saw those before and thought they were very suspect;

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-22 Thread chromatic
On Sunday 22 April 2007 17:57, Alek Storm wrote: > > That's as far as I've been able to trace however. The tests do pass if I > > revert the patch. Any ideas? > > I think the patch exposed either a GC or SMOP bug. Here's the smallest I > could get the test case and still have it segfault withou

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-22 Thread Alek Storm
On 4/22/07, chromatic <[EMAIL PROTECTED]> wrote: It came in just before the release and it touched a lot of files, so I (speaking only for myself) let it sit for a couple of days. Unfortunately, it also came in after Steve Peters's "No C++ Keywords" patch, so it didn't apply cleanly. Thanks.

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-21 Thread chromatic
On Saturday 21 April 2007 18:20, Alek Storm wrote: > This patch has been sitting for over a week. Is there a problem? I > can't continue work in this area until this is committed. It came in just before the release and it touched a lot of files, so I (speaking only for myself) let it sit for a c

Re: [perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-21 Thread Alek Storm
This patch has been sitting for over a week. Is there a problem? I can't continue work in this area until this is committed. -- Alek Storm

[perl #42408] Re: [PATCH] refactor vtable overriding, delegate.c generation

2007-04-10 Thread Alek Storm
# New Ticket Created by "Alek Storm" # Please include the string: [perl #42408] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=42408 > And... oops. Here's the patch, in all its glory. -- Alek Storm Index: src/objects.c =