Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-29 Thread chromatic
On Thursday 29 March 2007 07:29, Steve Peters via RT wrote: > Of course, some well defined macros could assist in cleaning this up. > For example... > > #define PARROT_MEM_ALLOCATE(type) \ > (type *)mem_sys_allocate(sizeof(type)) > > I don't know the Parrot opinion of macros, but it would cer

[perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-29 Thread Steve Peters via RT
On Tue Mar 27 10:54:17 2007, doughera wrote: > On Tue, 27 Mar 2007, Steve Peters wrote: > > > # New Ticket Created by Steve Peters > > # Please include the string: [perl #42151] > > # in the subject line of all future correspondence about this issue. > > # http://rt.perl.org/rt3/Ticket/Display

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Leopold Toetsch
Am Dienstag, 27. März 2007 21:55 schrieb Andrew Dougherty: > On Tue, 27 Mar 2007, Andy Dougherty wrote: > > I think you'll find a lot of lower-level cleanups are in order. > > [other stuff deleted.] > > Oops! My previous message was not appropriate, and I didn't mean to send > it. Please ignore i

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Leopold Toetsch
Am Dienstag, 27. März 2007 21:39 schrieb Andy Dougherty: >  Leo > tended to assume all pointers could equally well point anywhere, and often > ignored alignment issues. Nope. Sorry. leo

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Leopold Toetsch
Am Dienstag, 27. März 2007 19:52 schrieb Andy Dougherty: > Instead of sprinking (opcode_t *) casts everywhere, wouldn't it be better > to declare the invoke() function as returning an (opcode_t *) ?   True. But while invoke() et al receive and return an (opcode_t*) the actual running runloop (wi

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Andrew Dougherty
On Tue, 27 Mar 2007, Andy Dougherty wrote: > I think you'll find a lot of lower-level cleanups are in order. [other stuff deleted.] Oops! My previous message was not appropriate, and I didn't mean to send it. Please ignore it. I'm sorry about that. -- Andy Dougherty [EMAIL

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Andy Dougherty
On Tue, 27 Mar 2007, Steve Peters via RT wrote: > On Tue Mar 27 10:54:17 2007, doughera wrote: > > Instead of sprinking (opcode_t *) casts everywhere, wouldn't it be better > > to declare the invoke() function as returning an (opcode_t *) ? > > Similarly for most of the other bits you patched.

[perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Steve Peters via RT
On Tue Mar 27 10:54:17 2007, doughera wrote: > On Tue, 27 Mar 2007, Steve Peters wrote: > > > # New Ticket Created by Steve Peters > > # Please include the string: [perl #42151] > > # in the subject line of all future correspondence about this issue. > > # http://rt.perl.org/rt3/Ticket/Display

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Andy Dougherty
On Tue, 27 Mar 2007, Steve Peters wrote: > # New Ticket Created by Steve Peters > # Please include the string: [perl #42151] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt3/Ticket/Display.html?id=42151 > Thanks for taking on this Herculean tas

Re: [perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread Kevin Tew
Looks great Steve, could (PMC *) get added to the NEED_CONTINUATION macro Index: include/parrot/sub.h === --- include/parrot/sub.h(revision 17785) +++ include/parrot/sub.h(working copy) @@ -109,7 +109,7 @@ * a flag

[perl #42151] [PATCH] Assorted casting cleanups - part I

2007-03-27 Thread via RT
# New Ticket Created by Steve Peters # Please include the string: [perl #42151] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=42151 > Index: src/ops/experimental.ops