Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-31 Thread Allison Randal
Alek Storm wrote: Do you mean a PCCMETHOD? If we're just getting and setting attributes, I really think we should be using getattribute and setattribute, or getprop and setprop, instead of expanding the ParrotInterpreter namespace with a bunch of simple getter and setter methods. getattribute

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-31 Thread Alek Storm
On 3/31/07, Allison Randal <[EMAIL PROTECTED]> wrote: Alek Storm wrote: > Hmm. You know what I just found out? The ParrotInterpreter PMC > doesn't implement set_pmc_keyed. Any objections to implementing it? Pass. It has methods, and access to the internal data of the interpreter object shoul

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-31 Thread Allison Randal
Alek Storm wrote: Hmm. You know what I just found out? The ParrotInterpreter PMC doesn't implement set_pmc_keyed. Any objections to implementing it? Pass. It has methods, and access to the internal data of the interpreter object should go through those methods. Allison

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-31 Thread Leopold Toetsch
Am Samstag, 31. März 2007 00:23 schrieb Paul Cochrane: > > It would be pretty simple to make this a settable/queryable interpreter > > property. Would that be valuable? > > It's already a gettable interpreter property > (interp->recursion_limit). I'm guessing it would be valuable to be > able to

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread Alek Storm
-1 is often used to signify infinity, so the code using it would probably be a little clearer if it used that. However, since 0 isn't a logical value anyway, that's probably a good idea, though I haven't seen much bare type-converting in the Parrot source. On 3/30/07, Nicholas Clark <[EMAIL PROT

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread Nicholas Clark
On Fri, Mar 30, 2007 at 10:25:59PM +, Alek Storm wrote: > How about like this: > > $P0 = getinterp > $P0["recursionlimit"] = 2000 > $P0["recursionlimit"] = -1 > > Where the last one signifies an infinite recursion limit (unsafe, but > it should still be available to HLL implementors). Is the

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread Alek Storm
Hmm. You know what I just found out? The ParrotInterpreter PMC doesn't implement set_pmc_keyed. Any objections to implementing it? It could then be expanded to support getting and setting interpreter flags, which are currently handled through get_ and set_integer_keyed_int. Providing a keyed s

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread Alek Storm
How about like this: $P0 = getinterp $P0["recursionlimit"] = 2000 $P0["recursionlimit"] = -1 Where the last one signifies an infinite recursion limit (unsafe, but it should still be available to HLL implementors). On 3/30/07, chromatic <[EMAIL PROTECTED]> wrote: On Friday 30 March 2007 13:38,

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread Paul Cochrane
It would be pretty simple to make this a settable/queryable interpreter property. Would that be valuable? It's already a gettable interpreter property (interp->recursion_limit). I'm guessing it would be valuable to be able to set the value at runtime. Coke mentioned this on #parrot. Unfortuna

Re: [perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread chromatic
On Friday 30 March 2007 13:38, Paul Cochrane via RT wrote: > Thanks! Applied in r17863. It would be pretty simple to make this a settable/queryable interpreter property. Would that be valuable? -- c

[perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-30 Thread Paul Cochrane via RT
Thanks! Applied in r17863.

[perl #42074] [PATCH] add RECURSION_LIMIT macro

2007-03-25 Thread Alek Storm
# New Ticket Created by "Alek Storm" # Please include the string: [perl #42074] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=42074 > This patch defines a RECURSION_LIMIT macro in include/parrot/sub.h, which interp->recurs