Re: [perl #41894] segfault happens when invoking poll op

2007-10-13 Thread chromatic
On Saturday 13 October 2007 17:03:56 Will Coleda wrote: > ENOPATCH === lib/Parrot/Op.pm == --- lib/Parrot/Op.pm (revision 6305) +++ lib/Parrot/Op.pm (local) @@ -67,6 +67,8 @@ use strict; use warnings; +use Scalar::Util 'blessed';

Re: [perl #41894] segfault happens when invoking poll op

2007-10-13 Thread Will Coleda
ENOPATCH On Oct 13, 2007, at 5:11 PM, chromatic wrote: On Saturday 14 April 2007 12:13:32 Joshua Isom wrote: Wouldn't it be preferable to add a check to ops2c for all 'in' pmc's to make sure they are not null? That would help prevent errors like this from popping up easily, and just requ

Re: [perl #41894] segfault happens when invoking poll op

2007-10-13 Thread chromatic
On Saturday 14 April 2007 12:13:32 Joshua Isom wrote: > Wouldn't it be preferable to add a check to ops2c for all 'in' pmc's to > make sure they are not null? That would help prevent errors like this > from popping up easily, and just require that all C code using the > functions must check for i

Re: [perl #41894] segfault happens when invoking poll op

2007-04-14 Thread Joshua Isom
On Apr 14, 2007, at 7:44 AM, Jonathan Worthington wrote: Hi, This patch broke the build on some platforms (Win32 with MSVC++ included). INTVAL PIO_poll(Interp *interp, PMC *pmc, INTVAL which, INTVAL sec, INTVAL usec) { +if (pmc == PMCNULL) { + real_exception(interp, NULL, E_Valu

Re: [perl #41894] segfault happens when invoking poll op

2007-04-14 Thread Jonathan Worthington
Hi, This patch broke the build on some platforms (Win32 with MSVC++ included). INTVAL PIO_poll(Interp *interp, PMC *pmc, INTVAL which, INTVAL sec, INTVAL usec) { +if (pmc == PMCNULL) { + real_exception(interp, NULL, E_ValueError, "Can't poll NULL pmc"); +} ParrotIOLayer * co

[perl #41894] segfault happens when invoking poll op

2007-04-13 Thread Nuno Carvalho via RT
Greetings, On Wed Mar 21 20:49:36 2007, coke wrote: > The following patch avoids the segfault: > > Index: src/io/io.c > = > == > --- src/io/io.c (revision 17678) > +++ src/io/io.c (working copy) > @@ -1325,6 +1325,9 @@ > INTVAL > P

[perl #41894] segfault happens when invoking poll op

2007-03-19 Thread Jim McKim
# New Ticket Created by "Jim McKim" # Please include the string: [perl #41894] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=41894 > --- osname= linux osvers= 2.6.15-gentoo-alt2 arch= x86_64-linux cc= x86_64-pc-linux