[perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-03-16 Thread [EMAIL PROTECTED] via RT
Hi, This was wanted in the next release, so I applied the bits that weren't applying with patch manually. Applied your tests as well. All checked in as r17514. Thanks! Jonathan

Re: [perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-03-15 Thread Alek Storm
I'll be gone for a few days, so I'll fix it when I get back. It just looks like object.ops changed since I submitted the patch. On 3/15/07, Will Coleda via RT <[EMAIL PROTECTED]> wrote: Can't apply this patch: $ patch -p0 < foo.patch patching file CREDITS Hunk #1 succeeded at 572 (offset 19 l

Re: [perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-03-04 Thread Alek Storm
Just kidding! Here's the patch, for real this time. On 3/4/07, Alek Storm <[EMAIL PROTECTED]> wrote: That's because the patch refers to a function that is now outdated because of #41549. I've attached an updated version of the patch. Thanks, Alek Storm On 3/2/07, [EMAIL PROTECTED] via RT <[E

Re: [perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-03-04 Thread Alek Storm
That's because the patch refers to a function that is now outdated because of #41549. I've attached an updated version of the patch. Thanks, Alek Storm On 3/2/07, [EMAIL PROTECTED] via RT <[EMAIL PROTECTED]> wrote: On Sun Feb 25 20:10:00 2007, [EMAIL PROTECTED] wrote: > Now that 0.4.9 has bee

[perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-03-02 Thread [EMAIL PROTECTED] via RT
On Sun Feb 25 20:10:00 2007, [EMAIL PROTECTED] wrote: > Now that 0.4.9 has been released, can this be committed? > I just tried, but I get: /home/default/jnthn.net/dev/parrot/blib/lib/libparrot.so: undefined reference to `find_vtable_meth' collect2: ld returned 1 exit status After applying it. A

Re: [perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-02-25 Thread Alek Storm
Now that 0.4.9 has been released, can this be committed? Thanks, Alek Storm On 2/19/07, Alek Storm <[EMAIL PROTECTED]> wrote: Thanks for the head start; now I know to include a test in the future. Here is an updated version of your patch, with various minor fixes. On 2/17/07, Allison Randal

Re: [perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-02-19 Thread Alek Storm
Thanks for the head start; now I know to include a test in the future. Here is an updated version of your patch, with various minor fixes. On 2/17/07, Allison Randal via RT <[EMAIL PROTECTED]> wrote: On Sat Jan 27 11:39:15 2007, [EMAIL PROTECTED] wrote: > This patch allows object vtable method o

[perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-02-17 Thread Allison Randal via RT
On Sat Jan 27 11:39:15 2007, [EMAIL PROTECTED] wrote: > This patch allows object vtable method overrides for find_method, get_attr, > get_attr, get_attr_str, set_attr, set_attr_str, and get_class. Now these > can be overridden in PIR using the :vtable flag or prefixing their > respective names wit

Re: [perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-01-28 Thread Patrick R. Michaud
On Sat, Jan 27, 2007 at 11:39:16AM -0800, Alek Storm wrote: > Also, though this is more of a language design question, > shouldn't we deprecate the double-underscore method of overriding, since we > now have the :vtable flag? Just a note that we cannot deprecate the double-underscore method of ove

[perl #41364] [PATCH] Fixed object vtable method overrides in PIR

2007-01-28 Thread Alek Storm
# New Ticket Created by "Alek Storm" # Please include the string: [perl #41364] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=41364 > This patch allows object vtable method overrides for find_method, get_attr, get_attr, ge