On Dec 30, 2006, at 12:31 PM, Will Coleda via RT wrote:
Perhaps a helpful failure message when run at the wrong time would
help.
And, inspired by your t/perl/README, I have submitted one for t/tools/
pmc2cutils/.
kid51
On Dec 30, 2006, at 1:06 AM, Kevin Tew via RT wrote:
I modified the root.in changes to follow the conventions already
present
in the file.
Kevin, I had hoped that creating a 'make' target in config/gen/
makefiles/root.in would provide a convenient way to run my tests of
Parrot::Pmc2c::
On Dec 30, 2006, at 12:31 PM, Will Coleda via RT wrote:
Perhaps a helpful failure message when run at the wrong time would
help.
In a patch to t/tools/pmc2cutils/00-qualify.t which I just submitted,
I have included such an explanatory message which will print out if
you run it with 'p
On Dec 30, 2006, at 2:56 PM, chromatic via RT wrote:
Here's what I get on an x86 Linux machine:
/usr/bin/perl t/harness t/tools/pmc2cutils/00-qualify.t
[snip]
t/tools/pmc2cutils/01-pmc2cutils.
# Failed test (t/tools/pmc2cutils/01-pmc2cutils.t at line 48)
# Parrot::Pmc2c::Utils->c
On Saturday 30 December 2006 15:42, James Keenan wrote:
> I think part of the problem is that, in the case of the 8 test files
> and lib/Parrot/Pmc2c/Utils.pm, I was submitting completely new files
> (hence, svn adds) rather than patching existing files. Since I don't
> have commit privileges, I
On Saturday 30 December 2006 15:42, James Keenan wrote:
> You didn't get the most recent version of the tests.
>
> I think part of the problem is that, in the case of the 8 test files
> and lib/Parrot/Pmc2c/Utils.pm, I was submitting completely new files
> (hence, svn adds) rather than patching ex
On Saturday 30 December 2006 05:47, James Keenan wrote:
> Can you send me some output with test failures? They've passed
> repeatedly on my machine.
>
> Please note that the pmc2cutil tests should only be run at a point
> *after* you've called perl Configure.pl but *before* you've called
> 'make'
Perhaps a helpful failure message when run at the wrong time would help.
On Dec 30, 2006, at 8:47 AM, James Keenan wrote:
On Dec 30, 2006, at 1:06 AM, Kevin Tew via RT wrote:
I modified the root.in changes to follow the conventions already
present
in the file.
The following composite patc
On Dec 30, 2006, at 1:06 AM, Kevin Tew via RT wrote:
I modified the root.in changes to follow the conventions already
present
in the file.
The following composite patch builds and passes parrot tests.
However the pmc2cutil tests are not passing. Could you post a new
diff
that includes pa
Further refinement of new file lib/Parrot/Pmc2c/Utils.pm. Coverage analysis
suggested that
the following line in gen_parent_list() (approx. line 547):
next if exists $class->{has_parent}{$parent};
... was never reached by my tests in the 'true' case (if exists
$$class{'has_parent'}{$paren
On Mon Dec 25 22:14:18 2006, [EMAIL PROTECTED] wrote:
> A few style comments here.
> [snip]
>
> > sub dump_vtable {
> > my $self = shift;
> > my $file = shift;
>
> Why two shifts here, when @_ goes unused through the rest of the method?
Fixed in attached patch: Utils.pm.
>
> > s
James Keenan via RT wrote:
On Sun Dec 03 14:08:31 2006, [EMAIL PROTECTED] wrote:
The files attach refactor tools/build/pmc2c.pl, extracting most of its
functionality into lib/
Parrot/Pmc2c/Utils.pm and provide 8 test files to be stored in t/tools/pmc2cutils/. These
substitute for my fi
James Keenan via RT wrote:
On Sun Dec 03 14:08:31 2006, [EMAIL PROTECTED] wrote:
The files attach refactor tools/build/pmc2c.pl, extracting most of its
functionality into lib/
Parrot/Pmc2c/Utils.pm and provide 8 test files to be stored in t/tools/pmc2cutils/. These
substitute for my fi
chromatic wrote:
On Monday 25 December 2006 21:44, James Keenan via RT wrote:
A few style comments here.
Utils.pm
unshift @{$allargsref->{include}}, (
".",
"$FindBin::Bin/../..",
"$FindBin::Bin/../../src/pmc/"
);
Why no File::Spec here?
There are certain ways i
On Monday 25 December 2006 21:44, James Keenan via RT wrote:
A few style comments here.
> Utils.pm
> unshift @{$allargsref->{include}}, (
> ".",
> "$FindBin::Bin/../..",
> "$FindBin::Bin/../../src/pmc/"
> );
Why no File::Spec here?
> if (File::Spec->file_nam
On Sat Dec 02 20:22:14 2006, [EMAIL PROTECTED] wrote:
>
> Tests of Parrot's build tools are not tests of Parrot itself. Once
> Parrot's make call has
> succeeded, testing the components of the build tools is irrelevant.
> Hence, including tests of
> the build tools in the suite of tests called by
On Thu Nov 30 19:25:49 2006, [EMAIL PROTECTED] wrote:
> On Thu Nov 30 18:34:48 2006, [EMAIL PROTECTED] wrote:
>
> I fixed the problem with GetOptions() -- but there are additional
> problems that will take time to
> diagnose. So my patches are not yet ready for prime time.
>
I'm attaching a file
On Thu Nov 30 18:34:48 2006, [EMAIL PROTECTED] wrote:
>
> Problem confirmed. I am working on it. I think I have misunderstood
> how to use
> Getopt::Long::GetOptions().
>
I fixed the problem with GetOptions() -- but there are additional problems that
will take time to
diagnose. So my patche
# New Ticket Created by James Keenan
# Please include the string: [perl #41020]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=41020 >
The file attached patches the following files in the Parrot
distribution:
tools/build
19 matches
Mail list logo
