Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-18 Thread Steve Fink
On Mar-18, Dan Sugalski wrote: > At 9:57 PM + 3/18/03, Nicholas Clark wrote: > >Oops. This turned into a ramble. "flush" ne "sync". If both are needed in > >different places, provide both as distinct methods. > > Valid point though. We need both a flush and a sync, since we can't > be sure th

Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-18 Thread Dan Sugalski
At 9:57 PM + 3/18/03, Nicholas Clark wrote: Oops. This turned into a ramble. "flush" ne "sync". If both are needed in different places, provide both as distinct methods. Valid point though. We need both a flush and a sync, since we can't be sure that what's living underneath an io handle is a

Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-18 Thread Nicholas Clark
On Tue, Mar 18, 2003 at 09:28:36AM -0500, Dan Sugalski wrote: > At 3:00 PM +0100 3/18/03, Juergen Boemmels wrote: > >Benjamin Goldberg <[EMAIL PROTECTED]> writes: > >> So... it is a slow system call, with no visible > >> effect -- why do we do it? > > > >Deepends on the semantics we want to have f

Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-18 Thread Dan Sugalski
At 3:00 PM +0100 3/18/03, Juergen Boemmels wrote: Benjamin Goldberg <[EMAIL PROTECTED]> writes: "JüRgen BöMmels" wrote: [snip] > void > PIO_unix_flush(theINTERP, ParrotIOLayer *layer, ParrotIO *io) > { > -# if 0 > fsync(io->fd); > -# endif > } AFAIK, for disk files, fsync has

Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-18 Thread Juergen Boemmels
Benjamin Goldberg <[EMAIL PROTECTED]> writes: > "JüRgen BöMmels" wrote: > [snip] > > void > > PIO_unix_flush(theINTERP, ParrotIOLayer *layer, ParrotIO *io) > > { > > -# if 0 > > fsync(io->fd); > > -# endif > > } > > AFAIK, for disk files, fsync has (should have) no visible effect from

Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-17 Thread Benjamin Goldberg
"JüRgen BöMmels" wrote: [snip] > void > PIO_unix_flush(theINTERP, ParrotIOLayer *layer, ParrotIO *io) > { > -# if 0 > fsync(io->fd); > -# endif > } AFAIK, for disk files, fsync has (should have) no visible effect from the point of view of any user program -- all it does is tell the OS t

Re: [perl #21600] [PATCH] Enable buffer io in PIO

2003-03-17 Thread Dan Sugalski
At 10:38 AM + 3/17/03, "Jürgen" "Bömmels" (via RT) wrote: Next baby-step in PIO: Enabling buffering. This patch patch enables the formerly stubbed out buffering, and shakes out some bugs (Only the first part: Write buffering). Certainly all tests passed on my machine. Applied, thanks. Looks l

[perl #21600] [PATCH] Enable buffer io in PIO

2003-03-17 Thread Jürgen
# New Ticket Created by Jürgen Bömmels # Please include the string: [perl #21600] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt2/Ticket/Display.html?id=21600 > Next baby-step in PIO: Enabling buffering. This patch patch enables the formerly stub