Re: [perl #17739] [PATCH] Tests for assign ops

2002-10-06 Thread Dan Sugalski
At 10:35 PM +0100 10/4/02, Nicholas Clark wrote: >I don't feel qualified to apply various of the outstanding patches, for both >the above reasons. > >use more 'executive dictatorial decisions'; Working on that--give us a day or three. :) -- Dan -

Re: [perl #17739] [PATCH] Tests for assign ops

2002-10-05 Thread Leopold Toetsch
Nicholas Clark wrote: > I don't feel qualified to apply various of the outstanding patches, for both > the above reasons. > > use more 'executive dictatorial decisions'; Can't locate more.pm in @INC (@INC contains: [EMAIL PROTECTED] http://www.parrotcode.org/ .). > Nicholas Clark AOL &&

Re: [perl #17739] [PATCH] Tests for assign ops

2002-10-04 Thread Nicholas Clark
On Thu, Oct 03, 2002 at 08:02:59PM +, Simon Glover wrote: > # New Ticket Created by Simon Glover > # Please include the string: [perl #17739] > # in the subject line of all future correspondence about this issue. > # http://rt.perl.org/rt2/Ticket/Display.html?id=17739 > > > > > Patch b

RE: [perl #17739] [PATCH] Tests for assign ops

2002-10-04 Thread Jonathan Sillito
> -Original Message- > From: Peter Gibbs [mailto:[EMAIL PROTECTED]] > [snip] > An interesting question, not discussed when the change was > initiated, relates to property assignments eg > new P0, .PerlArray > set P0, 6 > This most certainly does not set register P0 to six, so the 's

Re: [perl #17739] [PATCH] Tests for assign ops

2002-10-04 Thread Peter Gibbs
Jonathan Sillito wrote: > So does that mean, the only set ops will be those that take two registers of > the same type? > > set_p_p > set_i_i > set_s_s > set_n_n Anything with a destination register type other than P will remain 'set', as the contents of the register itself are being changed (e.g

RE: [perl #17739] [PATCH] Tests for assign ops

2002-10-04 Thread Jonathan Sillito
002 11:43 PM > To: Leopold Toetsch; [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: Re: [perl #17739] [PATCH] Tests for assign ops > > > Leopold Toetsch wrote: > > Nothing against the tests - it's always a good thing to have > tests - but > > I'

Re: [perl #17739] [PATCH] Tests for assign ops

2002-10-03 Thread Peter Gibbs
Leopold Toetsch wrote: > Nothing against the tests - it's always a good thing to have tests - but > I'm confused: > > inline op set(inout PMC, in INT) { >$1->vtable->set_integer_native(interpreter, $1, $2); >goto NEXT(); > } > inline op assign(inout PMC, in INT) { >$1->vtable->set_in

Re: [perl #17739] [PATCH] Tests for assign ops

2002-10-03 Thread Leopold Toetsch
Simon Glover (via RT) wrote: > Patch below adds tests for assign_p_i, assign_p_n and assign_p_s. > (There's no test for assign_p_p because the scalar PMCs don't support > it yet). Nothing against the tests - it's always a good thing to have tests - but I'm confused: inline op set(inout PMC

[perl #17739] [PATCH] Tests for assign ops

2002-10-03 Thread via RT
# New Ticket Created by Simon Glover # Please include the string: [perl #17739] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt2/Ticket/Display.html?id=17739 > Patch below adds tests for assign_p_i, assign_p_n and assign_p_s. (There's no test f